New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728487 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted scroll bar is seen on chrome://settings/searchEngines

Reported by aiman.an...@etouch.net, Jun 1 2017

Issue description

Chrome Version: 61.0.3117.0 (Official Build)  (cohort: Stable)0924893aff1ceb991c789862db5ecff6802330c1-refs/heads/master@{#476123}(32/64-bit).

OS: Windows(7,8,8.1,10)

Steps to reproduce:
1.Launch Chrome, go to chrome://settings/searchEngines,observe

Actual Result: Unwanted scroll bar is seen
Expected Result: Scroll bar should not be seen

This is Regression issue broken in M-61,  will soon update other info.

Manual Bisect:
Good Build: 61.0.3116.0
Bad Build: 61.0.3117.0

Note: Will update MAC and LINUX status once build is available
 
Labels: OS-Linux OS-Mac
Issue is also observed on Linux(14.04 LTS) and Mac(10.11.6, 10.12.3) on #61.0.3117.0
Actual_Result.png
69.1 KB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3116.0 (Revision:475721).
Bad build:61.0.3117.0 (Revision:476123).

You are probably looking for a change made after 476066 (known good), but no later than 476067 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/53b8275babae3275605339cc09038d1dfbcf3ec0..e959cddaeca101036a8edf445a5d57c629632afc

From the CL above, assigning the issue to the concern owner

@dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2902363002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3117.0
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f60d062aad6f02456fb50f4f5d00936d47d08030

commit f60d062aad6f02456fb50f4f5d00936d47d08030
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Jun 02 17:12:38 2017

[MD settings] layout of buttons inside toggles and iron-lists

My prior CL 2902363002 did not properly account for buttons inside of
iron-lists (which will render poorly if overflow is visible, and clip off
ripples if overflow is visible); and buttons inside of toggle-buttons.
This CL addresses those gaps.

BUG= 728493 ,  728490 ,  728487 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2918953002
Cr-Commit-Position: refs/heads/master@{#476699}

[modify] https://crrev.com/f60d062aad6f02456fb50f4f5d00936d47d08030/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/f60d062aad6f02456fb50f4f5d00936d47d08030/chrome/browser/resources/settings/settings_shared_css.html

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2017

Labels: merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3235d6e5d9211b5569d3a606b428c5cf98359cf4

commit 3235d6e5d9211b5569d3a606b428c5cf98359cf4
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Jun 07 21:05:51 2017

[MD settings] layout of buttons inside toggles and iron-lists

My prior CL 2902363002 did not properly account for buttons inside of
iron-lists (which will render poorly if overflow is visible, and clip off
ripples if overflow is visible); and buttons inside of toggle-buttons.
This CL addresses those gaps.

BUG= 728493 ,  728490 ,  728487 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2918953002
Cr-Original-Commit-Position: refs/heads/master@{#476699}
Review-Url: https://codereview.chromium.org/2926643004 .
Cr-Commit-Position: refs/branch-heads/3112@{#236}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/3235d6e5d9211b5569d3a606b428c5cf98359cf4/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/3235d6e5d9211b5569d3a606b428c5cf98359cf4/chrome/browser/resources/settings/settings_shared_css.html

Labels: TE-Verified-M60 TE-Verified-60.0.3112.24
Tested the fix on windows 7, Ubuntu 14.04 and Mac 10.12.5 using chrome version 60.0.3112.24. scroll bar not seen under chrome://settings/searchEngines.
Please find the attached screen cast for the same.

adding TE-Verified labels.

Thanks,
728487.png
97.0 KB View Download

Sign in to add a comment