More details can be found in the doc here: https://docs.google.com/document/d/1nuMl72E458vL8oAWJbWrMvSNPxk09RCvobAOj1T2HLk/edit#heading=h.89d8pyl8hcsr
Grouped permission prompts are rarely used and the UI for them is of questionable benefit. We should switch to only using them for camera/mic permissions. More details can be found in the doc here: https://docs.google.com/document/d/1nuMl72E458vL8oAWJbWrMvSNPxk09RCvobAOj1T2HLk/edit#heading=h.89d8pyl8hcsr
We will also remove the allow/block drop-down in the case of mic+camera. See the attached screenshot.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55f9320b2d675e4b008597fd269d102e1d4d3b00 commit 55f9320b2d675e4b008597fd269d102e1d4d3b00 Author: raymes <raymes@chromium.org> Date: Mon Jun 05 04:55:34 2017 Only show grouped permission bubbles for mic/camera permissions This changes the desktop grouped permission bubble behavior such that we never show grouped permission prompts, accept in the case of mic/camers. All other permission prompts will be displayed sequentially. Testing is added for these cases. BUG= 728483 Review-Url: https://codereview.chromium.org/2913393002 Cr-Commit-Position: refs/heads/master@{#476942} [modify] https://crrev.com/55f9320b2d675e4b008597fd269d102e1d4d3b00/chrome/browser/permissions/mock_permission_request.cc [modify] https://crrev.com/55f9320b2d675e4b008597fd269d102e1d4d3b00/chrome/browser/permissions/mock_permission_request.h [modify] https://crrev.com/55f9320b2d675e4b008597fd269d102e1d4d3b00/chrome/browser/permissions/permission_request_manager.cc [modify] https://crrev.com/55f9320b2d675e4b008597fd269d102e1d4d3b00/chrome/browser/permissions/permission_request_manager.h [modify] https://crrev.com/55f9320b2d675e4b008597fd269d102e1d4d3b00/chrome/browser/permissions/permission_request_manager_browsertest.cc [modify] https://crrev.com/55f9320b2d675e4b008597fd269d102e1d4d3b00/chrome/browser/permissions/permission_request_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/176bcdca55786801816ab769ffbb9f9969ee98d3 commit 176bcdca55786801816ab769ffbb9f9969ee98d3 Author: raymes <raymes@chromium.org> Date: Tue Jun 06 00:17:24 2017 Remove the Allow/Block drop-down from grouped permission requests Grouped permission requests are being removed, except in the case of Mic/Camera. In that case, there will not be Allow/Block drop-downs for each permission requested. Instead there will be 2 individual Allow/Block buttons as in the case of single permission requests. BUG= 728483 Review-Url: https://codereview.chromium.org/2917323002 Cr-Commit-Position: refs/heads/master@{#477129} [modify] https://crrev.com/176bcdca55786801816ab769ffbb9f9969ee98d3/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc [modify] https://crrev.com/176bcdca55786801816ab769ffbb9f9969ee98d3/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/553c6205012763878d78ad8ca19e468efe9ec244 commit 553c6205012763878d78ad8ca19e468efe9ec244 Author: raymes <raymes@chromium.org> Date: Tue Jun 06 22:20:49 2017 Remove the permission toggles from grouped permission infobars on Android Only mic/camera permissions will be allowed to be grouped going forward and these will not have a toggle allowing selecting each individual permission. This removes those toggles from the Android grouped infobars. BUG= 728483 Review-Url: https://codereview.chromium.org/2917353003 Cr-Commit-Position: refs/heads/master@{#477434} [modify] https://crrev.com/553c6205012763878d78ad8ca19e468efe9ec244/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java [modify] https://crrev.com/553c6205012763878d78ad8ca19e468efe9ec244/chrome/browser/android/chrome_jni_registrar.cc [modify] https://crrev.com/553c6205012763878d78ad8ca19e468efe9ec244/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc [modify] https://crrev.com/553c6205012763878d78ad8ca19e468efe9ec244/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85102c98e4932dba40d36b19c95cff077c86e0ba commit 85102c98e4932dba40d36b19c95cff077c86e0ba Author: raymes <raymes@chromium.org> Date: Tue Jun 06 22:28:39 2017 Remove |accept_states_| from PermissionRequestManager PermissionRequestManager previously stored accept_states_ for tracking the state of the Allow/Block drop-down for each permission in a grouped permission request. These drop-downs are being removed, so this removes accept_states. There can still be grouped permission prompts though (for mic/camera) so this changes the behavior of Accept() to accept all permissions in the request, and Deny() to deny all permissions in the request. The UMA recording functions have been updated accordingly. BUG= 728483 Review-Url: https://codereview.chromium.org/2922933002 Cr-Commit-Position: refs/heads/master@{#477439} [modify] https://crrev.com/85102c98e4932dba40d36b19c95cff077c86e0ba/chrome/browser/permissions/permission_request_manager.cc [modify] https://crrev.com/85102c98e4932dba40d36b19c95cff077c86e0ba/chrome/browser/permissions/permission_request_manager.h [modify] https://crrev.com/85102c98e4932dba40d36b19c95cff077c86e0ba/chrome/browser/permissions/permission_request_manager_unittest.cc [modify] https://crrev.com/85102c98e4932dba40d36b19c95cff077c86e0ba/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/85102c98e4932dba40d36b19c95cff077c86e0ba/chrome/browser/permissions/permission_uma_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25629f4082fc2b5c990349eb98e22700f8947d70 commit 25629f4082fc2b5c990349eb98e22700f8947d70 Author: raymes <raymes@chromium.org> Date: Tue Jun 06 22:34:07 2017 Remove the Allow/Block drop-down from grouped permission requests for cocoa Grouped permission requests are being removed, except in the case of Mic/Camera. In that case, there will not be Allow/Block drop-downs for each permission requested. Instead there will be 2 individual Allow/Block buttons as in the case of single permission requests. BUG= 728483 Review-Url: https://codereview.chromium.org/2922233003 Cr-Commit-Position: refs/heads/master@{#477442} [modify] https://crrev.com/25629f4082fc2b5c990349eb98e22700f8947d70/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm [modify] https://crrev.com/25629f4082fc2b5c990349eb98e22700f8947d70/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27eec01fb796388d60e049444c65ebe2be738428 commit 27eec01fb796388d60e049444c65ebe2be738428 Author: raymes <raymes@chromium.org> Date: Wed Jun 07 03:35:25 2017 Remove remaining dead code that was used to implement grouped permission drop downs Grouped permission requests are being removed, except in the case of Mic/Camera. In that case, there will not be Allow/Block drop-downs for each permission requested. Instead there will be 2 individual Allow/Block buttons as in the case of single permission requests. This CL removes the remaining dead code that was used to implement the drop-downs. BUG= 728483 Review-Url: https://codereview.chromium.org/2922313002 Cr-Commit-Position: refs/heads/master@{#477536} [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/permissions/grouped_permission_infobar_delegate_android.h [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/permissions/permission_prompt_android.cc [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/permissions/permission_prompt_android.h [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/permissions/permission_request_manager.cc [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/permissions/permission_request_manager.h [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/permissions/permission_request_manager_unittest.cc [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/page_info/permission_menu_model.cc [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/page_info/permission_menu_model.h [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/page_info/permission_menu_model_unittest.cc [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/permission_bubble/permission_prompt.h [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc [modify] https://crrev.com/27eec01fb796388d60e049444c65ebe2be738428/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e67aadd0a50676f65e8cca7443df1d9245db3ab commit 0e67aadd0a50676f65e8cca7443df1d9245db3ab Author: Timothy Loh <timloh@chromium.org> Date: Wed Nov 08 00:45:10 2017 Remove histograms for grouped permission bubbles In M61 we restricted permissions to only group Mic+Camera, which made the histograms for grouped permission bubbles (which permissions were grouped together, how many were grouped) redundant. The same data can be readily obtained from Permissions.Prompt.(Accepted/Denied/Shown). Bug: 728483 , 638076 Change-Id: Iab49387d0b0d86e3e2a269cfa94f9072f1db95bb Reviewed-on: https://chromium-review.googlesource.com/756633 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#514680} [modify] https://crrev.com/0e67aadd0a50676f65e8cca7443df1d9245db3ab/chrome/browser/permissions/permission_request_manager_unittest.cc [modify] https://crrev.com/0e67aadd0a50676f65e8cca7443df1d9245db3ab/chrome/browser/permissions/permission_uma_util.cc [modify] https://crrev.com/0e67aadd0a50676f65e8cca7443df1d9245db3ab/chrome/browser/permissions/permission_uma_util.h [modify] https://crrev.com/0e67aadd0a50676f65e8cca7443df1d9245db3ab/tools/metrics/histograms/histograms.xml
Comment 1 by raymes@chromium.org
, Jun 1 2017