New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728474 link

Starred by 8 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Mac
Pri: 1
Type: Feature
Launch-Accessibility: NA
Launch-Exp-Leadership: NA
Launch-Leadership: ReviewRequested
Launch-Legal: Yes
Launch-M-Approved: 70-Beta , 70-Stable-Exp , 70-Stable
Launch-M-Target: 70-Dev , 70-Beta , 70-Stable-Exp , 70-Stable
Launch-Privacy: Yes
Launch-Security: Yes
Launch-Test: NA
Launch-UI: NA
Rollout-Type: Default

Blocked on:
issue 646035
issue 738447
issue 756590



Sign in to add a comment

Launch Shape Detection API

Project Member Reported by owe...@chromium.org, Jun 1 2017

Issue description

Add web platform API for detection of faces, text and barcodes using the hardware accelerated capabilities of the client device.

Eng owner: reillyg
Product owner: reillyg (PM? What PM?)

Mocks: N/A (no new UI, only an API)

Specification: https://wicg.github.io/shape-detection-api

Design doc (send to chrome-design-docs@): http://tinyurl.com/shape-detection-in-chromium

Privacy survey: crbug.com/738447

Test survey: See comment #23

 
**Bulk edit**

Feature freeze for M-61 is Friday June 23, and we are trying to lock down the shipping set of features. Your feature has either M=61 or Launch-M-Target=61-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested).

To help clarify what's shipping, we will change the milestone label for your launch to M-62 by Tues, 6/27 (since there appears to be no activity in review). If you still plan to ship for M-61, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested).

Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
Labels: -Launch-M-Target-61-Stable -Launch-M-Target-61-Beta Launch-M-Target-62-Stable M-62 Launch-M-Target-62-Beta Launch-M-Target-62-Stable-Exp
**Bulk edit**

We are now past M-61 FF. Since you still haven't transitioned to a review state, we are assuming that you are not planning to launch in M-61. As such, we're updating the MStone to M-62.

If you still intend to launch in M-61, feel free to change this back, but *please begin your xfnl reviews now*!

Thanks for your help with ensuring a smooth process.

Comment 3 by owe...@chromium.org, Jun 29 2017

Labels: -Launch-M-Target-62-Beta -Launch-M-Target-62-Stable-Exp -Launch-M-Target-62-Stable Launch-M-Target-61-Beta Launch-M-Target-61-Stable-Exp Launch-M-Target-61-Stable Launch-Status-Review-Requested
Requesting reviews, aiming to still land in 61
Labels: -Launch-Privacy-NotReviewed Launch-Privacy-Started
Project Member

Comment 5 by chrome-privacy-bot@chromium.org, Jun 30 2017

Blockedon: 738447
Labels: PrivacyReview-738447
Adding privacy review bug issue 738447 as a label to the launch bug issue 728474. This is an automated message.
Labels: -M-62 M-61
Just realized there was an M-62 label added that we didn't update to reflect we're still targeting M-61, so updating that now.
Cc: owe...@chromium.org
Owner: rsesek@chromium.org
Assigning to robert for security review
Labels: -Launch-Privacy-Started Launch-Privacy-Yes
Can you please fill out the test survey?
Cc: rsesek@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
I don't know why I'm the owner of this issue.
Owner: owe...@chromium.org
Status: Assigned (was: Untriaged)
Reminder to please fill out the test survey, https://goto.google.com/chrome-test-questions.
Blockedon: 756590
Cc: ligim...@chromium.org
Checking whether the feature us ready for testing?

If yes, please fill out the test survey, https://goto.google.com/chrome-test-questions.
This feature is targeted for 61-Stable and M61 is going to stable next week. Legal,Security,Test bits (test survey missing) are not yet flipped.  

owencm@ if this is still on target for M61, please make sure that cross functional bits are flipped latest by Friday (09/01).

Comment 16 by aluo@chromium.org, Sep 5 2017

What's the status of this feature?  Test survey is not filled out and also it's shown to be blocking on 756590 which means we're lacking automated test coverage.  M-61 stable for Android is today, we'll likely have to postpone this.
Labels: -Launch-Status-Review-Requested -Launch-M-Target-61-Dev -Launch-M-Target-61-Beta -Launch-M-Target-61-Stable-Exp -Launch-M-Target-61-Stable
Note: this is *not* launching in 61 and accidentally didn't have the label removed until now. Removing mstone labels while we work on it from the eng side, will re-add mstone labels and mark as review requested at the appropriate time.
Project Member

Comment 18 by sheriffbot@chromium.org, Mar 7 2018

Labels: Hotlist-LaunchArchive
This launch bug is marked for milestone "61" and not been modified in the last 90 days. The current stable milestone is "65". Please review and close it if applicable.
If this issue should remain open, remove the "Hotlist-LaunchArchive" label. If no action is taken, it will be archived in 30 days.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by sheriffbot@chromium.org, Apr 9 2018

Status: Archived (was: Assigned)
This bug appears to be inactive and it has been over 30 days since the "Hotlist-LaunchArchive" label was applied. Hence, archiving this issue. Please reopen and remove the "Hotlist-LaunchArchive" label if it is still valid.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Blink>ImageCapture
Labels: -PM-owencm -TL-mcasas -Hotlist-LaunchArchive -M-61 PM-reillyg TL-reillyg M-70
Owner: reillyg@chromium.org
Status: Assigned (was: Archived)
I am planning to launch an Origin Trial for this feature in Chrome 70. Re-opening this launch review issue.
Labels: Launch-M-Target-70-Dev Launch-M-Target-70-Beta Launch-M-Target-70-Stable-Exp Launch-M-Target-70-Stable
Description: Show this description
1. Does the feature need manual testing?

No.

2. Feature implementation status

  a. What is currently working and not working/known issues?

  The feature is currently implemented and working on Android, macOS and Windows. These are the platforms on which hardware acceleration is available. The API will be exposed to web content on other platforms but will return an error.

  b. Is all the code landed in canary and ready for testing?

  Yes.

3. Link to Design Doc:

TODO

4. Link to demos (if any):

https://paul.kinlan.me/face-detection/
https://paul.kinlan.me/barcode-detection/
https://paul.kinlan.me/detecting-text-in-an-image/

5. Link to Test Plan:

N/A

6. Are there flags or setup are needed to enable this feature? Is it on by default?

It is available behind the --experimental-web-platform-features flag.

7. Are there any special points of interest from a testing perspective?

No.

8. Is the feature the same across all platforms?

Availability of the feature depends on platform support for hardware accelerated image recognition.

  a. Is the user flow same across all platforms? (Answer if applicable to both Desktop and Mobile)

  Yes.

  b. Is the code flow/logic different on any specific platforms (i.e code branching or logic duplication)

  Each platform has its own implementation of the integration between the web API and the platform-specific hardware accelerated image recognition API.

9. What's automated (Unit tests, Integration tests, API tests, Browser tests, E2E tests)? Please provide links to automated tests.

This feature is tested by unit tests in //services/shape_detection and layout tests in //third_party/WebKit/LayoutTests/shapedetection.

10. What’s not automated that needs manual testing?

Nothing.

11. What is the crbug label(s) and/or component(s) for the feature?

The crbug component is Blink>ImageCapture.

12. Are there any other team members or mailing lists that should be notified if issues are found?

Contacts are reillyg@chromium.org and mcasas@chromium.org.

13. Rollout plan: 

  a. Will this roll out on by default for 100% or will it be rolled out incrementally behind a finch experiment? Is it behind a finch flag even if it’s on by default?

  This will roll out initially via an Origin Trial, enabled for sites which request a token from us. When shipped as a stable web API it will roll out on by default.

  b. Is there a mechanism to turn off the feature if it breaks product functionality or performance?

  There is a Blink feature flag for this API however this cannot be toggled directly via Finch.

  c. How will you monitor the stability of the feature and/or experiment groups?

  Crash reports.

14. Confirm that there is no negative meaningful performance impact and how that was checked:

There is a small negative performance impact associated with enabling any new web-exposed API due to the overhead of bindings initialization. Other than that this API is dormant unless used by web content.
Labels: -Launch-Security-NotReviewed -Launch-Legal-NotReviewed -Launch-Test-NotReviewed Launch-Exp-Leadership-NotReviewed Launch-Leadership-NotReviewed Launch-Legal-ReviewRequested Launch-Security-ReviewRequested Launch-Test-ReviewRequested Rollout-Type-Default
Labels: -Launch-Test-ReviewRequested Launch-Test-NA
No manual testing required ( #23) , flipping the testbit to NA.
Description: Show this description
Labels: -Launch-Security-ReviewRequested Launch-Security-NeedInfo
I added a question in the design doc.
palmer@, I believe reillyg@ replied to your comments. let us know what else is needed? we would like to OT in M70 if possible.
Labels: -Launch-Security-NeedInfo Launch-Security-Yes
Great, thanks!
Cc: dxie@chromium.org
Labels: -Launch-Leadership-NotReviewed -Launch-Exp-Leadership-NotReviewed -PM-reillyg PM-dxie Launch-Exp-Leadership-NA Launch-Leadership-ReviewRequested
Double-checking with go/newChromeFeature it looks like an Origin Trial launch is requires Launch-Leadership and not Launch-Exp-Leadership.
Does this work on Windows? The OS box is not checked there.
Labels: OS-Windows
By M61 (c3) it did only work on Mac and Android, now it's also supported
on Windows.
Labels: ShapeDetection
This still does not have legal approval. What's the status here?
Labels: -Launch-Legal-ReviewRequested Launch-Legal-Yes
Labels: Launch-M-Approved-70-Beta Launch-M-Approved-70-Stable-Exp
Greetings, feature team!

Your launch has been approved for the following milestones and channels:
 - M70+ for beta
 - M70+ for stable experimentation

Note that this approval only indicates you have the proper cross-functional sign-off to launch to the specified milestone and channel; if merges are required,  you must still complete the merge request process.

Questions?  Concerns?  Read more (or report bugs) about feature automation at go/chrome-launch-automation or reach out to jojwang@.
Labels: -Launch-Leadership-ReviewRequested Launch-Leadership-Yes
Labels: Launch-M-Approved-70-Stable
Greetings, feature team!

Your launch has been approved for the following milestones and channels:
 - M70+ for full stable roll-out

Note that this approval only indicates you have the proper cross-functional sign-off to launch to the specified milestone and channel; if merges are required,  you must still complete the merge request process.

Questions?  Concerns?  Read more (or report bugs) about feature automation at go/chrome-launch-automation or reach out to jojwang@.
Cc: nattestad@chromium.org
Labels: -Launch-Leadership-Yes -PM-dxie PM-nattestad Launch-Leadership-No
We want to sit on this for a bit. Thomas, can you come to launch review this week?
If you have specific questions to ask us during launch review can you add those here so we can gather information necessary to answer them?
I am traveling for most of this week but should be able to come to launch review if needed. Note that I haven't been with this API for its whole life and Reily definitely has more context here. Let me know if there is anything specific we should explore and I can explore with relevant folk. 
Labels: -M-70 Target-70 Proj-Fugu
Labels: PM-pjmclachlan
Labels: Type-Feature
Labels: -Launch-Leadership-No Launch-Leadership-ReviewRequested
What happens on Windows/Mac/Android if a GPU is blacklisted?
Cc: pjmclachlan@google.com
Labels: -TL-reillyg -PM-nattestad -PM-pjmclachlan
Labels: Pri-1
Labels: -Target-70 Target-71 M-74
Labels: -Target-71 -M-74 Target-70 M-75
Per reillyg@, Origin Trial started in M-70 (hence, Target-70)

Due to bugs and API feedback that will be rolled in, won't ship earlier than M-75.


Cc: tsteiner@google.com

Sign in to add a comment