Issue metadata
Sign in to add a comment
|
4.1%-12.1% regression in system_health.memory_mobile at 475877:475906 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 1 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8978024391534722272
,
Jun 2 2017
=== Auto-CCing suspected CL author nednguyen@google.com === Hi nednguyen@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : nednguyen Commit : 24245dde6fc83c8881775a3d2556797f5bba287b Date : Wed May 31 11:04:00 2017 Subject: Always execute network_quiescence.js script upon navigating to a page Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_tools/load_tools_docs Revision Result N chromium@475876 3277272 +- 0.0 6 good chromium@475891 3273741 +- 19338.3 6 good chromium@475895 3277144 +- 0.0 6 good chromium@475897 3277144 +- 0.0 6 good chromium@475897,catapult@24245dde6f 3698417 +- 776.241 6 bad <-- chromium@475898 3698383 +- 638.139 6 bad chromium@475899 3698309 +- 703.242 6 bad chromium@475906 3698360 +- 702.817 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.docs system_health.memory_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8978024391534722272 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5215950971863040 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 2 2017
This is expected to cause some slight perf change, but I don't know that it's gonna be that big :-/ I think we can just close this as Won't fix since this is a regression due to test change and not Chrome change. Juan: wdyt?
,
Jun 2 2017
Agreed. At least on this bug, these are only a few small-ish (< 400KiB) regressions on just a couple of pages. So fine to close. +benhrenry FYI, in case this shows up on system health (I'm doubtful) it would need to be discounted as they are not real regressions but changes in the way measurements are performed.
,
Jun 3 2017
Issue 728380 has been merged into this issue.
,
Jun 5 2017
,
Jun 5 2017
Issue 729625 has been merged into this issue.
,
Jun 5 2017
Issue 729628 has been merged into this issue.
,
Jun 5 2017
,
Jun 6 2017
Issue 729624 has been merged into this issue.
,
Jun 6 2017
,
Jun 7 2017
,
Jun 8 2017
We might need to have a closer look at this. There may not be much we can do, but after many of the dupes, some of the larger regressions are of about ~20MiB. See: https://chromeperf.appspot.com/group_report?bug_id=728471 +sullivan Also some of those alerts seem to have been triggered on summary metrics (e.g. browse_social) and not individual pages?
,
Jun 8 2017
I think the triggering on summary metrics was caused by bug 727234 .
,
Jun 9 2017
,
Jun 9 2017
Issue 731866 has been merged into this issue.
,
Jun 13 2017
Issue 732465 has been merged into this issue.
,
Jun 21 2017
I've had a look again. Large increases are all in v8:heap; I assume because we wait for network quiescence in more scenarios, more resources are being loaded. Should be fine to WontFix. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jasontiller@chromium.org
, Jun 1 2017