Expose WEBGL_compressed_texture_s3tc_srgb extension |
||||||||
Issue descriptionOn the public_webgl mailing list this extension was supported by a second WebGL implementer, and it was promoted to community approved in https://github.com/KhronosGroup/WebGL/pull/2411 . Chrome should expose this extension now. Kai, could you handle this? Since this is a trivial change we could consider requesting backport to M60 to get it out sooner. This is an important feature for Unity, a major WebGL partner.
,
Jun 1 2017
Yes, I'll take this.
,
Jun 1 2017
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d45b0a76a64f9815c573e8a15534a47c7160877 commit 0d45b0a76a64f9815c573e8a15534a47c7160877 Author: Kai Ninomiya <kainino@chromium.org> Date: Fri Jun 02 18:09:01 2017 Enable WEBGL_compressed_texture_s3tc_srgb This extension was moved to Community Approved: https://github.com/KhronosGroup/WebGL/pull/2411 Bug: 728465 , angleproject:2049 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia7632b9263abe4d9df21258e3d68b7d45fc99359 Reviewed-on: https://chromium-review.googlesource.com/520606 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#476721} [modify] https://crrev.com/0d45b0a76a64f9815c573e8a15534a47c7160877/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/0d45b0a76a64f9815c573e8a15534a47c7160877/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp [modify] https://crrev.com/0d45b0a76a64f9815c573e8a15534a47c7160877/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
,
Jun 2 2017
,
Jun 3 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
Merged
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c79205bf50e9135bebe70076d67598032d460d77 commit c79205bf50e9135bebe70076d67598032d460d77 Author: Kai Ninomiya <kainino@chromium.org> Date: Mon Jun 05 17:26:04 2017 Enable WEBGL_compressed_texture_s3tc_srgb This extension was moved to Community Approved: https://github.com/KhronosGroup/WebGL/pull/2411 TBR=kainino@chromium.org Bug: 728465 , angleproject:2049 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia7632b9263abe4d9df21258e3d68b7d45fc99359 Reviewed-on: https://chromium-review.googlesource.com/520606 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#476721}(cherry picked from commit 0d45b0a76a64f9815c573e8a15534a47c7160877) Reviewed-on: https://chromium-review.googlesource.com/523846 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#155} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/c79205bf50e9135bebe70076d67598032d460d77/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/c79205bf50e9135bebe70076d67598032d460d77/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp [modify] https://crrev.com/c79205bf50e9135bebe70076d67598032d460d77/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
,
Jun 5 2017
,
Jun 5 2017
Thanks Kai for turning this on and doing the merge!
,
Jun 5 2017
I think we need to remove the failure expectations for the passthrough command buffer.
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45db465b6f0187a7c98414bfacdbd9bc4c9ce334 commit 45db465b6f0187a7c98414bfacdbd9bc4c9ce334 Author: Kai Ninomiya <kainino@chromium.org> Date: Mon Jun 05 21:21:08 2017 Remove expectation for s3tc-srgb on passthrough TBR=kbr@chromium.org Bug: 728465 , angleproject:2049 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifcc459eb4aca8c91558885a30e888c18ba902490 Reviewed-on: https://chromium-review.googlesource.com/523848 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#477086} [modify] https://crrev.com/45db465b6f0187a7c98414bfacdbd9bc4c9ce334/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
,
Jun 5 2017
Thanks for remembering this; done.
,
Jun 5 2017
Great, thanks again! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kainino@chromium.org
, Jun 1 2017