New issue
Advanced search Search tips

Issue 728455 link

Starred by 1 user
Status: Archived
Owner:
varkha@chromium.org
Closed: Jun 2017
Cc:
sadrul@chromium.org
msw@chromium.org
jamescook@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task

Blocking:
issue 564844



Sign in to add a comment

Ash should respect minimum window size set by Chrome browser

Project Member Reported by varkha@chromium.org, Jun 1 2017 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) run chrome --mash
(2) Resize chrome browser window (make it smaller)

What is the expected result?
Window cannot be resized to be smaller than the tab width and tabstrip height.

What happens instead?
Window can be resized to 104x36 dp

Ash uses a value returned by CustomFrameViewAsh::GetMinimumSize() to limit size in WindowResizer::GetSizeForDrag(). Chrome browser process is using BrowserNonClientFrameViewMus::GetMinimumSize() but that value is not available to ash when using --mash.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54

commit 1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54
Author: varkha <varkha@chromium.org>
Date: Thu Jun 22 23:27:11 2017

[mus+ash] Fixes minimum browser window size with --mash

Store kPreferredSize property in an aura::Window when Chrome browser frame
is updated upon BrowserView::Layout().
Retrieve it in CustomFrameViewAsh::GetMinimumSize() to ensure that in Mus
the browser window frame honors window size constraints.

This only affects chrome browser frame when running with --mash.

BUG= 728455 
TEST=BrowserNonClientFrameViewAshTest.FrameMinSizeIsUpdated
     CustomFrameViewAshTest.HonorsMinimumSizeProperty

Review-Url: https://codereview.chromium.org/2914793005
Cr-Commit-Position: refs/heads/master@{#481716}

[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/top_container_view.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/chrome/browser/ui/views/frame/top_container_view.h
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/ui/aura/client/aura_constants.h
[modify] https://crrev.com/1a44d226bb121c7f29cbe2edc3c0215ebc3f7a54/ui/aura/mus/property_converter.cc

Comment 2 by varkha@chromium.org, Jun 23 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
►

Sign in to add a comment