Implement Network.emulateNetworkConditions in headless mode |
||||||
Issue descriptionHeadless currently does not allow emulating network conditions. Once we can intercept network requests, we can do similarly as https://cs.chromium.org/chromium/src/chrome/browser/devtools/devtools_network_interceptor.h
,
Jun 1 2017
,
Jun 1 2017
,
Jul 11 2017
"Throttling". There, now when I search crbug for `headless throttling` I'll find this. ;)
,
Oct 9 2017
,
Oct 9 2017
Apologies for the misunderstanding. irisu@ is looking into this (see https://chromium-review.googlesource.com/c/chromium/src/+/701900) We have to add specific logic to remove the extra headers when custom protocol handlers are in use.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/413c0040423c5ca54d9363b9fc9499798056416e commit 413c0040423c5ca54d9363b9fc9499798056416e Author: Iris Uy <irisu@chromium.org> Date: Fri Oct 13 00:47:32 2017 Use DevToolsNetworkTransaction in headless mode. This is needed to enable network emulation in headless mode. Bug: 728451 Change-Id: Ib3a3bf49cf950eb2f0c6b41595984233bd3ca67b Reviewed-on: https://chromium-review.googlesource.com/701900 Reviewed-by: David Vallet <dvallet@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Iris Uy <irisu@chromium.org> Cr-Commit-Position: refs/heads/master@{#508571} [modify] https://crrev.com/413c0040423c5ca54d9363b9fc9499798056416e/headless/lib/browser/headless_browser_context_impl.cc [modify] https://crrev.com/413c0040423c5ca54d9363b9fc9499798056416e/headless/lib/browser/headless_browser_context_impl.h [modify] https://crrev.com/413c0040423c5ca54d9363b9fc9499798056416e/headless/lib/browser/headless_network_delegate.cc [modify] https://crrev.com/413c0040423c5ca54d9363b9fc9499798056416e/headless/lib/browser/headless_url_request_context_getter.cc
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8931a104b145ccf92390f6f48fba6553a1af92e4 commit 8931a104b145ccf92390f6f48fba6553a1af92e4 Author: Iris Uy <irisu@chromium.org> Date: Mon Oct 16 01:12:01 2017 Add Network Emulation Test to headless browsertests Bug: 728451 Change-Id: Ic979050e3bb5d6b230601f2d3acc1a5467194855 Reviewed-on: https://chromium-review.googlesource.com/717876 Commit-Queue: Iris Uy <irisu@chromium.org> Reviewed-by: David Vallet <dvallet@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#508968} [modify] https://crrev.com/8931a104b145ccf92390f6f48fba6553a1af92e4/headless/lib/headless_devtools_client_browsertest.cc
,
Oct 16 2017
,
Dec 11 2017
To any folks reading this ticket.. as of comment #7, network throttling (including latency and throughput shaping) and offline emulation is supported in headless. This shipped in Chrome 63.0.3239.0. \o/ Thanks irisu! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dvallet@chromium.org
, Jun 1 2017