New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 18 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 702384


Show other hotlists

Hotlists containing this issue:
Hotlist-1
Hotlist-1


Sign in to add a comment
link

Issue 728451: Implement Network.emulateNetworkConditions in headless mode

Reported by dvallet@chromium.org, Jun 1 2017 Project Member

Issue description

Headless currently does not allow emulating network conditions. Once we can intercept network requests, we can do similarly as https://cs.chromium.org/chromium/src/chrome/browser/devtools/devtools_network_interceptor.h
 

Comment 1 by dvallet@chromium.org, Jun 1 2017

Labels: -Type-Bug Type-Feature

Comment 2 by dvallet@chromium.org, Jun 1 2017

Owner: irisu@chromium.org
Status: Assigned (was: Available)

Comment 3 by ericbidelman@chromium.org, Jun 1 2017

Cc: ericbidelman@chromium.org

Comment 4 by paulir...@chromium.org, Jul 11 2017

"Throttling". There, now when I search crbug for `headless throttling` I'll find this. ;)

Comment 5 by caseq@chromium.org, Oct 9 2017

Owner: caseq@chromium.org
Status: Started (was: Assigned)

Comment 6 by dvallet@chromium.org, Oct 9 2017

Cc: caseq@chromium.org
Owner: irisu@chromium.org
Apologies for the misunderstanding. irisu@ is looking into this (see
https://chromium-review.googlesource.com/c/chromium/src/+/701900)
We have to add specific logic to remove the extra headers when custom protocol handlers are in use.

Comment 7 by bugdroid1@chromium.org, Oct 13 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8931a104b145ccf92390f6f48fba6553a1af92e4

commit 8931a104b145ccf92390f6f48fba6553a1af92e4
Author: Iris Uy <irisu@chromium.org>
Date: Mon Oct 16 01:12:01 2017

Add Network Emulation Test to headless browsertests

Bug:  728451 
Change-Id: Ic979050e3bb5d6b230601f2d3acc1a5467194855
Reviewed-on: https://chromium-review.googlesource.com/717876
Commit-Queue: Iris Uy <irisu@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508968}
[modify] https://crrev.com/8931a104b145ccf92390f6f48fba6553a1af92e4/headless/lib/headless_devtools_client_browsertest.cc

Comment 9 by irisu@chromium.org, Oct 16 2017

Status: Fixed (was: Started)

Comment 10 by paulir...@chromium.org, Dec 11 2017

To any folks reading this ticket.. as of comment #7, network throttling (including latency and throughput shaping) and offline emulation is supported in headless.  This shipped in Chrome 63.0.3239.0.

\o/ Thanks irisu!

Sign in to add a comment