Add support for selecting only a single demo mode feature |
|||||||||
Issue descriptionChrome Version: M60 OS: Android What steps will reproduce the problem? (1) Start Chrome (2) Go to chrome://flags (3) Select a particular feature to demo for In-Product Help What is the expected result? A particular feature is enabled, and only that one. What happens instead? All features are enabled, and there are no choice per feature.
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5f0bccb0526f845360270c68cdaf0aa991a8ed5 commit f5f0bccb0526f845360270c68cdaf0aa991a8ed5 Author: Tommy Nyquist <nyquist@chromium.org> Date: Thu Jun 01 23:08:11 2017 Add support for selecting a single feature for demoing In-Product Help The In-Product Help demo mode currently only supports enabling demoing all In-Product Help features, or none of them. This leads to issues with testing some of them, since they might happen at the same time, and it is confusing to test. This CL fixes that issue by adding support for selecting only a single In-Product Help feature to demo at a time, in addition to keeping the old choice of enabling all or none of them. BUG= 728449 Change-Id: I78902c48117eb4e6602f768186579d08f4a83217 Reviewed-on: https://chromium-review.googlesource.com/520626 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#476472} [modify] https://crrev.com/f5f0bccb0526f845360270c68cdaf0aa991a8ed5/chrome/browser/about_flags.cc [modify] https://crrev.com/f5f0bccb0526f845360270c68cdaf0aa991a8ed5/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/f5f0bccb0526f845360270c68cdaf0aa991a8ed5/chrome/browser/flag_descriptions.h [modify] https://crrev.com/f5f0bccb0526f845360270c68cdaf0aa991a8ed5/components/feature_engagement_tracker/DEPS [modify] https://crrev.com/f5f0bccb0526f845360270c68cdaf0aa991a8ed5/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc [modify] https://crrev.com/f5f0bccb0526f845360270c68cdaf0aa991a8ed5/components/feature_engagement_tracker/public/BUILD.gn [modify] https://crrev.com/f5f0bccb0526f845360270c68cdaf0aa991a8ed5/components/feature_engagement_tracker/public/feature_list.cc [modify] https://crrev.com/f5f0bccb0526f845360270c68cdaf0aa991a8ed5/components/feature_engagement_tracker/public/feature_list.h
,
Jun 1 2017
,
Jun 1 2017
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2017
Requesting merge since this will help a bunch with testing the UI surface of In-Product Help.
,
Jun 1 2017
Labels got accidentally changed in last comment.
,
Jun 1 2017
Approved for M60 branch 3112.
,
Jun 1 2017
,
Jun 1 2017
Thanks!
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a34c0df3a21f98cf634f01269ad11a4b784a6bf commit 1a34c0df3a21f98cf634f01269ad11a4b784a6bf Author: Tommy Nyquist <nyquist@chromium.org> Date: Thu Jun 01 23:41:12 2017 Add support for selecting a single feature for demoing In-Product Help The In-Product Help demo mode currently only supports enabling demoing all In-Product Help features, or none of them. This leads to issues with testing some of them, since they might happen at the same time, and it is confusing to test. This CL fixes that issue by adding support for selecting only a single In-Product Help feature to demo at a time, in addition to keeping the old choice of enabling all or none of them. BUG= 728449 TBR=nyquist@chromium.org (cherry picked from commit f5f0bccb0526f845360270c68cdaf0aa991a8ed5) Change-Id: I78902c48117eb4e6602f768186579d08f4a83217 Reviewed-on: https://chromium-review.googlesource.com/520626 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#476472} Reviewed-on: https://chromium-review.googlesource.com/521772 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#105} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/1a34c0df3a21f98cf634f01269ad11a4b784a6bf/chrome/browser/about_flags.cc [modify] https://crrev.com/1a34c0df3a21f98cf634f01269ad11a4b784a6bf/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/1a34c0df3a21f98cf634f01269ad11a4b784a6bf/chrome/browser/flag_descriptions.h [modify] https://crrev.com/1a34c0df3a21f98cf634f01269ad11a4b784a6bf/components/feature_engagement_tracker/DEPS [modify] https://crrev.com/1a34c0df3a21f98cf634f01269ad11a4b784a6bf/components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc [modify] https://crrev.com/1a34c0df3a21f98cf634f01269ad11a4b784a6bf/components/feature_engagement_tracker/public/BUILD.gn [modify] https://crrev.com/1a34c0df3a21f98cf634f01269ad11a4b784a6bf/components/feature_engagement_tracker/public/feature_list.cc [modify] https://crrev.com/1a34c0df3a21f98cf634f01269ad11a4b784a6bf/components/feature_engagement_tracker/public/feature_list.h
,
Jun 1 2017
,
Jun 21 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nyquist@chromium.org
, Jun 1 2017