New issue
Advanced search Search tips

Issue 728448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove file_thread_task_runner parameter from SerialIoHandler::Create

Project Member Reported by reillyg@chromium.org, Jun 1 2017

Issue description

This parameter is saved in a member variable and available via an accessor method but appears to be unused. It should be removed.
 
@reillyg, shall i start work on it?
i have raised a patch for this issue
https://codereview.chromium.org/2914173002/

PTAL
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f83b935b39059fb1f407857b0da6f4614e16e71

commit 1f83b935b39059fb1f407857b0da6f4614e16e71
Author: sujiths.s <sujiths.s@samsung.com>
Date: Thu Jun 22 14:37:02 2017

Removed the use of file_thread_task_runner across
SerialIoHandler and BattOrAgent.

BUG= 728448 

Review-Url: https://codereview.chromium.org/2914173002
Cr-Commit-Position: refs/heads/master@{#481529}

[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/content/browser/tracing/power_tracing_agent.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/device/serial/serial_io_handler.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/device/serial/serial_io_handler.h
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/device/serial/serial_io_handler_posix.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/device/serial/serial_io_handler_posix.h
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/device/serial/serial_io_handler_posix_unittest.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/device/serial/serial_io_handler_win.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/device/serial/serial_io_handler_win.h
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/device/serial/test_serial_io_handler.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/extensions/browser/api/serial/serial_connection.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/tools/battor_agent/battor_agent.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/tools/battor_agent/battor_agent.h
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/tools/battor_agent/battor_agent_bin.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/tools/battor_agent/battor_agent_unittest.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/tools/battor_agent/battor_connection_impl.cc
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/tools/battor_agent/battor_connection_impl.h
[modify] https://crrev.com/1f83b935b39059fb1f407857b0da6f4614e16e71/tools/battor_agent/battor_connection_impl_unittest.cc

Status: Fixed (was: Available)

Sign in to add a comment