Design doc : go/downloads-internal-api
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b416f37c54a5e26c12704bf7a0f626289c2b5e89 commit b416f37c54a5e26c12704bf7a0f626289c2b5e89 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Jun 14 01:38:46 2017 Download task scheduler : Initial implementation This CL adds a DownloadTaskScheduler which can schedule or cancel various types of background tasks such as download task, cleanup task etc. The background task when run successfully will initialize native and call OnStartScheduledTask on associated DownloadService. Bug: 728445 Change-Id: Ie7dfcbc58c1624de273b4515271063eaf68ec71f Reviewed-on: https://chromium-review.googlesource.com/522383 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#479245} [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/android/BUILD.gn [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/android/java/src/org/chromium/chrome/browser/download/service/DownloadBackgroundTask.java [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/android/java/src/org/chromium/chrome/browser/download/service/DownloadTaskScheduler.java [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/android/java_sources.gni [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/BUILD.gn [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/android/chrome_jni_registrar.cc [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/android/download/service/download_background_task.cc [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/android/download/service/download_background_task.h [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/android/download/service/download_task_scheduler.cc [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/android/download/service/download_task_scheduler.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/download/download_service_factory.cc [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/download/download_task_scheduler_impl.cc [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/chrome/browser/download/download_task_scheduler_impl.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerUma.java [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/TaskIds.java [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/background_task_scheduler/android/junit/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerUmaTest.java [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/components_unittests.filter [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/content/factory/download_service_factory.cc [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/content/factory/download_service_factory.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/controller.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/controller_impl.cc [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/controller_impl.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/controller_impl_unittest.cc [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/download_service_impl.cc [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/download_service_impl.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/stats.cc [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/stats.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/internal/test/mock_controller.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/public/BUILD.gn [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/public/download_service.h [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/public/download_task_types.h [add] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/components/download/public/task_scheduler.h [modify] https://crrev.com/b416f37c54a5e26c12704bf7a0f626289c2b5e89/tools/android/eclipse/.classpath
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9357c7e77960c6468f9f1939ef72940bb6836be4 commit 9357c7e77960c6468f9f1939ef72940bb6836be4 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Jun 21 05:54:45 2017 Download Service : Added file monitor This CL adds a FileMonitor which is responsible for cleanup of any unwanted files in the disk. This will be called at startup to verify the state of the storage directory. Bug: 728445 Change-Id: If44588fd5a5fb49481d7ffea3e4eee77ce340040 Reviewed-on: https://chromium-review.googlesource.com/520846 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#481119} [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/components_unittests.filter [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/content/factory/download_service_factory.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/content/internal/download_driver_impl.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/BUILD.gn [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/config.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/config.h [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/controller_impl.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/controller_impl.h [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/controller_impl_unittest.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/driver_entry.h [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/entry.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/entry.h [add] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/file_monitor.h [add] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/file_monitor_impl.cc [add] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/file_monitor_impl.h [add] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/file_monitor_unittest.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/proto/entry.proto [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/proto_conversions.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/proto_conversions_unittest.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/stats.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/stats.h [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/test/entry_utils.cc [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/components/download/internal/test/entry_utils.h [modify] https://crrev.com/9357c7e77960c6468f9f1939ef72940bb6836be4/content/public/test/fake_download_item.cc
Is this fixed?
Yes, this is fixed.
Comment 1 by bugdroid1@chromium.org
, Jun 14 2017