I noticed that the include guards in usb_service_linux.h are missing and the ones in usb_device_linux.h were copy-pasted from usb_device_impl.h.
uploaded the patch for this @ https://codereview.chromium.org/2923773002/. PTAL.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0867b7646e170b2685bb47ed938fb4562f55c0df commit 0867b7646e170b2685bb47ed938fb4562f55c0df Author: nravi.n <nravi.n@samsung.com> Date: Thu Jun 08 04:12:34 2017 Fix include guards in //device/usb This patch updates the include guards for all .h files in //device/usb BUG= 728444 Review-Url: https://codereview.chromium.org/2923773002 Cr-Commit-Position: refs/heads/master@{#477882} [modify] https://crrev.com/0867b7646e170b2685bb47ed938fb4562f55c0df/AUTHORS [modify] https://crrev.com/0867b7646e170b2685bb47ed938fb4562f55c0df/device/usb/fake_usb_device_handle.h [modify] https://crrev.com/0867b7646e170b2685bb47ed938fb4562f55c0df/device/usb/usb_device_linux.h [modify] https://crrev.com/0867b7646e170b2685bb47ed938fb4562f55c0df/device/usb/usb_service_impl.h [modify] https://crrev.com/0867b7646e170b2685bb47ed938fb4562f55c0df/device/usb/usb_service_linux.h [modify] https://crrev.com/0867b7646e170b2685bb47ed938fb4562f55c0df/device/usb/usb_service_win.h
The patch has landed so this bug can be marked as fixed. Thank you nravi.n for your contribution!
Comment 1 by nrav...@samsung.com
, Jun 6 2017