New issue
Advanced search Search tips

Issue 728436 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Rotating device while bottom sheet is open produces empty content

Project Member Reported by mdjones@chromium.org, Jun 1 2017

Issue description

1. Enable Chrome Home.
2. Open bottom sheet.
3. Rotate device.
4. Observe blank content.
 
I'm not seeing this on 61.0.3116.0 on my Pixel running N MR2; this is possibly a very recent regression.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fec7a022a85f1530510f81359b29ed95e5de8dc

commit 9fec7a022a85f1530510f81359b29ed95e5de8dc
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Jun 09 20:59:15 2017

[Home] Fix padding logic for sheet content

Previously the padding logic for the bottom sheet content did not
account for the fact that window decor view dimensions update after
the layout change event is run for the bottom sheet. This caused
some confusion for the sheet that thought the keyboard started showing
and caused the padding to be a huge number, making the content
invisible. This change makes a clear distinction about when the
keyboard is showing by not using only the height.

BUG= 728436 

Change-Id: I4fdc2d32cf12f9cc5ac0f8083a74548f61ae1b5c
Reviewed-on: https://chromium-review.googlesource.com/529269
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478411}
[modify] https://crrev.com/9fec7a022a85f1530510f81359b29ed95e5de8dc/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java

Status: Fixed (was: Started)

Sign in to add a comment