URL bar back button is always in disabled state in case new tab was opened |
|||||||
Issue descriptionChrome Version: Canary 61.0.3116.0 OS: Android 7.1.2 Device: Pixel, Pixel XL What steps will reproduce the problem? 1. Open www.reddit.com in browser 2. Place device into headset, pass DON flow => page is displayed in VR browser 3. Use controller to click on any of the images presented on the page => New website should be opened in the new Tab. Back arrow in the URL bar is grayed out, button is disabled because back stack is empty 4. Click some links on the newly opened website in order to fill the Back stack for this Tab. What is the expected result? Back button should become active once back stack for new Tab is not empty. What happens instead? Back button looks disabled, however it handles clicks and transfers user to the previously opened pages.
,
Jun 7 2017
,
Jun 7 2017
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/529e5a534ca028c743dcbd3d284657c981a8b776 commit 529e5a534ca028c743dcbd3d284657c981a8b776 Author: mthiesse <mthiesse@chromium.org> Date: Thu Jun 08 16:02:50 2017 VR: Update back button state in more places. I looked at all of the spots clank updates back button enabled-ness, and added all of the ones that looked relevant to VrShell. BUG= 728435 Review-Url: https://codereview.chromium.org/2932493002 Cr-Commit-Position: refs/heads/master@{#477982} [modify] https://crrev.com/529e5a534ca028c743dcbd3d284657c981a8b776/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Jun 8 2017
,
Jun 8 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c499471cde8dbbf9386fa97d11a9cfd04f1ca826 commit c499471cde8dbbf9386fa97d11a9cfd04f1ca826 Author: Michael Thiessen <mthiesse@google.com> Date: Thu Jun 08 16:17:15 2017 VR: Update back button state in more places. I looked at all of the spots clank updates back button enabled-ness, and added all of the ones that looked relevant to VrShell. BUG= 728435 Review-Url: https://codereview.chromium.org/2932493002 Cr-Original-Commit-Position: refs/heads/master@{#477982} Review-Url: https://codereview.chromium.org/2929863003 . Cr-Commit-Position: refs/branch-heads/3112@{#254} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/c499471cde8dbbf9386fa97d11a9cfd04f1ca826/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Jun 8 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ddorwin@chromium.org
, Jun 6 2017Owner: mthiesse@chromium.org
Status: Assigned (was: Untriaged)