BidirectionalStreamQuicImpl::SendRequestHeaders may delete |this|. |
||
Issue descriptionIn the event of a synchronous write error, BidirectionalStreamQuicImpl::SendRequestHeaders may delete |this|. As a result and code which comes after SendRequestHeaders() is a potential crash bug. This method is called from both SendData() and SendvData() so those need to be fixed.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75548aac0ccababca0640928d2d5dc28afe00bed commit 75548aac0ccababca0640928d2d5dc28afe00bed Author: rch <rch@chromium.org> Date: Fri Jun 02 00:03:54 2017 Fix potential crash bug with BidirectionalStreamQuicImpl::SendRequestHeaders resulting in the connection being closed due to a synchronous write error. BUG= 728434 Review-Url: https://codereview.chromium.org/2915973002 Cr-Commit-Position: refs/heads/master@{#476491} [modify] https://crrev.com/75548aac0ccababca0640928d2d5dc28afe00bed/net/quic/chromium/bidirectional_stream_quic_impl.cc [modify] https://crrev.com/75548aac0ccababca0640928d2d5dc28afe00bed/net/quic/chromium/bidirectional_stream_quic_impl.h [modify] https://crrev.com/75548aac0ccababca0640928d2d5dc28afe00bed/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
,
Aug 24 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rch@chromium.org
, Jun 1 2017