New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728433 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

OfflinePageUtilsTest#testDeleteSharedOfflineFiles failing on two builders

Project Member Reported by jbudorick@chromium.org, Jun 1 2017

Issue description

includes:
 - Lollipop Phone Tester, starting with https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/12350
 - Android Tests (dbg), starting with https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/42944

Fails with

java.lang.AssertionError: Should be able to copy file to shareable location.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest.testDeleteSharedOfflineFiles(OfflinePageUtilsTest.java:309)
        ...

Spec reverting https://chromium-review.googlesource.com/c/513984/. Will reland if not responsible.
 
Labels: -Restrict-View-Google
 Issue 728520  has been merged into this issue.
Cc: -romax@chromium.org jbudorick@chromium.org
Labels: -Pri-1 Pri-2
Owner: romax@chromium.org
Failure appears to have been flaky, but the revert appears to have resolved the issue in the short term. Dropping priority & reassigning.
Status: Assigned (was: Started)

Comment 5 by romax@chromium.org, Jun 20 2017

Status: WontFix (was: Assigned)
This was because a race condition introduced in the patch https://chromium-review.googlesource.com/c/513984/, the patch has been reverted and will not be reland (since the approach changed and now the patch is https://chromium-review.googlesource.com/c/540995/. The new CL shouldn't make tests flaky.
Hence closing this issue as obsolete(won't fix).

Sign in to add a comment