New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 728421 link

Starred by 2 users
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
█ asimjour@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Storage request is suppressed but not declined in Chrome VR

Project Member Reported by vsupruniuk@google.com, May 31 2017 
Chrome Version: Canary 61.0.3116.0
OS: Android 7.1.2
Device: Pixel, Pixel XL

What steps will reproduce the problem?
1. Open https://permission.site/ in Chrome
2. Insert device into headset, pass DON flow
=> Page is displayed in Chrome VR
3. Click "Quota Management" button using controller
=> All dialogs/warnings/prompts should be suppressed
4. Exit from Chrome VR

What is the expected result?
Chrome returns to 2D mode, there shouldn't be any prompts/requests displayed

What happens instead?
Chrome displays an info bar that prompts the user to either accept or decline the storage request ("http://permission.site wants to permanently store data on your device")

Comment 1 by vsupruniuk@google.com, May 31 2017

Components: UI>Browser>VR

Comment 2 by ddorwin@chromium.org, Jun 6 2017

Labels: -Pri-3 M-60 Pri-2
Owner: asimjour@chromium.org
Status: Assigned (was: Untriaged)
Will the fix for issue 728274 fix this?

Comment 3 by ddorwin@chromium.org, Jun 9 2017 

Is this addressed by the fix for  issue 715613 ?

Comment 4 by asimjour@chromium.org, Jun 9 2017 

No, it is a separate issue.

Comment 5 by ddorwin@chromium.org, Jun 9 2017

Labels: -M-60 M-61

Comment 6 by vollick@chromium.org, Jul 7 2017 

Is this a matter of ignoring the request addition in PermissionRequestManager?

Comment 7 by vollick@chromium.org, Jul 7 2017

Cc: asimjour@chromium.org
Owner: vollick@chromium.org
Status: Started (was: Assigned)
Amir, I have a WIP fix up here: https://codereview.chromium.org/2975593002/ - hopefully we can chat about it this morning. I'm going to assign this bug to myself since I'm working on it, but if I'm on the wrong track or if you've already got a plan for this, please reassign.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9bbbdb6d4dc56628677896f599f470cb6d853ac

commit e9bbbdb6d4dc56628677896f599f470cb6d853ac
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Jul 12 15:48:44 2017

[vr] VrTabHelper should not be android-specific

This code previously lived in an android-specific directory, so it was
inappropriate to include it on other platforms. Now that we've moved
platform-agnostic code to chrome/browser/vr, the tab helper can also
be relocated, removing a number of unfortunate ifdefs.

Bug:  728421 
Change-Id: I2b3f5e6b7369a751ed1e947f7882b2a8dd75e38e
Reviewed-on: https://chromium-review.googlesource.com/567327
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485972}
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/BUILD.gn
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/ui/android/login_handler_android.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/ui/android/ssl_client_certificate_request.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/ui/android/usb_chooser_dialog_android.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/ui/tab_helpers.cc
[rename] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/vr/vr_tab_helper.cc
[rename] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/chrome/browser/vr/vr_tab_helper.h
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/content/public/common/web_preferences.cc
[modify] https://crrev.com/e9bbbdb6d4dc56628677896f599f470cb6d853ac/content/public/common/web_preferences.h
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 13 2017

Labels: Hotlist-Google
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4d2973dd1dcaeaee85e6e48b9e949519268d115

commit c4d2973dd1dcaeaee85e6e48b9e949519268d115
Author: Ian Vollick <vollick@chromium.org>
Date: Thu Jul 13 23:40:45 2017

[vr] Deny permission requests in VR mode

These currently imply monocularly rendered content which is quite
disruptive in VR. Until the UI for these requests is properly supported
in VR, we should deny them.

BUG:  728421 
Change-Id: Iaeaa2c3f90d3f59667b199ee2ed850bb0bf9db4e
Reviewed-on: https://chromium-review.googlesource.com/569398
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486540}
[modify] https://crrev.com/c4d2973dd1dcaeaee85e6e48b9e949519268d115/chrome/browser/chrome_quota_permission_context.cc
[modify] https://crrev.com/c4d2973dd1dcaeaee85e6e48b9e949519268d115/chrome/browser/download/download_request_limiter.cc
[modify] https://crrev.com/c4d2973dd1dcaeaee85e6e48b9e949519268d115/chrome/browser/download/download_request_limiter_unittest.cc
[modify] https://crrev.com/c4d2973dd1dcaeaee85e6e48b9e949519268d115/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/c4d2973dd1dcaeaee85e6e48b9e949519268d115/chrome/browser/ui/browser.cc

Comment 11 by vollick@chromium.org, Jul 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment