Failed stories should be displayed by their story name instead of their url |
||||
Issue descriptionBuildbot is displaying failed stories as the url instead of the story name. This should be changed to be the story name instead of the url For example: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf%2F122%2F%2B%2Frecipes%2Fsteps%2Fblink_perf.bindings.reference_on_Android%2F0%2Flogs%2Fjson.output%2F0 { "failures": [ "file:///b/swarming/w/ir/third_party/WebKit/PerformanceTests/Bindings/structured-clone-long-string-serialize.html", "file:///b/swarming/w/ir/third_party/WebKit/PerformanceTests/Bindings/sequence-conversion-custom-iterator.html" ], "successes": [], "valid": true } should be { "failures": [ "Bindings/structured-clone-long-string-serialize.html", "Bindings/sequence-conversion-custom-iterator.html" ], "successes": [], "valid": true } per comments here: https://codereview.chromium.org/2912253002/#msg5
,
May 31 2017
This seems to be happening in cases where the name is not explicitly set on the story so it will likely be fixed by https://bugs.chromium.org/p/chromium/issues/detail?id=720002 when the name is explicitly set in story creation, page_data.get('name') succeeds here: https://cs.chromium.org/chromium/src/testing/scripts/run_telemetry_benchmark_as_googletest.py?sq=package:chromium&q=run_telemetry_benchm&l=93 When the name is not set, it defaults to using the full url in the "failures" output in json output.
,
May 31 2017
json output formatter's code is in https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/internal/results/json_output_formatter.py
,
Jun 12 2017
Yep it was fixed by explicitly setting the test name Example: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf%2F170%2F%2B%2Frecipes%2Fsteps%2Fblink_perf.bindings_on_Android%2F0%2Flogs%2Fjson.output%2F0 { "failures": [ "structured-clone-long-string-serialize.html", "structured-clone-json-serialize.html", "structured-clone-long-string-deserialize.html", "structured-clone-json-deserialize.html" ], "successes": [], "valid": true } Marking as obsolete
,
Jan 16
,
Jan 16
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nedngu...@google.com
, May 31 2017Components: Speed>Telemetry