New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728416 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Failed stories should be displayed by their story name instead of their url

Project Member Reported by ashleymarie@chromium.org, May 31 2017

Issue description

Buildbot is displaying failed stories as the url instead of the story name. This should be changed to be the story name instead of the url

For example:
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf%2F122%2F%2B%2Frecipes%2Fsteps%2Fblink_perf.bindings.reference_on_Android%2F0%2Flogs%2Fjson.output%2F0
{
  "failures": [
    "file:///b/swarming/w/ir/third_party/WebKit/PerformanceTests/Bindings/structured-clone-long-string-serialize.html",
    "file:///b/swarming/w/ir/third_party/WebKit/PerformanceTests/Bindings/sequence-conversion-custom-iterator.html"
  ],
  "successes": [],
  "valid": true
}
should be
{
  "failures": [
    "Bindings/structured-clone-long-string-serialize.html",
    "Bindings/sequence-conversion-custom-iterator.html"
  ],
  "successes": [],
  "valid": true
}

per comments here: https://codereview.chromium.org/2912253002/#msg5
 
Cc: rnep...@chromium.org charliea@chromium.org
Components: Speed>Telemetry
This seems to be happening in cases where the name is not explicitly set on the story so it will likely be fixed by https://bugs.chromium.org/p/chromium/issues/detail?id=720002
when the name is explicitly set in story creation, page_data.get('name') succeeds here: https://cs.chromium.org/chromium/src/testing/scripts/run_telemetry_benchmark_as_googletest.py?sq=package:chromium&q=run_telemetry_benchm&l=93
When the name is not set, it defaults to using the full url in the "failures" output in json output.
Status: WontFix (was: Untriaged)
Yep it was fixed by explicitly setting the test name
Example: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf%2F170%2F%2B%2Frecipes%2Fsteps%2Fblink_perf.bindings_on_Android%2F0%2Flogs%2Fjson.output%2F0
{
  "failures": [
    "structured-clone-long-string-serialize.html",
    "structured-clone-json-serialize.html",
    "structured-clone-long-string-deserialize.html",
    "structured-clone-json-deserialize.html"
  ],
  "successes": [],
  "valid": true
}
Marking as obsolete
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment