New issue
Advanced search Search tips

Issue 728402 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Profile::IsNewProfile() sometimes returns false for the default profile

Project Member Reported by pmonette@chromium.org, May 31 2017

Issue description

Because IsNewProfile() is implemented by checking if the preferences file was created on the current Chrome execution, it misses the case where a master_preferences file exists, and is dumped into the default profile on creation.

When the profile loads for the first time, the file already exists and is thus not considered a new one, even though it should.

The easiest fix is to change IsNewProfile() to also check for first_run::IsChromeFirstRun(), because every profile on first run is new.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 3 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 2

Cc: droger@chromium.org ew...@chromium.org bsazonov@chromium.org jlebel@chromium.org tangltom@chromium.org sabineb@chromium.org msarda@chromium.org
--Chrome Identity automated triaging--

This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I imagine this is still valid, so pinging for Patrick to keep it alive. Feel free to re-assign to someone else if you're no longer the right owner, Patrick.
Status: Assigned (was: Available)
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment