Issue metadata
Sign in to add a comment
|
VR: Dynamically compute content window resolution and DPR from physical device parameters. |
||||||||||||||||||||||||||
Issue descriptionRight now we hard-code values that make sense for Pixel devices. However, other devices should use different values. For resolution, we probably want to define the width of a css pixel in some fraction of meters and use that to compute the right resolution? Not sure. For DPR we probably want to divide the physical pixels in the content quad by the css pixels in the content quad. TBD how to compute this. Then do we also want to change the content quad size based on screen size? Larger screens have more space for a larger content quad? Or do we make this field of view based, so it doesn't really depend on screen size? Also not sure.
,
Jul 7 2017
,
Jul 10 2017
I think we can synthesize a mvp matrix based on a neutral pose and use that matrix to project the content quad into screen space. Once we have that rectangle, since we know the number of physical pixels, we just need to scale them by the device-pixel-ratio which we can pull from android.
,
Jul 20 2017
Hey! is this still valid?
,
Jul 20 2017
Yep, I have a CL in the making. Will be M62 though. For M61 we zoom in a bit to make also small text legible in Pixel devices (see Issue 737118 ).
,
Aug 8 2017
,
Aug 9 2017
Issue 643449 has been merged into this issue.
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd659e97384a17f6ef98642cd2ec3dd877524605 commit dd659e97384a17f6ef98642cd2ec3dd877524605 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Wed Aug 16 22:14:11 2017 [vr] Dynamically determine content size and resolution Calculate the appropriate content size and resolution based on the device's physical screen size, screen pixel size and the content quad's projected size in screen space. By doing so, the content's resolution and text size is more suitable for individual devices. Bug: 728393 Change-Id: I1677ba07d99a3c26a8b894fa95ada791ef16103a Reviewed-on: https://chromium-review.googlesource.com/608877 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#494972} [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/android/vr_shell/gl_browser_interface.h [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/android/vr_shell/vr_gl_thread.cc [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/android/vr_shell/vr_gl_thread.h [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/animation_player.cc [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/animation_player.h [add] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/test/constants.h [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/test/mock_browser_interface.h [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/ui_browser_interface.h [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/ui_scene_manager_unittest.cc [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/vr_gl_util.cc [modify] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/vr_gl_util.h [add] https://crrev.com/dd659e97384a17f6ef98642cd2ec3dd877524605/chrome/browser/vr/vr_gl_util_unittest.cc
,
Aug 22 2017
,
Jul 4
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by ddorwin@chromium.org
, Jun 19 2017