New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728391 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl upload loses all but the first word of the upload message specified with -m

Project Member Reported by avayvod@chromium.org, May 31 2017

Issue description

Try to upload a change from some branch:
$ git cl upload -m "Rebase and fix tests"
...
Title for patchset [Rebase]:

The suggested title only contains the first word.

(furthermore, if I use a comma in the string, like "Rebase, fix tests", a warning is shown saying only alphanumerical and space characters are supported and I need to edit the description online -- the first word with a comma is suggested [Rebase,]).
 
Cc: aga...@chromium.org
Cc: -jparent@chromium.org -andyb...@chromium.org -aga...@chromium.org
Labels: Proj-Gerrit-Migration
Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)
Labels: Milestone-Launch
Cc: jparent@chromium.org aga...@chromium.org andyb...@chromium.org
 Issue 730265  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/7303dcb9b399b67cc533d32109b2e4f1da8147e2

commit 7303dcb9b399b67cc533d32109b2e4f1da8147e2
Author: Aaron Gable <agable@chromium.org>
Date: Thu Jun 08 17:43:42 2017

Use whole --message argument on patchset upload

The logic for handling --title, --message, and the
commit message of the most recent commit was accidentally
doing this differently from how Rietveld had done them.

Bug:  728391 
Change-Id: I70a46ccb470d790103f5d6bb745902595be28eee
Reviewed-on: https://chromium-review.googlesource.com/527339
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/7303dcb9b399b67cc533d32109b2e4f1da8147e2/git_cl.py

Status: Fixed (was: Assigned)

Sign in to add a comment