New issue
Advanced search Search tips

Issue 728359 link

Starred by 3 users
Status: Assigned
Owner:
vmp...@chromium.org
Cc:
enne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 771156


Sign in to add a comment

PaintShader plan

Project Member Reported by vmp...@chromium.org, May 31 2017 
Post https://codereview.chromium.org/2893083002

The things that we will still need to do are the following:

- Rework solid color analysis not to do raster.
- Rework image gathering to not construct sk shaders (use PaintShaders).
- Defer SkShader creation by storing parameters in PaintShader.
- Add PaintShader id.
- Memoize SkShaders at raster with a given cache.
- Cleanup and remove shader caching in blink, maybe
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda52d0cc0fea52b996fce1663a8de5141fe48c3

commit cda52d0cc0fea52b996fce1663a8de5141fe48c3
Author: vmpstr <vmpstr@chromium.org>
Date: Wed Jun 07 23:53:58 2017

cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2893083002
Cr-Commit-Position: refs/heads/master@{#477810}

[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/ash/touch_hud/touch_hud_renderer.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/BUILD.gn
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/discardable_image_store.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/paint_flags.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/paint_flags.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/paint_op_buffer_unittest.cc
[add] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/paint_shader.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/cc/paint/paint_shader.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/content/browser/web_contents/aura/shadow_layer_delegate.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/Gradient.cpp
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/Gradient.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/ImagePattern.cpp
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/ImagePattern.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/Pattern.cpp
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/Pattern.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/third_party/WebKit/Source/platform/graphics/paint/PaintShader.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/ui/gfx/render_text.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/ui/gfx/render_text.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/ui/gfx/skia_paint_util.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/ui/gfx/skia_paint_util.h
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/ui/native_theme/native_theme_base.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/ui/views/color_chooser/color_chooser_view.cc
[modify] https://crrev.com/cda52d0cc0fea52b996fce1663a8de5141fe48c3/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cae4d389092473a097baf547b1fecfe2259e748

commit 8cae4d389092473a097baf547b1fecfe2259e748
Author: sammc <sammc@chromium.org>
Date: Thu Jun 08 00:30:48 2017

Revert of cc: Move SkShader construction to a single spot in PaintShader (patchset #8 id:140001 of https://codereview.chromium.org/2893083002/ )

Reason for revert:
Broke Linux ChromiumOS Builder (dbg):
https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Builder%20%28dbg%29/88131

Original issue's description:
> cc: Move SkShader construction to a single spot in PaintShader
>
> This patch moves SkShader construction to be only in PaintShader
> (for the purposes of paint, at least). This ensures that we can
> transport all of the relevant parameters required for the shader
> and defer construction until raster.
>
> BUG=728359
> R=enne@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2893083002
> Cr-Commit-Position: refs/heads/master@{#477810}
> Committed: https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8de5141fe48c3

TBR=enne@chromium.org,pdr@chromium.org,sky@chromium.org,piman@chromium.org,junov@chromium.org,senorblanco@chromium.org,vmpstr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=728359

Review-Url: https://codereview.chromium.org/2928703005
Cr-Commit-Position: refs/heads/master@{#477827}

[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/ash/touch_hud/touch_hud_renderer.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/cc/paint/BUILD.gn
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/cc/paint/discardable_image_store.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/cc/paint/paint_flags.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/cc/paint/paint_flags.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/cc/paint/paint_op_buffer_unittest.cc
[delete] https://crrev.com/c0f846bdbfa4e685f05c48443923db9dfceaa35d/cc/paint/paint_shader.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/cc/paint/paint_shader.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/content/browser/web_contents/aura/shadow_layer_delegate.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/Gradient.cpp
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/Gradient.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/ImagePattern.cpp
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/ImagePattern.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/Pattern.cpp
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/Pattern.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/third_party/WebKit/Source/platform/graphics/paint/PaintShader.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/ui/gfx/render_text.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/ui/gfx/render_text.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/ui/gfx/skia_paint_util.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/ui/gfx/skia_paint_util.h
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/ui/native_theme/native_theme_base.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/ui/views/color_chooser/color_chooser_view.cc
[modify] https://crrev.com/8cae4d389092473a097baf547b1fecfe2259e748/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b99c95846da32cdb1060f59a1a1f5bd27ab2696

commit 7b99c95846da32cdb1060f59a1a1f5bd27ab2696
Author: vmpstr <vmpstr@chromium.org>
Date: Thu Jun 08 21:39:56 2017

cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2893083002
Cr-Original-Commit-Position: refs/heads/master@{#477810}
Committed: https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8de5141fe48c3
Review-Url: https://codereview.chromium.org/2893083002
Cr-Commit-Position: refs/heads/master@{#478095}

[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ash/touch_hud/BUILD.gn
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ash/touch_hud/touch_hud_renderer.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/BUILD.gn
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/discardable_image_store.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/paint_flags.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/paint_flags.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/paint_op_buffer_unittest.cc
[add] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/paint_shader.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/cc/paint/paint_shader.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/content/browser/web_contents/aura/shadow_layer_delegate.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/Gradient.cpp
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/Gradient.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/ImagePattern.cpp
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/ImagePattern.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/Pattern.cpp
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/Pattern.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/third_party/WebKit/Source/platform/graphics/paint/PaintShader.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ui/gfx/render_text.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ui/gfx/render_text.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ui/gfx/skia_paint_util.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ui/gfx/skia_paint_util.h
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ui/native_theme/native_theme_base.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ui/views/color_chooser/color_chooser_view.cc
[modify] https://crrev.com/7b99c95846da32cdb1060f59a1a1f5bd27ab2696/ui/views/controls/scrollbar/cocoa_scroll_bar.mm

Comment 4 by khushals...@chromium.org, Jun 22 2017

Blocking: 735662
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ca1c84c9ba5693d1cdb11e76d874193b59e11cb

commit 4ca1c84c9ba5693d1cdb11e76d874193b59e11cb
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Mon Jul 10 22:09:31 2017

Remove PaintShader::GetSkShader() uses outside of PaintFlags.

This patch reworks PaintShader to store needed parameters, instead
of constructing an SkShader immediately. This allows the PaintShader
to be introspectible (for things like images), without relying on
SkShader::asAImage().

This patch also removes the sk_shader uses from outside of the flags in
order to restrict access and construction of the SkShader. 

This would also unblock the gif animations on the compositor for the
same reason (ie, it will be able to get a PaintImage directly from
PaintShader).

R=enne@chromium.org, chrishtr@chromium.org, khushalsagar@chromium.org
Bug:728359

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I480195299205e8a7c01298095d5662b63980f80b
Reviewed-on: https://chromium-review.googlesource.com/544119
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485416}
[modify] https://crrev.com/4ca1c84c9ba5693d1cdb11e76d874193b59e11cb/cc/paint/paint_flags.h
[modify] https://crrev.com/4ca1c84c9ba5693d1cdb11e76d874193b59e11cb/cc/paint/paint_shader.cc
[modify] https://crrev.com/4ca1c84c9ba5693d1cdb11e76d874193b59e11cb/cc/paint/paint_shader.h
[modify] https://crrev.com/4ca1c84c9ba5693d1cdb11e76d874193b59e11cb/third_party/WebKit/Source/platform/graphics/Gradient.cpp
[modify] https://crrev.com/4ca1c84c9ba5693d1cdb11e76d874193b59e11cb/third_party/WebKit/Source/platform/graphics/Pattern.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/576bda00f9ee4d41f309069b88513b34049f58ee

commit 576bda00f9ee4d41f309069b88513b34049f58ee
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Sep 28 01:44:10 2017

cc: Decode discardable images in PaintRecord backed shaders.

For PaintRecord backed shaders, the rasterization is done internally in
skia, which means images present in these shaders are not pre-decoded
by compositor's decode cache. This change ensures that we capture these
images during discardable image analysis, and replace them with decoded
images from the compositor's cache.

Replacing of these images requires transforming the PaintRecords in
these shaders to SkPictures with decoded images before executing the op
with the shader.

Bug:  735741 , 728359
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie9314e566eaeb1a393c7490e6309d1315ec3733e
Reviewed-on: https://chromium-review.googlesource.com/673826
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504860}
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/BUILD.gn
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/BUILD.gn
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/paint_shader.cc
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/paint_shader.h
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/paint_shader_unittest.cc
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/scoped_image_flags.cc
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/scoped_image_flags.h
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/cc/paint/scoped_image_flags_unittest.cc
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/masking/mask-repeat-space-padding-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/backgrounds/background-repeat-with-background-color-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.10/http/tests/misc/slow-loading-image-in-pattern-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/masking/mask-repeat-space-padding-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/backgrounds/background-repeat-with-background-color-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.11/http/tests/misc/slow-loading-image-in-pattern-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.11/images/color-profile-background-image-space-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.11/images/color-profile-svg-fill-text-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/images/cross-fade-background-size-expected.png
[add] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/576bda00f9ee4d41f309069b88513b34049f58ee/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[delete] https://crrev.com/a964e6f586c0da83551ee3044b8f4a17993b477b/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c499c0a65465e50837c54af42c8f5b89d1df8d3

commit 6c499c0a65465e50837c54af42c8f5b89d1df8d3
Author: Taiju Tsuiki <tzik@chromium.org>
Date: Thu Sep 28 03:56:19 2017

Revert "cc: Decode discardable images in PaintRecord backed shaders."

This reverts commit 576bda00f9ee4d41f309069b88513b34049f58ee.

Reason for revert:
Seems to cause LayoutTest failure on CI.

Failing tests are:
* css3/masking/mask-repeat-space-padding.html
* fast/backgrounds/background-repeat-with-background-color.html
* http/tests/misc/slow-loading-image-in-pattern.html
* images/color-profile-background-image-space.html
* images/color-profile-svg-fill-text.html
* virtual/exotic-color-space/images/color-profile-svg-fill-text.html
* virtual/exotic-color-space/images/cross-fade-background-size.html
* virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern.html

The error log is available here:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/23965

Original change's description:
> cc: Decode discardable images in PaintRecord backed shaders.
> 
> For PaintRecord backed shaders, the rasterization is done internally in
> skia, which means images present in these shaders are not pre-decoded
> by compositor's decode cache. This change ensures that we capture these
> images during discardable image analysis, and replace them with decoded
> images from the compositor's cache.
> 
> Replacing of these images requires transforming the PaintRecords in
> these shaders to SkPictures with decoded images before executing the op
> with the shader.
> 
> Bug:  735741 , 728359
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ie9314e566eaeb1a393c7490e6309d1315ec3733e
> Reviewed-on: https://chromium-review.googlesource.com/673826
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504860}

TBR=vmpstr@chromium.org,chrishtr@chromium.org,enne@chromium.org,khushalsagar@chromium.org

Change-Id: I308e40a4f88c45b25d68ed2a6663d4f83e8b71ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  735741 , 728359
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/688520
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504891}
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/cc/BUILD.gn
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/cc/paint/BUILD.gn
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/cc/paint/paint_shader.cc
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/cc/paint/paint_shader.h
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/cc/paint/paint_shader_unittest.cc
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/cc/paint/scoped_image_flags.cc
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/cc/paint/scoped_image_flags.h
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/cc/paint/scoped_image_flags_unittest.cc
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/linux/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css3/masking/mask-repeat-space-padding-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/backgrounds/background-repeat-with-background-color-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/http/tests/misc/slow-loading-image-in-pattern-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/css3/masking/mask-repeat-space-padding-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/backgrounds/background-repeat-with-background-color-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/http/tests/misc/slow-loading-image-in-pattern-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/images/color-profile-background-image-space-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/images/color-profile-svg-fill-text-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/3f5043ca9426a66da17606954a6e4b7f94a9802e/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[add] https://crrev.com/6c499c0a65465e50837c54af42c8f5b89d1df8d3/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa

commit 8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa
Author: Khushal <khushalsagar@chromium.org>
Date: Mon Oct 02 05:16:34 2017

Reland cc: Decode discardable images in PaintRecord backed shaders.

This relands commit 576bda00f9ee4d41f309069b88513b34049f58ee.

For PaintRecord backed shaders, the rasterization is done internally in
skia, which means images present in these shaders are not pre-decoded
by compositor's decode cache. This change ensures that we capture these
images during discardable image analysis, and replace them with decoded
images from the compositor's cache.

Replacing of these images requires transforming the PaintRecords in
these shaders to SkPictures with decoded images before executing the op
with the shader.

TBR=chrishtr@chromium.org, enne@chromium.org

Bug:  735741 , 728359
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3b851a2824b89affb017284436e260ebd57649fc
Reviewed-on: https://chromium-review.googlesource.com/690734
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505538}
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/BUILD.gn
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/BUILD.gn
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/paint_shader.cc
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/paint_shader.h
[add] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/paint_shader_unittest.cc
[add] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/scoped_image_flags.cc
[add] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/scoped_image_flags.h
[add] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/cc/paint/scoped_image_flags_unittest.cc
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/images/cross-fade-background-size-expected.png
[add] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[delete] https://crrev.com/92ca5ce9f588715f04b70c1bb7094b271ff91b5a/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb

commit fe24d7f3ac1b5bcfb840a5ada01627df90a099eb
Author: Mike West <mkwst@chromium.org>
Date: Mon Oct 02 09:09:36 2017

Revert "Reland cc: Decode discardable images in PaintRecord backed shaders."

This reverts commit 8fafe68a2435c9992cda9906f7fc8bd7ec7d6daa.

Reason for revert:
- `cc_unittests` MSan failure, starting in https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/4662. 

Original change's description:
> Reland cc: Decode discardable images in PaintRecord backed shaders.
> 
> This relands commit 576bda00f9ee4d41f309069b88513b34049f58ee.
> 
> For PaintRecord backed shaders, the rasterization is done internally in
> skia, which means images present in these shaders are not pre-decoded
> by compositor's decode cache. This change ensures that we capture these
> images during discardable image analysis, and replace them with decoded
> images from the compositor's cache.
> 
> Replacing of these images requires transforming the PaintRecords in
> these shaders to SkPictures with decoded images before executing the op
> with the shader.
> 
> TBR=chrishtr@chromium.org, enne@chromium.org
> 
> Bug:  735741 , 728359
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I3b851a2824b89affb017284436e260ebd57649fc
> Reviewed-on: https://chromium-review.googlesource.com/690734
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505538}

TBR=chrishtr@chromium.org,enne@chromium.org,khushalsagar@chromium.org

Change-Id: I8a7fc965f9d15334c61102c5970057af94aa40fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  735741 , 728359,  770631 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/692938
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505562}
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/BUILD.gn
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/BUILD.gn
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/paint_shader.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/cc/paint/paint_shader.h
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/cc/paint/paint_shader_unittest.cc
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/cc/paint/scoped_image_flags.cc
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/cc/paint/scoped_image_flags.h
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/cc/paint/scoped_image_flags_unittest.cc
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[add] https://crrev.com/fe24d7f3ac1b5bcfb840a5ada01627df90a099eb/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53b8ed642644f245e3cb8d5cf2541bf3778ae7de

commit 53b8ed642644f245e3cb8d5cf2541bf3778ae7de
Author: Khushal <khushalsagar@chromium.org>
Date: Tue Oct 03 00:36:30 2017

Reland cc: Decode discardable images in PaintRecord backed shaders.

This reverts commit fe24d7f3ac1b5bcfb840a5ada01627df90a099eb. Since we
rasterize the SkPicture with decoded images in the test, we need to
initialize its pixels. Fix that.

R=enne@chromium.org
TBR=chrishtr@chromium.org

Bug:  735741 ,728359
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I10989e2bc28594c9fa8e291559ae2753e65de29d
Reviewed-on: https://chromium-review.googlesource.com/695449
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505885}
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/BUILD.gn
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/BUILD.gn
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/paint_shader.cc
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/paint_shader.h
[add] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/paint_shader_unittest.cc
[add] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/scoped_image_flags.cc
[add] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/scoped_image_flags.h
[add] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/cc/paint/scoped_image_flags_unittest.cc
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/images/cross-fade-background-size-expected.png
[add] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/53b8ed642644f245e3cb8d5cf2541bf3778ae7de/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[delete] https://crrev.com/4fc238b5768ec2e605237f5e65e9d0e766f52243/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png

Comment 11 by khushals...@chromium.org, Oct 4 2017

Blockedon: 771156
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f77a3ffbb03b2037f2b752ca638a101187f106f0

commit f77a3ffbb03b2037f2b752ca638a101187f106f0
Author: Khushal <khushalsagar@chromium.org>
Date: Wed Oct 04 02:52:03 2017

Revert "Reland cc: Decode discardable images in PaintRecord backed shaders."

This reverts commit 53b8ed642644f245e3cb8d5cf2541bf3778ae7de.

Reason for revert: Causing flakiness on Linux Release (NVIDIA) for webgl_conformance_tests. See  crbug.com/771156 .

Original change's description:
> Reland cc: Decode discardable images in PaintRecord backed shaders.
> 
> This reverts commit fe24d7f3ac1b5bcfb840a5ada01627df90a099eb. Since we
> rasterize the SkPicture with decoded images in the test, we need to
> initialize its pixels. Fix that.
> 
> R=​enne@chromium.org
> TBR=chrishtr@chromium.org
> 
> Bug:  735741 ,728359
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I10989e2bc28594c9fa8e291559ae2753e65de29d
> Reviewed-on: https://chromium-review.googlesource.com/695449
> Reviewed-by: enne <enne@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505885}

TBR=chrishtr@chromium.org,enne@chromium.org,khushalsagar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  735741 , 728359
Change-Id: I9bc577e4f6488ef3bccb991609828db20467231f
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/699755
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506285}
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/cc/BUILD.gn
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/cc/paint/BUILD.gn
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/cc/paint/paint_shader.cc
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/cc/paint/paint_shader.h
[delete] https://crrev.com/dee1a06ada73466f9eb14544b2f4d5180eb2d42f/cc/paint/paint_shader_unittest.cc
[delete] https://crrev.com/dee1a06ada73466f9eb14544b2f4d5180eb2d42f/cc/paint/scoped_image_flags.cc
[delete] https://crrev.com/dee1a06ada73466f9eb14544b2f4d5180eb2d42f/cc/paint/scoped_image_flags.h
[delete] https://crrev.com/dee1a06ada73466f9eb14544b2f4d5180eb2d42f/cc/paint/scoped_image_flags_unittest.cc
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/linux/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac-mac10.10/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac-mac10.9/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/images/cross-fade-background-size-expected.png
[delete] https://crrev.com/dee1a06ada73466f9eb14544b2f4d5180eb2d42f/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/css3/masking/mask-repeat-space-padding-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/fast/backgrounds/background-repeat-with-background-color-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/http/tests/misc/slow-loading-image-in-pattern-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/misc/slow-loading-image-in-pattern-expected.png
[add] https://crrev.com/f77a3ffbb03b2037f2b752ca638a101187f106f0/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/color-profile-background-image-space-expected.png

Comment 13 by khushals...@chromium.org, Oct 31 2017

Blocking: -735662
Not blocking animated images in cc anymore. The changes above are enough to ensure we discover and replace images in shaders in cc.

Comment 14 by loonyb...@chromium.org, May 25 2018 

http/tests/media/reload-after-dialog.html still seems flaky. Not sure if this is still the root cause.
►

Sign in to add a comment