New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728358 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Depot tools are broken if you try to build Chrome M57/M58

Reported by artyo...@gmail.com, May 31 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce the problem:
Try to sync to the latest M57 (154) or M58 (145) and run gclient sync. It will fail.

Depot tools were synced automatically up to commit 0c62da9864214b37564aad6a5b6ae418e809bb37.

What is the expected behavior?
Shouldn't fail

What went wrong?
It fails with the following error:

_____ src/third_party/skia at 4c81ba6ba3a3270db809bf7d4c3bc782694a56a4                                                                                                 
----------------------------------------                                                                                                                               
Traceback (most recent call last):                                                                                                                                     
  File "/home/artyom/depot_tools/gclient.py", line 2295, in <module>                                                                                                   
    sys.exit(main(sys.argv[1:]))                                                                                                                                       
  File "/home/artyom/depot_tools/gclient.py", line 2281, in main                                                                                                       
    return dispatcher.execute(OptionParser(), argv)                                                                                                                    
  File "/home/artyom/depot_tools/subcommand.py", line 252, in execute                                                                                                  
    return command(parser, args[1:])                                                                                                                                   
  File "/home/artyom/depot_tools/gclient.py", line 2030, in CMDsync                                                                                                    
    ret = client.RunOnDeps('update', args)                                                                                                                             
  File "/home/artyom/depot_tools/gclient.py", line 1340, in RunOnDeps                                                                                                  
    work_queue.flush(revision_overrides, command, args, options=self._options)                                                                                         
  File "/home/artyom/depot_tools/gclient_utils.py", line 1047, in run                                                                                                  
    self.item.run(*self.args, **self.kwargs)                                                                                                                           
  File "/home/artyom/depot_tools/gclient.py", line 766, in run                                                                                                         
    self.ParseDepsFile()                                                                                                                                               
  File "/home/artyom/depot_tools/gclient.py", line 562, in ParseDepsFile                                                                                               
    gclient_eval.Check(deps_content, filepath, global_scope, local_scope)                                                                                              
  File "/home/artyom/depot_tools/gclient_eval.py", line 240, in Check                                                                                                  
    result_scope = _gclient_exec(content, global_scope, filename=path)                                                                                                 
  File "/home/artyom/depot_tools/gclient_eval.py", line 185, in _gclient_exec                                                                                          
    _visit_in_module(stmt)                                                                                                                                             
  File "/home/artyom/depot_tools/gclient_eval.py", line 181, in _visit_in_module                                                                                       
    getattr(node, 'lineno', '<unknown>')))                                                                                                                             
ValueError: unexpected AST node: <_ast.Import object at 0x7f9035b8ee90> Import(names=[alias(name='os', asname=None)]) (file '/home/artyom/chr_exp/src/third_party/skia/DEPS', line 53)

Did this work before? N/A 

Chrome version: 58.0.3029.110  Channel: dev
OS Version: Ubuntu 14.04
Flash Version: 

I can workaround the issue by rolling depot tools back ~200 commits (a random number). If I sync to the following commit:
"HEAD is now at d67e715 Fix GetOldContents() to return an empty string if the file didn't exist.         "
and disable depot tools auto-update then I can build both M57 and M58. Note, I haven't tried to build the latest master.
 

Comment 1 by artyo...@gmail.com, May 31 2017

Oh, I didn't mention that I am building Android target on Linux Ubuntu 14.04
Cc: phajdan@google.com
Status: WontFix (was: Unconfirmed)
Per https://groups.google.com/a/chromium.org/d/msg/infra-announce/GcuGYoPyASY/qrLCbUPCBQAJ , please pass --disable-syntax-validation to gclient.

Comment 3 by artyo...@gmail.com, Jun 1 2017

Thanks!

Sign in to add a comment