New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728357 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Completion stage failing for local test builds.

Project Member Reported by dgarr...@chromium.org, May 31 2017

Issue description

When I do a local build of cbuildbot for test purposes, I often get this error:

************************************************************
** FAIL Uprev (0:03:14) in /usr/local/google/home/dgarrett/sand/cbuild/chromite/bin/cros_mark_as_stable
************************************************************
** FAIL PreCQCompletion (0:00:01) with AttributeError
************************************************************

Failed in stage Uprev:

/usr/local/google/home/dgarrett/sand/cbuild/chromite/bin/cros_mark_as_stable failed (code=1)

Failed in stage PreCQCompletion:

Traceback (most recent call last):
  File "/usr/local/google/home/dgarrett/sand/cbuild/chromite/cbuildbot/stages/generic_stages.py", line 629, in Run
    self.PerformStage()
  File "/usr/local/google/home/dgarrett/sand/cbuild/chromite/cbuildbot/stages/completion_stages.py", line 1001, in PerformStage
    message = self.GetBuildFailureMessage()
  File "/usr/local/google/home/dgarrett/sand/cbuild/chromite/cbuildbot/stages/completion_stages.py", line 985, in GetBuildFailureMessage
    stage_failures = db.GetBuildsFailures([build_id])
AttributeError: 'NoneType' object has no attribute 'GetBuildsFailures'

 
I suspect it's connected with this CL:

https://chromium-review.googlesource.com/508912

Comment 2 by nxia@chromium.org, Jun 8 2017

Status: Assigned (was: Untriaged)

Comment 3 by nxia@chromium.org, Jun 8 2017

this bug needs to be addressed. but a local successful build shouldn't hit into this ?
I thought it was successful, but that might be because didn't keep looking in the log after I saw this.

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bdc9ee95a12f583f50f33c98e931866f9ce680e8

commit bdc9ee95a12f583f50f33c98e931866f9ce680e8
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Jun 23 00:03:56 2017

Convert stage exception to stage failure message and record it.

Local Cbuilbot runs don't have CIDB instance created, so for all the
exceptions threw by the failed stages, convert them to stage failure
messages and record them in results_lib.Result, which can be extracted
locally to create BuildFailureMessage.

BUG= chromium:694730 , chromium:728357 
TEST=unit_tests

Change-Id: I5ff885981d7ea5d62c1ee823fbbe93c71eef612b
Reviewed-on: https://chromium-review.googlesource.com/541925
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/failures_lib_unittest.py
[modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/cbuildbot/stages/completion_stages.py
[modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/build_failure_message.py
[modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/results_lib.py
[modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/failure_message_lib.py
[modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/failures_lib.py

Comment 6 by nxia@chromium.org, Jun 23 2017

Labels: Hotlist-Fixit
Status: Fixed (was: Assigned)

Sign in to add a comment