New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728353 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

Remove old options code (pre-Material Design settings UI)

Project Member Reported by dbeam@chromium.org, May 31 2017

Issue description

let's remove the code that services chrome://settings-frame.  it's disabled-by-default as of Chrome 59 (replaced by the Material Design version).
 
Screen Shot 2017-05-31 at 2.27.03 PM.png
148 KB View Download

Comment 1 by dbeam@chromium.org, Jun 6 2017

Cc: thakis@chromium.org
fyi: this will result in 2 less "set noparent" OWNERS files! (when I delete them)

\o/
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a5fa50529b3c83abb5db46772caa79ba210f43

commit e1a5fa50529b3c83abb5db46772caa79ba210f43
Author: dbeam <dbeam@chromium.org>
Date: Wed Jun 07 02:27:37 2017

Start removing deprecated Options UI code

This CL removes features::kMaterialDesignSettings.

R=dpapad@chromium.org,thestig@chromium.org
BUG= 728353 

Review-Url: https://codereview.chromium.org/2913343002
Cr-Commit-Position: refs/heads/master@{#477519}

[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/about_flags.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/browser_about_handler_unittest.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/chrome_content_browser_client_browsertest.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.h
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_browsertest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/clear_browser_data_browsertest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/content_settings_exception_area_browsertest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/language_dictionary_interactive_uitest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/language_options_interactive_uitest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/options_ui_browsertest.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/options/options_ui_browsertest.h
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/browser/ui/webui/uber/uber_ui.cc
[delete] https://crrev.com/57130e07aa7e05d90d2f851e9865537bd196f5a7/chrome/browser/ui/webui/uber/uber_ui_browsertest.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/common/chrome_features.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/common/chrome_features.h
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/common/url_constants.cc
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/common/url_constants.h
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/test/BUILD.gn
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/e1a5fa50529b3c83abb5db46772caa79ba210f43/chrome/test/data/webui/settings/help_page_browsertest.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/431a97fe65ed2ad03797afc84fb0182fd3a5643c

commit 431a97fe65ed2ad03797afc84fb0182fd3a5643c
Author: dbeam <dbeam@chromium.org>
Date: Wed Jun 07 06:10:59 2017

Remove tests for deprecated Options UI

R=dpapad@chromium.org
BUG= 728353 , 315250 , 434502 , 559265 , 559320 , 559330 , 560910 , 570046 , 570555 ,  570556 , 570560 , 570562 , 570563 , 570566 , 570567 , 570568 , 570723 , 603499 , 605090 ,  608126 , 616791 , 660867 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2919343005
Cr-Commit-Position: refs/heads/master@{#477561}

[modify] https://crrev.com/431a97fe65ed2ad03797afc84fb0182fd3a5643c/chrome/BUILD.gn
[modify] https://crrev.com/431a97fe65ed2ad03797afc84fb0182fd3a5643c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/431a97fe65ed2ad03797afc84fb0182fd3a5643c/chrome/browser/resources/BUILD.gn
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/resources/options_test_resources.grd
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/autofill_options_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/autofill_options_handler_unittest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/browser_options_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/certificate_manager_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/chromeos/bluetooth_options_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/chromeos/date_time_options_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/chromeos/power_overlay_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/content_options_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/content_settings_exception_area_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/cookies_view_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/font_settings_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/font_settings_utils_unittest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/language_options_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/language_options_handler_unittest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/manage_profile_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/multilanguage_options_browsertest.h
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/options_browsertest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/options_browsertest.h
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/options_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/options_browsertest_base.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/password_manager_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/password_manager_handler_unittest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/pepper_flash_content_settings_utils_unittest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/preferences_browsertest.cc
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/preferences_browsertest.h
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/profile_settings_reset_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/search_engine_manager_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/settings_format_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/startup_page_list_browsertest.js
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/431a97fe65ed2ad03797afc84fb0182fd3a5643c/chrome/test/BUILD.gn
[modify] https://crrev.com/431a97fe65ed2ad03797afc84fb0182fd3a5643c/chrome/test/data/webui/BUILD.gn
[delete] https://crrev.com/42137002fceb08c470f330b1b6a93bea7a0cd0f7/chrome/test/data/webui/inline_editable_list_test.html
[modify] https://crrev.com/431a97fe65ed2ad03797afc84fb0182fd3a5643c/chrome/test/data/webui/webui_resource_browsertest.cc
[modify] https://crrev.com/431a97fe65ed2ad03797afc84fb0182fd3a5643c/tools/gritsettings/resource_ids

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc499463c31aaa00a4180d11ec348a12650065b

commit fbc499463c31aaa00a4180d11ec348a12650065b
Author: dbeam <dbeam@chromium.org>
Date: Sat Jun 10 00:01:02 2017

Move code for old, deprecated Options UI to only ChromeOS

ChromeOS has a few UIs that still use /options/ code.
The goal is to eventually remove the code completely.

R=thestig@chromium.org
BUG= 728353 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2927273002
Cr-Commit-Position: refs/heads/master@{#478470}

[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/BUILD.gn
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/extensions/api/font_settings/font_settings_api.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/policy/policy_prefs_browsertest.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/resources/BUILD.gn
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/signin/signin_promo.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/webui/options/font_settings_handler.cc
[delete] https://crrev.com/2410fc6b7d05f26bca8b649aded31e959060ea3b/chrome/browser/ui/webui/options/font_settings_utils.cc
[delete] https://crrev.com/2410fc6b7d05f26bca8b649aded31e959060ea3b/chrome/browser/ui/webui/options/font_settings_utils.h
[delete] https://crrev.com/2410fc6b7d05f26bca8b649aded31e959060ea3b/chrome/browser/ui/webui/options/font_settings_utils_linux.cc
[delete] https://crrev.com/2410fc6b7d05f26bca8b649aded31e959060ea3b/chrome/browser/ui/webui/options/font_settings_utils_mac.mm
[delete] https://crrev.com/2410fc6b7d05f26bca8b649aded31e959060ea3b/chrome/browser/ui/webui/options/font_settings_utils_win.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/webui/settings/font_handler.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/webui/settings_utils.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/webui/settings_utils.h
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/webui/settings_utils_mac.mm
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/webui/settings_utils_win.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/browser/ui/webui/uber/uber_ui.cc
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/chrome_paks.gni
[modify] https://crrev.com/fbc499463c31aaa00a4180d11ec348a12650065b/chrome/common/url_constants.h

Comment 5 by dbeam@chromium.org, Jun 10 2017

Blockedon: 731219
Cc: steve...@chromium.org dbeam@chromium.org michae...@chromium.org xiy...@chromium.org
Owner: ----
aight, sooo

  chrome/browser/ui/webui/options
  chrome/browser/resources/options

are no longer used on Win, Linux, and Mac.

because there are a few UIs built on top of chrome://settings-frame/* URLs on ChromeOS, it's very very hard to detangle which of the options resources or C++ handlers to remove.  they have very hard-to-track encapsulation.  .js files reference other .js files implicitly or are explicitly loaded by <script> or <include>.  the .js files also use $('id-name-in-html') like candy, which requires .html templates to exist.  any chrome.send() may correspond to a C++ handler, which may also have other #include dependencies.  additionally, chrome.<extension>Private requires a host-based whitelisting of a private extension API.

tl;dr - It'll be hard to remove /options/ from src/ completely while those ChromeOS-only UIs exist.

Comment 6 by thakis@chromium.org, Jun 12 2017

So what's the plan forward here? Move the remaining options code somewhere into the CrOS code? Keep it around indefinitely?
The long term plan is to eliminate all of the options dependencies from Chrome OS also. We are in the process of triaging that effort. I am gardening this week but hope to spend some time next week prioritizing so that we can weed out the larger chunks of code.

Comment 8 by thakis@chromium.org, Jun 12 2017

Do you have a rough ETA for that? Days / weeks / months?
Cc: abodenha@chromium.org
I hope to at least triage the effort next week.

dbeam@ or michaelpg@ was going to come up with at least a partial list of the known dependencies.

I plan to look through the dependencies myself and at least triage them next week. At that point we should have a better idea of the effort involved.

Un-owned bugs have a habit of falling through the cracks (started state actually makes it worse since we usually don't search for that pattern)

Who should own this?
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89a0f29866b240fb8e058c00af8bc09c4927639e

commit 89a0f29866b240fb8e058c00af8bc09c4927639e
Author: dbeam <dbeam@chromium.org>
Date: Tue Jun 13 21:56:53 2017

Unframe chrome://extensions as it's the last (and only) uber item

This means that rather than having a frame structure like this:

  chrome://chrome (window)
    <iframe src="chrome://uber-frame">
    <iframe src="chrome://extensions-frame">

We can just have:

  chrome://extensions (window)

This allows us to remove a bunch of code dealing with this complexity.
Specifically, the C++ guts that does internal routing of messages.
Additionally, some of the chrome://help code is no longer used (that
page now permanently redirects to chrome://settings/help), so I was able
to remove that as well.

However, ChromeOS still uses /options/, and that code pulls in various
resources from help/ and uber/.  I've simplified the most I could as of
the current dependency situation.  The things that were still used by
ChromeOS I simply limited to that platform (most of the resources).

It's possible it may make sense to keep things like uber_shared.css as
it's also used by chrome://policy, but I'm not optimistic until new
designs of many things launch (I haven't heard updates on the Material
Design version of the policy page for a while now).

R=rdevlin.cronin@chromium.org
BUG= 728353 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2931243002
Cr-Commit-Position: refs/heads/master@{#479167}

[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/browser_resources.grd
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/extensions/extension_webui_apitest.cc
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/extensions/lazy_background_page_apitest.cc
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/chromeos/bluetooth_pair_device.html
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/chromeos/certificate_manager_dialog.html
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/extensions/compiled_resources2.gyp
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/extensions/extension_list.js
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/extensions/extensions.html
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/extensions/extensions.js
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/local_discovery/local_discovery.html
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/policy.css
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/policy.html
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/policy.js
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/resources/policy_android.css
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/ui/webui/extensions/extensions_ui.cc
[delete] https://crrev.com/17264e4231438095a0d19cbe54b89783b9f6d5ca/chrome/browser/ui/webui/help/help_browsertest.js
[delete] https://crrev.com/17264e4231438095a0d19cbe54b89783b9f6d5ca/chrome/browser/ui/webui/help/help_ui.cc
[delete] https://crrev.com/17264e4231438095a0d19cbe54b89783b9f6d5ca/chrome/browser/ui/webui/help/help_ui.h
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/browser/ui/webui/policy_ui.cc
[delete] https://crrev.com/17264e4231438095a0d19cbe54b89783b9f6d5ca/chrome/browser/ui/webui/uber/uber_ui.cc
[delete] https://crrev.com/17264e4231438095a0d19cbe54b89783b9f6d5ca/chrome/browser/ui/webui/uber/uber_ui.h
[modify] https://crrev.com/89a0f29866b240fb8e058c00af8bc09c4927639e/chrome/test/data/webui/BUILD.gn

Cc: dschuyler@chromium.org
Re #10: making stevenjb@ owner for at least the triage step.

Also ping for an update :)

Owner: steve...@chromium.org
Status: Assigned (was: Started)

Comment 15 Deleted

Blockedon: 712781
Status: Started (was: Assigned)
Blockedon: 748164
Blockedon: 748193
Blockedon: 748199
Blockedon: 748204

Comment 23 by dbeam@chromium.org, Jul 26 2017

^ if anybody was wondering how bidi checker is related, it loaded the old settings URL (which both stevenjb@ and I found when grepping for the URL constant, presumably)
Blocking: 750885
Labels: M-62
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f2b58d76f2d61471b9afe04de743b127ae49685

commit 1f2b58d76f2d61471b9afe04de743b127ae49685
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Aug 16 01:35:45 2017

Settings: Eliminate options code!

This eliminates dead code in:
* chrome/browser/resources/help/
* chrome/browser/resources/options/
* chrome/browser/ui/webui/options/

Workaround for crbug.com/755824:
NOPRESUBMIT=true

Bug:  728353 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8879dd7e7fd19e06bafb232e4e915d50c5d0f52f
Reviewed-on: https://chromium-review.googlesource.com/602884
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494658}
[modify] https://crrev.com/1f2b58d76f2d61471b9afe04de743b127ae49685/WATCHLISTS
[modify] https://crrev.com/1f2b58d76f2d61471b9afe04de743b127ae49685/chrome/BUILD.gn
[modify] https://crrev.com/1f2b58d76f2d61471b9afe04de743b127ae49685/chrome/browser/browser_resources.grd
[modify] https://crrev.com/1f2b58d76f2d61471b9afe04de743b127ae49685/chrome/browser/resources/BUILD.gn
[modify] https://crrev.com/1f2b58d76f2d61471b9afe04de743b127ae49685/chrome/browser/resources/OWNERS
[modify] https://crrev.com/1f2b58d76f2d61471b9afe04de743b127ae49685/chrome/browser/resources/chromeos/login/login_non_lock_shared.html
[modify] https://crrev.com/1f2b58d76f2d61471b9afe04de743b127ae49685/chrome/browser/resources/chromeos/login/oobe_hid_detection.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/OWNERS
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/channel_change_page.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/channel_change_page.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/channel_change_page.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/compiled_resources2.gyp
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/help.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/help.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/help.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/help_content.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/help_content.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/help_page.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/help/help_page.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/2x/yellow_gear.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/OWNERS
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/alert_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/alert_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/alert_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_edit_address_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_edit_address_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_edit_creditcard_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_edit_creditcard_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_edit_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_options.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_options.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_options.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/autofill_options_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/automatic_settings_reset_banner.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/automatic_settings_reset_banner.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/automatic_settings_reset_banner.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/browser_options.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/browser_options.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/browser_options.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/browser_options_profile_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/browser_options_startup_page_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_backup_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_backup_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_edit_ca_trust_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_edit_ca_trust_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_import_error_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_import_error_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_manager.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_manager.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_manager.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_restore_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_restore_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_tree.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/certificate_tree.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/2x/warning.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/OWNERS
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/accounts_options.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/accounts_options.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/accounts_options_page.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/accounts_user_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/bluetooth.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/bluetooth_device_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/browser_options.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/change_picture_options.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/change_picture_options.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/change_picture_options.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_layout.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_layout_manager.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_layout_manager_multi.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_options.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_options.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_options.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_overscan.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_overscan.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/display_overscan.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/internet_detail.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/internet_detail.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/internet_detail.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/internet_detail_ip_address_field.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/keyboard_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/keyboard_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/keyboard_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/network_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/onc_data.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/overscan_arrows.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/overscan_arrows_2x.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/overscan_shift.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/overscan_shift_2x.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/overscan_shift_rtl.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/overscan_shift_rtl_2x.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/pointer_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/pointer_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/pointer_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/power_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/power_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/power_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/preferred_networks.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/preferred_networks.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/proxy_rules_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/space_critically_low.svg
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/space_low.svg
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/storage_clear_drive_cache_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/storage_clear_drive_cache_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/storage_clear_drive_cache_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/storage_manager.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/storage_manager.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/storage_manager.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/stylus_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/stylus_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/stylus_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/chromeos/warning.png
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/clear_browser_data_history_notice_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/clear_browser_data_history_notice_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/clear_browser_data_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/clear_browser_data_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/clear_browser_data_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/compiled_resources2.gyp
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/confirm_dialog.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/content_settings.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/content_settings.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/content_settings.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/content_settings_exceptions_area.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/content_settings_exceptions_area.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/content_settings_ui.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/controlled_setting.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/cookies_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/cookies_view.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/cookies_view.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/cookies_view.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/deletable_item_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/do_not_track_confirm_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/do_not_track_confirm_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/easy_unlock_turn_off_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/easy_unlock_turn_off_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/easy_unlock_turn_off_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/editable_text_field.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/factory_reset_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/factory_reset_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/factory_reset_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/font_settings.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/font_settings.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/font_settings.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/geolocation_options.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/googleg.svg
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/handler_options.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/handler_options.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/handler_options.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/handler_options_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/home_page_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/home_page_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/hotword_confirm_dialog.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/hotword_confirm_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/hotword_confirm_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/hotword_search_setting_indicator.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/hotword_search_setting_indicator.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/i18n_setup.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/import_data_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/import_data_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/import_data_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/inline_editable_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_add_language_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_add_language_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_dictionary_overlay.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_dictionary_overlay.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_dictionary_overlay.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_dictionary_overlay_word_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_list.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_options.css
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_options.html
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/language_options.js
[delete] https://crrev.com/65fbd32e753d967539e57bb3b9fee2ec0363519f/chrome/browser/resources/options/manage_pro
Status: Fixed (was: Started)
Removed! Hooray!!

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66

commit d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Aug 21 22:41:16 2017

Settings: Remove some unused strings and files

Part 1 of a series to eliminate unused Options UI strings.
* manage_passwords_view_utils_desktop.cc is unused
* custom_home_pages_table_model.cc is only used by a Settings handler
  and should be moved to the settings directory and use settings strings.

Bug:  728353 
Change-Id: I0607a234b469e246fd7064a5fedf453c6bd9aa44
Reviewed-on: https://chromium-review.googlesource.com/621947
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496098}
[modify] https://crrev.com/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66/chrome/app/generated_resources.grd
[modify] https://crrev.com/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66/chrome/app/settings_strings.grdp
[modify] https://crrev.com/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66/chrome/browser/BUILD.gn
[modify] https://crrev.com/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/0a726d2d29d10b3205c26c7ed3d53b5652a06dff/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.cc
[delete] https://crrev.com/0a726d2d29d10b3205c26c7ed3d53b5652a06dff/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop.h
[delete] https://crrev.com/0a726d2d29d10b3205c26c7ed3d53b5652a06dff/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
[rename] https://crrev.com/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66/chrome/browser/ui/webui/settings/custom_home_pages_table_model.cc
[rename] https://crrev.com/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66/chrome/browser/ui/webui/settings/custom_home_pages_table_model.h
[modify] https://crrev.com/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66/chrome/browser/ui/webui/settings/settings_startup_pages_handler.h
[modify] https://crrev.com/d6d6cf62ea3263ba9a3033b5dd90c86af8b26b66/chrome/test/BUILD.gn

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc02fb5f4467493774bfa3dbba991b961e9e78ba

commit dc02fb5f4467493774bfa3dbba991b961e9e78ba
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Aug 22 21:11:12 2017

Settings: Move/rename additional strings

This moves and renames some remaining 'options' strings that are still
in use.

Bug:  728353 
Change-Id: Ib7901e857c6d0e11aaa9378f5e2e8e49fc40e1ca
Reviewed-on: https://chromium-review.googlesource.com/622152
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496442}
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/app/generated_resources.grd
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/profile_resetter/resettable_settings_snapshot.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/views/first_run_dialog.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/webui/policy_indicator_localized_strings_provider.cc
[modify] https://crrev.com/dc02fb5f4467493774bfa3dbba991b961e9e78ba/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9d65767ae737f38e647436e702ed4b357187be8

commit f9d65767ae737f38e647436e702ed4b357187be8
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Aug 23 01:22:24 2017

Settings: Remove remaining unused OPTIONS strings

Bug:  728353 
Change-Id: Ia96acca50581b7d3e8e30b01d445c8c4031cb4f1
Reviewed-on: https://chromium-review.googlesource.com/622069
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496545}
[modify] https://crrev.com/f9d65767ae737f38e647436e702ed4b357187be8/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/f9d65767ae737f38e647436e702ed4b357187be8/chrome/app/generated_resources.grd

Sign in to add a comment