Per feedback from devs, Findit's notification emails cause noise in such cases. We'd better not let code-review send out email when posting such confirmation message. Example: https://codereview.chromium.org/2905753002/
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/cf8801512f73d0427cea03578c78d309c3b87830 commit cf8801512f73d0427cea03578c78d309c3b87830 Author: Chan <chanli@chromium.org> Date: Mon Jun 05 17:41:46 2017 Don't send email if Findit is confirming a revert. Bug: 728336 Change-Id: I64dc7638224273899b95eff56ca42d11906ea4a0 Reviewed-on: https://chromium-review.googlesource.com/520623 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/cf8801512f73d0427cea03578c78d309c3b87830/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py [modify] https://crrev.com/cf8801512f73d0427cea03578c78d309c3b87830/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py [modify] https://crrev.com/cf8801512f73d0427cea03578c78d309c3b87830/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [modify] https://crrev.com/cf8801512f73d0427cea03578c78d309c3b87830/appengine/findit/infra_api_clients/codereview/rietveld.py [modify] https://crrev.com/cf8801512f73d0427cea03578c78d309c3b87830/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/cf8801512f73d0427cea03578c78d309c3b87830/appengine/findit/infra_api_clients/codereview/codereview.py
Comment 1 by bugdroid1@chromium.org
, Jun 5 2017