Incorporate fading on the right side of a truncated URL. |
|||||||
Issue descriptionWe currently truncate URLs abruptly, so there is no indication that the URL continues. Enamel pointed out that we should fade. Previously, the VR implementation did actually fade, by setting an elide property on the rendertext field. We should re-incorporate this. However, note also that we need to be able to show the whole hostname. See the code that bails to clank if we can't show the host. So, we need to somehow reliably ensure that the fading part isn't part of the host. Maybe there's a parameter available to the fading call to set this? A test URL: https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/
,
Jun 7 2017
,
Jun 8 2017
,
Jun 16 2017
Alternatively, if the fading approach is broken, could we use an ellipsis?
,
Jun 19 2017
I've verified that the ellipsis approach is fine, and further, this approach lets us very easily maintain the "bail if we can't show the full origin" mechanism. I'm posting a CL to use this approach.
,
Jun 19 2017
Dropping dependency on crbug/728765, tracking broken fading-based elision in Skia.
,
Jun 20 2017
This is completed in https://codereview.chromium.org/2944923002/ I'm finding that bugs are not being updated with CL descriptions at the moment.
,
Jun 22 2017
Verified in Chrome Canary 61.0.3138.0 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tiborg@chromium.org
, Jun 1 2017