New issue
Advanced search Search tips

Issue 728331 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Incorporate fading on the right side of a truncated URL.

Project Member Reported by cjgrant@chromium.org, May 31 2017

Issue description

We currently truncate URLs abruptly, so there is no indication that the URL continues.  Enamel pointed out that we should fade.

Previously, the VR implementation did actually fade, by setting an elide property on the rendertext field.  We should re-incorporate this.

However, note also that we need to be able to show the whole hostname.  See the code that bails to clank if we can't show the host.  So, we need to somehow reliably ensure that the fading part isn't part of the host.  Maybe there's a parameter available to the fading call to set this?

A test URL:
https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/

 
Blockedon: 728765
Labels: -M-60 M-61
Labels: Type-Feature

Comment 4 Deleted

Alternatively, if the fading approach is broken, could we use an ellipsis?
Owner: cjgrant@chromium.org
I've verified that the ellipsis approach is fine, and further, this approach lets us very easily maintain the "bail if we can't show the full origin" mechanism.

I'm posting a CL to use this approach.
Blockedon: -728765
Dropping dependency on crbug/728765, tracking broken fading-based elision in Skia.
Status: Fixed (was: Assigned)
This is completed in https://codereview.chromium.org/2944923002/

I'm finding that bugs are not being updated with CL descriptions at the moment.
Status: Verified (was: Fixed)
Verified in Chrome Canary 61.0.3138.0

Sign in to add a comment