Two WebAPK infobars displayed on pwa.rocks |
||
Issue descriptionRepro steps: 1) Navigate to chrome://flags 2) Enable "Improved add to Home screen" 3) Enable "Bypass user engagement checks" 4) Restart Chrome 5) Navigate to pwa.rocks 6) Tap "Add to home screen" in the app menu Expected: Button in current infobar is changed to say "Adding" Actual: New infobar is popped up behind current infobar. See screen shot
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70f73ad825e0b878a81815df06d82e8da1e8d81e commit 70f73ad825e0b878a81815df06d82e8da1e8d81e Author: pkotwicz <pkotwicz@chromium.org> Date: Fri Jun 02 02:44:37 2017 Remove unnecessary IsInfoEmpty() call in app_banner_infobar_delegate_android.cc BUG= 728300 Review-Url: https://codereview.chromium.org/2913383002 Cr-Commit-Position: refs/heads/master@{#476531} [modify] https://crrev.com/70f73ad825e0b878a81815df06d82e8da1e8d81e/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
,
Jun 5 2017
Is this fixed?
,
Jun 5 2017
This is not fixed. https://codereview.chromium.org/2915913002/ is the CL which fixes the bug
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d654734a905602faa2dd33b7a60f06fd80efcdfb commit d654734a905602faa2dd33b7a60f06fd80efcdfb Author: pkotwicz <pkotwicz@chromium.org> Date: Mon Jun 26 22:35:27 2017 [Android] Suggest page title for homescreen shortcut when Web Manifest is empty Previously, when a user tapped "add to home screen" in the app menu for a page with a Web Manifest with empty "short_name" and "name" fields, the add-to-homescreen-dialog would show with an empty text field. This CL changes the behavior in this scenario so that the text field is populated with the page title. BUG= 728300 TEST=ShortcutInfoTest.* Review-Url: https://codereview.chromium.org/2948313002 Cr-Commit-Position: refs/heads/master@{#482440} [modify] https://crrev.com/d654734a905602faa2dd33b7a60f06fd80efcdfb/chrome/browser/android/shortcut_info.cc [modify] https://crrev.com/d654734a905602faa2dd33b7a60f06fd80efcdfb/chrome/browser/android/shortcut_info_unittest.cc
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41ffd85bd01d941f109ce9f8e94f098834dcf29b commit 41ffd85bd01d941f109ce9f8e94f098834dcf29b Author: pkotwicz <pkotwicz@chromium.org> Date: Tue Jun 27 01:34:00 2017 [Refactor] Remove AppBannerManager::app_title_ This CL removes AppBannerManager::app_title_ in favor of a native app dedicated variable BUG= 728300 Review-Url: https://codereview.chromium.org/2950113003 Cr-Commit-Position: refs/heads/master@{#482505} [modify] https://crrev.com/41ffd85bd01d941f109ce9f8e94f098834dcf29b/chrome/browser/android/banners/app_banner_manager_android.cc [modify] https://crrev.com/41ffd85bd01d941f109ce9f8e94f098834dcf29b/chrome/browser/android/banners/app_banner_manager_android.h [modify] https://crrev.com/41ffd85bd01d941f109ce9f8e94f098834dcf29b/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/41ffd85bd01d941f109ce9f8e94f098834dcf29b/chrome/browser/banners/app_banner_manager.h
,
Jun 27 2017
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4d01caea21d315b49a92cf9ad71f034e323f766 commit d4d01caea21d315b49a92cf9ad71f034e323f766 Author: pkotwicz <pkotwicz@chromium.org> Date: Tue Jun 27 18:45:17 2017 [WebAPKs] Display same text for menu & engagement banner This CL changes the text of the banner displayed when installing a WebAPK from the app menu to match the text of the banner displayed via the engagement checks. Using the same text in both banners prevents creating a second banner if a user tries to install a WebAPK from the app menu if the "user engagement A2HS" banner is already visible. BUG= 728300 Review-Url: https://codereview.chromium.org/2957473002 Cr-Commit-Position: refs/heads/master@{#482690} [modify] https://crrev.com/d4d01caea21d315b49a92cf9ad71f034e323f766/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc [modify] https://crrev.com/d4d01caea21d315b49a92cf9ad71f034e323f766/chrome/browser/android/banners/app_banner_infobar_delegate_android.h [modify] https://crrev.com/d4d01caea21d315b49a92cf9ad71f034e323f766/chrome/browser/android/banners/app_banner_manager_android.cc [modify] https://crrev.com/d4d01caea21d315b49a92cf9ad71f034e323f766/chrome/browser/android/webapps/add_to_homescreen_manager.cc |
||
►
Sign in to add a comment |
||
Comment 1 by pkotw...@chromium.org
, May 31 2017