New issue
Advanced search Search tips

Issue 728299 link

Starred by 2 users
Status: Duplicate
Merged: issue 739505
Owner: ----
Closed: Aug 27
Cc:
thakis@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , All , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove tracked_objects::ThreadData::EnsureCleanupWasCalled method.

Project Member Reported by michaeldo@chromium.org, May 31 2017 
This method was added more than 5 years ago to fix  crbug.com/103209  but the contained check has never been executed and the bug has been marked as fixed.

This call simply clutters client code and raises questions about why hardcoded thread counts exist. Especially because the code isn't executed and the value |4| isn't documented for existing callers.

We should remove this method and stop internally tracking |cleanup_count_|.

Comment 1 by edchin@chromium.org, Jun 5 2017

Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by scottmg@chromium.org, Jun 29 2017

Labels: -OS-Fuchsia

Comment 3 by eugene...@chromium.org, Jul 6 2017

Cc: -michaeldo@chromium.org
Components: Internals
Owner: ----
Status: Untriaged (was: Assigned)

Comment 4 by jif@chromium.org, Jul 21 2017

Owner: jar@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by eugene...@chromium.org, Aug 25 2017

Cc: thakis@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 27

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by michaeldo@chromium.org, Aug 27

Mergedinto: 739505
Status: Duplicate (was: Untriaged)
This has now already been removed as part of  crbug.com/739505 .
►

Sign in to add a comment