git cl owners should check existing reviewers |
||
Issue descriptionFeature request: it'd be nice if "git cl owners" downloaded the list of existing reviewers and selected those automatically before suggesting additional ones. 99% of the time when I run it it's because I want to find an owner for the 1 or 2 unreviewed files left. It's not helpful for it to suggest owners who could review files that have already been reviewed.
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/707d70b91e5f60ac78b194d04866ebfb55359061 commit 707d70b91e5f60ac78b194d04866ebfb55359061 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Wed Feb 07 20:34:44 2018 Skip files owned by reviewers when quering for missing owners. Bug: 728298 Change-Id: If813ff41b1668a2cab6c26b65e424fbe574e629c Reviewed-on: https://chromium-review.googlesource.com/899086 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/707d70b91e5f60ac78b194d04866ebfb55359061/presubmit_canned_checks.py [modify] https://crrev.com/707d70b91e5f60ac78b194d04866ebfb55359061/tests/owners_finder_test.py [modify] https://crrev.com/707d70b91e5f60ac78b194d04866ebfb55359061/tests/presubmit_unittest.py [modify] https://crrev.com/707d70b91e5f60ac78b194d04866ebfb55359061/git_cl.py [modify] https://crrev.com/707d70b91e5f60ac78b194d04866ebfb55359061/owners_finder.py
,
Feb 9 2018
Claim and close bugs when you work on them, so you get credit! :) |
||
►
Sign in to add a comment |
||
Comment 1 by aga...@chromium.org
, Jan 4 2018Labels: Pri-2
Status: Available (was: Untriaged)