New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728292 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Traveling - Back 2/6
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

In-Product Help Demo mode is never initialized

Project Member Reported by nyquist@chromium.org, May 31 2017

Issue description

Chrome Version: M60
OS: Android

What steps will reproduce the problem?
(1) Start Chrome
(2) Enable In-Product Help demo mode from chrome://flags
(3) Restart Chrome

What is the expected result?
In-Product Help should be displayed for visiting the downloads home.

What happens instead?
A different In-Product Help is displayed.

Notes:
The issue is that the demo-mode never ends up being initialized since the NeverAvailabilityModel never initializes it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c02705b00898f8dd026c3ad9af909d0607526de

commit 9c02705b00898f8dd026c3ad9af909d0607526de
Author: Tommy Nyquist <nyquist@chromium.org>
Date: Thu Jun 01 00:10:22 2017

Ensure that the NeverAvailabilityModel initializes.

Currently, the NeverAvailabilityModel ignores the call to Initialize.

This leads to issues with the In-Product Help demo mode which
requires the model to be initialized, which depended on the callback
passed to NeverAvailabilityModel::Initialize(...) to be invoked.

This CL therefore adds support for invoking the callback and setting
the ready flag for the NeverAvailabilityModel and updates the
tests to take this into account.

BUG= 728292 

Change-Id: Ia636d9e9f0490fe78a12d5fcdd7d128e7b410e26
Reviewed-on: https://chromium-review.googlesource.com/519104
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476104}
[modify] https://crrev.com/9c02705b00898f8dd026c3ad9af909d0607526de/components/feature_engagement_tracker/internal/never_availability_model.cc
[modify] https://crrev.com/9c02705b00898f8dd026c3ad9af909d0607526de/components/feature_engagement_tracker/internal/never_availability_model.h
[modify] https://crrev.com/9c02705b00898f8dd026c3ad9af909d0607526de/components/feature_engagement_tracker/internal/never_availability_model_unittest.cc

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5941265e5d42830b69ce233785ef8b14e0210a5a

commit 5941265e5d42830b69ce233785ef8b14e0210a5a
Author: Tommy Nyquist <nyquist@chromium.org>
Date: Thu Jun 01 00:35:53 2017

Ensure that the NeverAvailabilityModel initializes.

Currently, the NeverAvailabilityModel ignores the call to Initialize.

This leads to issues with the In-Product Help demo mode which
requires the model to be initialized, which depended on the callback
passed to NeverAvailabilityModel::Initialize(...) to be invoked.

This CL therefore adds support for invoking the callback and setting
the ready flag for the NeverAvailabilityModel and updates the
tests to take this into account.

BUG= 728292 
TBR=nyquist@chromium.org

(cherry picked from commit 9c02705b00898f8dd026c3ad9af909d0607526de)

Change-Id: Ia636d9e9f0490fe78a12d5fcdd7d128e7b410e26
Reviewed-on: https://chromium-review.googlesource.com/519104
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#476104}
Reviewed-on: https://chromium-review.googlesource.com/520485
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#75}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/5941265e5d42830b69ce233785ef8b14e0210a5a/components/feature_engagement_tracker/internal/never_availability_model.cc
[modify] https://crrev.com/5941265e5d42830b69ce233785ef8b14e0210a5a/components/feature_engagement_tracker/internal/never_availability_model.h
[modify] https://crrev.com/5941265e5d42830b69ce233785ef8b14e0210a5a/components/feature_engagement_tracker/internal/never_availability_model_unittest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment