[WPT Import] Run tests locally to get cross-platform baselines |
||||||
Issue descriptionThis would be an optimization to speed up many automatic wpt imports -- after importing and before triggering the tryserver.blink bots, the modified layout tests could be run once and expectations could be set at that time. Sometimes, this will be correct, and other times, baselines and expectations will be updated after a round of try jobs.
,
Jun 1 2017
In https://chromium-review.googlesource.com/c/520384/ there's unsurprisingly a way just using the modified files can easily go wrong, interfaces/fullscreen.idl was updated and therefore fullscreen/interfaces.html would fail. If doing this, we'd need to experiment with different heuristics to get average import delay down by enough to justify the complexity. One way could be to also grep for the filenames of any modified files, and run any tests with matches as well.
,
Jul 3 2017
,
Jul 3 2017
,
Jul 3
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12
robertma@, what do you think, would this be sound, to often save a cycle of bot? It ought to roughly halve the fastest import time, but do you think it's worth the complexity? If not, please WontFix.
,
Jul 18
Marking this as wontfix because (IMHO) the complexity significantly outweighs the potential benefits: 1. The cron bot (wpt-importer) isn't a builder so it doesn't compile code at all. It'd take some effort to add a compilation step to the bot, which in turn will introduce >10min of delay (compiling asynchronously is possible but much more complicated). 2. Nowadays all bots run layout tests on Swarming. It's easy to increase the number of shards (and we've already done this a few times) when running layout tests on some bot becomes a bottleneck. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by foolip@chromium.org
, Jun 1 2017