This bug tracks works to polish the host list view UX
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d138159d521118ad2a61d5ae34767e7c05adb6d commit 5d138159d521118ad2a61d5ae34767e7c05adb6d Author: yuweih <yuweih@chromium.org> Date: Wed May 31 20:48:00 2017 [CRD iOS] Consistent host list order and showing last online time This CL: * Gives consistent sorting order to the host list, similar to how the HostListManager is doing in Android. * Shows the localized last online time on the host list. * Fixes some issues when parsing the HostInfo. HostOs should have lower case s and it doesn't need to fail if the JSON is missing these fields. BUG= 728280 Review-Url: https://codereview.chromium.org/2912293003 Cr-Commit-Position: refs/heads/master@{#476012} [modify] https://crrev.com/5d138159d521118ad2a61d5ae34767e7c05adb6d/remoting/ios/app/host_collection_view_cell.mm [modify] https://crrev.com/5d138159d521118ad2a61d5ae34767e7c05adb6d/remoting/ios/app/main.mm [modify] https://crrev.com/5d138159d521118ad2a61d5ae34767e7c05adb6d/remoting/ios/domain/host_info.h [modify] https://crrev.com/5d138159d521118ad2a61d5ae34767e7c05adb6d/remoting/ios/domain/host_info.mm [modify] https://crrev.com/5d138159d521118ad2a61d5ae34767e7c05adb6d/remoting/ios/facade/host_info.cc [modify] https://crrev.com/5d138159d521118ad2a61d5ae34767e7c05adb6d/remoting/ios/facade/host_info.h [modify] https://crrev.com/5d138159d521118ad2a61d5ae34767e7c05adb6d/remoting/ios/facade/host_list_fetcher.cc [modify] https://crrev.com/5d138159d521118ad2a61d5ae34767e7c05adb6d/remoting/ios/facade/remoting_service.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/625e0f8156b02d6dd9544d86defcd0f6665ecae9 commit 625e0f8156b02d6dd9544d86defcd0f6665ecae9 Author: yuweih <yuweih@chromium.org> Date: Thu Jun 01 19:14:33 2017 [CRD iOS] Fix shadow between host cards and use anchor constraints This CL fixes these issues in the host list UX: 1. Fixes the mysterious shadow occasionally showed between host cards. 2. Fixes the constraint of the label's width. 3. Use anchor constraints to minimize position calculations and use leading & trailing anchors to better support RTL languages. BUG= 728280 Review-Url: https://codereview.chromium.org/2916003002 Cr-Commit-Position: refs/heads/master@{#476381} [modify] https://crrev.com/625e0f8156b02d6dd9544d86defcd0f6665ecae9/remoting/ios/app/host_collection_view_cell.mm [modify] https://crrev.com/625e0f8156b02d6dd9544d86defcd0f6665ecae9/remoting/ios/app/host_collection_view_controller.mm [modify] https://crrev.com/625e0f8156b02d6dd9544d86defcd0f6665ecae9/remoting/ios/app/remoting_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b10f8f6e185160f4b30d279ad7feb913cf5f02c commit 5b10f8f6e185160f4b30d279ad7feb913cf5f02c Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Jun 05 21:05:08 2017 [CRD iOS] Background image and fixing the flex header This CL adds the background image to the host list view. It also fixed a bug that the setter of the flexHeaderContainerViewController was not properly named. Screenshots: https://drive.google.com/file/d/0BytzIZKeM8nBaXVYY0F0WmU2YkU/view?usp=sharing https://drive.google.com/file/d/0BytzIZKeM8nBa0lPbUlFSkl5Mjg/view?usp=sharing Bug: 728280 Change-Id: I862590caa9838c4c379a82e5f1c88ef276bb8373 Reviewed-on: https://chromium-review.googlesource.com/524438 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#477082} [modify] https://crrev.com/5b10f8f6e185160f4b30d279ad7feb913cf5f02c/remoting/ios/app/host_collection_view_controller.mm [modify] https://crrev.com/5b10f8f6e185160f4b30d279ad7feb913cf5f02c/remoting/ios/app/remoting_view_controller.mm [add] https://crrev.com/5b10f8f6e185160f4b30d279ad7feb913cf5f02c/remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json [add] https://crrev.com/5b10f8f6e185160f4b30d279ad7feb913cf5f02c/remoting/ios/app/resources/Assets.xcassets/Background.imageset/bkg1.jpg [add] https://crrev.com/5b10f8f6e185160f4b30d279ad7feb913cf5f02c/remoting/ios/app/resources/Assets.xcassets/Background.imageset/bkg1_2x.jpg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a commit 3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a Author: yuweih <yuweih@chromium.org> Date: Tue Jun 06 23:35:57 2017 [CRD iOS] Finish up the host list UI This CL finishes up matching the host list UX mocks. It: * Changes the menu and refresh icon * Adds title for the app bar * Adds the "Remote devices" section header Screenshots: https://drive.google.com/file/d/0BytzIZKeM8nBZ255YmxxeTBPajQ/view?usp=sharing https://drive.google.com/file/d/0BytzIZKeM8nBd0g0cjRWSWlJSlE/view?usp=sharing BUG= 728280 Review-Url: https://codereview.chromium.org/2921413002 Cr-Commit-Position: refs/heads/master@{#477462} [modify] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/BUILD.gn [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/host_collection_header_view.h [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/host_collection_header_view.mm [modify] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/host_collection_view_controller.mm [modify] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/remoting_view_controller.mm [modify] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/Contents.json [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white.png [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white_2x.png [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/ic_menu.imageset/ic_menu_white_3x.png [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/ic_refresh.imageset/Contents.json [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/ic_refresh.imageset/ic_refresh_white.png [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/ic_refresh.imageset/ic_refresh_white_2x.png [add] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/Assets.xcassets/ic_refresh.imageset/ic_refresh_white_3x.png [modify] https://crrev.com/3c9d15f88ffe157a9f4a3b74e33a17bc69d1f56a/remoting/ios/app/resources/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/586612f5cb614fadb37cb05602dba204154e645e commit 586612f5cb614fadb37cb05602dba204154e645e Author: yuweih <yuweih@chromium.org> Date: Thu Jun 08 00:19:46 2017 [CRD iOS] Fix color scheme and other UI issues This CL basically fixes the color scheme on the host list and the connection view so that it better matches the UX mocks. This CL also makes the host list dismiss all snack bars before opening the connection view. BUG= 728280 Review-Url: https://codereview.chromium.org/2929663002 Cr-Commit-Position: refs/heads/master@{#477822} [modify] https://crrev.com/586612f5cb614fadb37cb05602dba204154e645e/remoting/ios/app/BUILD.gn [modify] https://crrev.com/586612f5cb614fadb37cb05602dba204154e645e/remoting/ios/app/client_connection_view_controller.mm [modify] https://crrev.com/586612f5cb614fadb37cb05602dba204154e645e/remoting/ios/app/host_collection_view_cell.mm [modify] https://crrev.com/586612f5cb614fadb37cb05602dba204154e645e/remoting/ios/app/pin_entry_view.mm [add] https://crrev.com/586612f5cb614fadb37cb05602dba204154e645e/remoting/ios/app/remoting_theme.h [add] https://crrev.com/586612f5cb614fadb37cb05602dba204154e645e/remoting/ios/app/remoting_theme.mm [modify] https://crrev.com/586612f5cb614fadb37cb05602dba204154e645e/remoting/ios/app/remoting_view_controller.mm [modify] https://crrev.com/586612f5cb614fadb37cb05602dba204154e645e/remoting/ios/app/resources/Assets.xcassets/Background.imageset/Contents.json
Verified in 63.0.3220.0
Comment 1 by bugdroid1@chromium.org
, May 31 2017