New issue
Advanced search Search tips

Issue 728275 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

nassh: add option to disable Relay reconnection/resumption

Project Member Reported by varz@google.com, May 31 2017

Issue description

nassh.Stream.GoogleRelayWS will attempt to reconnect when a WebSocket error occurs, but none of our relay implementations support this functionality which is confusing for users who are presenting with a "Retrying..." overlay

To avoid breaking resumption support by any of the third party relays, we should plumb a new relay option to disable connection retries and set it to true in config=google.
 

Comment 1 by vapier@chromium.org, May 31 2017

i guess this would resolve  issue 720082  ?

Comment 2 by varz@google.com, May 31 2017

It would certainly do that for our relays, yes.
I think it'd be more elegant to have the relay tell the client that it does not support reconnects.

This could be done in the response from /cookie or in the response from /proxy. I would prefer the latter because then this can be toggled per session. On the other hand, putting this in /proxy depends on making /proxy more friendly to extension, for which there is a proposal at https://goto.google.com/straightforward-slash-proxy (if I recall the link correctly).

Comment 4 Deleted

Comment 5 Deleted

 Issue 720082  has been merged into this issue.
 Issue 895545  has been merged into this issue.
I don't think  Issue 895545  is really a dup of this, since I was asking for something different - a way to get out of the Retrying... state and actually reconnect (which does work).

If retry doesn't work (within a reasonable timeout - maybe 5-30 seconds?), it should revert to the same prompt I get when I disconnect manually, to "(R)econnect, (C)hoose another connection, or E(x)it?"

And while in the Retrying... state, there should be a key sequence (which should be shown in the overlay, e.g. "Retrying... (press Shift-Ctrl-WTF to abort)") to escape immediately to the above prompt, or back to the choose-a-connection page.

Owner: vapier@chromium.org
Status: Fixed (was: Available)
> since I was asking for something different - a way to get out of the Retrying... state and actually reconnect

you can do that already.  press:
  Enter ~ .
that will break the connection at any time.  this is standard OpenSSH commands, not something specific to Secure Shell.

i've changed the default Google relay usage so that we don't try to resume at all now

Sign in to add a comment