New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 728262 link

Starred by 1 user
Status: Fixed
Owner:
█ chenwilliam@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

DevTools: unify Network & CPU throttling

Project Member Reported by chenwilliam@chromium.org, May 31 2017 
Users want to simulate mobile device conditions. Combining Network & CPU throttling UIs into a single interface simplifies the user workflow.

Screenshots:
Selector - http://imgur.com/a/btqpx
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de

commit 6f9400d2dce36b995fa0da47ca25c3c2bf0b18de
Author: chenwilliam <chenwilliam@chromium.org>
Date: Thu Jun 01 02:29:14 2017

DevTools: prepare to unify Network and CPU throttling UI

Combines the network and & CPU throttling components into a single module
since they will be surfaced as a single UI.

This also extracts network priorities into its own module which had a
dubious home in network_conditions to begin with.

Also improves extract_module:
- Includes comments on how to use extract_module
- Use 'npm run extract' to run extract_module script

BUG= 728262 

Review-Url: https://codereview.chromium.org/2915883002
Cr-Commit-Position: refs/heads/master@{#476156}

[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/components/module.json
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/emulation/module.json
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/inspector.json
[rename] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/mobile_throttling/CPUThrottlingManager.js
[rename] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkConditionsSelector.js
[rename] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkConditionsSettingsTab.js
[rename] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/mobile_throttling/module.json
[rename] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/mobile_throttling/networkConditionsSettingsTab.css
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/network/module.json
[rename] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/network_priorities/NetworkPriorities.js
[add] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/network_priorities/module.json
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/resources/module.json
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/front_end/timeline/module.json
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/package.json
[modify] https://crrev.com/6f9400d2dce36b995fa0da47ca25c3c2bf0b18de/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js

Comment 2 by chenwilliam@chromium.org, Jun 13 2017

Description: Show this description

Comment 3 by chenwilliam@chromium.org, Jun 13 2017

Description: Show this description

Comment 4 by chenwilliam@chromium.org, Jun 13 2017

Description: Show this description

Comment 5 by chenwilliam@chromium.org, Jun 13 2017

Description: Show this description

Comment 6 by chenwilliam@chromium.org, Jun 27 2017

Description: Show this description

Comment 7 by chenwilliam@chromium.org, Jun 27 2017

Description: Show this description
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a713f878e6daf3a63106e81342b3b4b153ad2fd

commit 9a713f878e6daf3a63106e81342b3b4b153ad2fd
Author: chenwilliam <chenwilliam@chromium.org>
Date: Thu Jul 06 01:36:34 2017

DevTools: unify Network & CPU throttling

Screenshots:
Selector - http://imgur.com/a/btqpx

*Note: LieFi option to come in f/u patch

BUG= 728262 

Review-Url: https://codereview.chromium.org/2938503002
Cr-Commit-Position: refs/heads/master@{#484438}

[add] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/LayoutTests/inspector/throttling/mobile-throttling-expected.txt
[add] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/LayoutTests/inspector/throttling/mobile-throttling.html
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
[delete] https://crrev.com/a7d3f16ffa91d191b3c752af1a728fb86ef4a9ce/third_party/WebKit/Source/devtools/front_end/mobile_throttling/CPUThrottlingManager.js
[add] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/mobile_throttling/MobileThrottlingSelector.js
[delete] https://crrev.com/a7d3f16ffa91d191b3c752af1a728fb86ef4a9ce/third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkConditionsSelector.js
[add] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkThrottlingSelector.js
[add] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/mobile_throttling/ThrottlingManager.js
[add] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/mobile_throttling/ThrottlingPresets.js
[rename] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/mobile_throttling/ThrottlingSettingsTab.js
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/mobile_throttling/module.json
[rename] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/mobile_throttling/throttlingSettingsTab.css
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/9a713f878e6daf3a63106e81342b3b4b153ad2fd/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Comment 9 by chenwilliam@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment