New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 728258 link

Starred by 1 user
Status: Duplicate
Merged: issue 726595
Owner:
█ djacobo@chromium.org
Last visit 15 days ago
Closed: Jun 2017
Cc:
sky@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 726595


Sign in to add a comment

Intent picker lacks of a background color for the app candidates' labels

Project Member Reported by djacobo@chromium.org, May 31 2017 
I noticed the text on the intent picker UI looking super weird (attaching image). After bisecting I noticed 9c46717e8d85b283ccb79dd4e305d33ba99b1432  introduced this misbehavior. 

Since that CL sgtm, I think I should enforce each of the app candidates to have a background color explicitly, however I wonder if that is the proper fix.
bad_app_candidates.png
160 KB View Download

Comment 1 by djacobo@chromium.org, May 31 2017 

crrev.com/2919553003 fixes my issue, however I don't know if there is any other problem introduced by the CL cited on comment#1

Comment 2 by djacobo@chromium.org, May 31 2017

Blockedon: 726595
Will continue on this when  crbug.com/726595  is fixed.

Comment 3 by djacobo@chromium.org, Jun 6 2017 

I cannot reproduce after sky@ landed https://chromium-review.googlesource.com/c/519464/, the same behavior should be expected on M60, will test and update here when it's done :)

Comment 4 by djacobo@chromium.org, Jun 9 2017

Mergedinto: 726595
Status: Duplicate (was: Assigned)
It's working now in >= M60. Thanks to sky@ for the fix.
►

Sign in to add a comment