New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728252 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

UserEventService should have a way to ask if the caller should bother creating an event.

Project Member Reported by s...@chromium.org, May 31 2017

Issue description

Right the UserEventService[Impl] takes events, and then does nothing if it determines that no recording should occur. This is convenient for callers, but slightly less than optional from a performance perspective. Sometimes gathering the data for constructing an event may be non-trivial, and we don't want to waste any resources if it's not going to have any real effect.

We should expose a way to ask the UserEventService interface if a given event case is going to be recorded or not, and then let integration sites only proceed if it is going to be recorded. They will only need to bother with this extra step if they know they're doing something non-trival computationally.
 

Comment 1 by s...@chromium.org, Jan 3 2018

Status: WontFix (was: Assigned)
This has become messy. We could make UserEventServiceImpl::ShouldRecordEvent() public, but you'd need to actually make the specifics, and that would kind of defeat the purpose. Alternatively, this desire is probably only for navigation linking types, and they could possible call UserEventServiceImpl::CanRecordHistory().

However, given the small size of current specifics, I'm going to close this bug. Someone can trivially make UserEventServiceImpl::CanRecordHistory() should they have a strong use case for such.

Sign in to add a comment