GN target 'make_signers' seems to be broken
Reported by
akimov.a...@gmail.com,
May 31 2017
|
||
Issue descriptionTarget 'make_signers' seems to be broken in master after CR https://codereview.chromium.org/2832073002. Target 'copies' copies variables.sh to script_dir. Target 'make_signers' call sign_versioned_dir.sh. sign_versioned_dir.sh uses variables.sh Bug target 'make_signers' have no 'copies' in deps. So now, calling 'ninja make_signers' will fail with `variables.sh: No such file or directory`.
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02f951db0b77eddb5c896b36f494eb7407a899ff commit 02f951db0b77eddb5c896b36f494eb7407a899ff Author: kerrnel <kerrnel@chromium.org> Date: Thu Jun 01 20:10:05 2017 Copy variables.sh for all signing script targets. The variables.sh file was only copied for the installer tools generation, meaning the signing scripts alone could not be built and run. This corrects the dependency problem. BUG= 728241 Review-Url: https://codereview.chromium.org/2914783003 Cr-Commit-Position: refs/heads/master@{#476403} [modify] https://crrev.com/02f951db0b77eddb5c896b36f494eb7407a899ff/chrome/installer/mac/BUILD.gn
,
Jun 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by kerrnel@chromium.org
, May 31 2017Labels: -Pri-3 Pri-2
Owner: kerrnel@chromium.org
Status: Started (was: Unconfirmed)