New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728228 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Improve V8/Blink garbage collection scheduling

Project Member Reported by hpayer@chromium.org, May 31 2017

Issue description

Improve V8/Blink garbage collection scheduling
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc

commit 502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc
Author: hpayer <hpayer@chromium.org>
Date: Fri Jun 02 09:40:16 2017

[heap] Activate memory reducer on external memory activity.

BUG=chromium:728228, chromium:626082 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Review-Url: https://codereview.chromium.org/2917853004
Cr-Commit-Position: refs/heads/master@{#45671}

[modify] https://crrev.com/502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc/include/v8.h
[modify] https://crrev.com/502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc/src/api.cc
[modify] https://crrev.com/502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc/src/heap/heap.cc
[modify] https://crrev.com/502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc/src/isolate.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5ebd6fcd269de6ac85d6805049882e75e298ddb3

commit 5ebd6fcd269de6ac85d6805049882e75e298ddb3
Author: hpayer <hpayer@chromium.org>
Date: Tue Jun 06 12:04:01 2017

[heap] Lower external allocation limit when external memory shrinks.

BUG=chromium:728228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Review-Url: https://codereview.chromium.org/2921883002
Cr-Commit-Position: refs/heads/master@{#45726}

[modify] https://crrev.com/5ebd6fcd269de6ac85d6805049882e75e298ddb3/include/v8.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8d75644fc0ce1cee5d6eca42006f4c4aa89e9b86

commit 8d75644fc0ce1cee5d6eca42006f4c4aa89e9b86
Author: hpayer <hpayer@chromium.org>
Date: Thu Jun 08 08:58:30 2017

[heap] Use larger marking steps during external allocation pressure

BUG= chromium:626082 , chromium:728228

Review-Url: https://codereview.chromium.org/2927553003
Cr-Commit-Position: refs/heads/master@{#45784}

[modify] https://crrev.com/8d75644fc0ce1cee5d6eca42006f4c4aa89e9b86/src/heap/heap.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/195eab4619ace704d34ebd00b197ff8d7c739df7

commit 195eab4619ace704d34ebd00b197ff8d7c739df7
Author: machenbach <machenbach@chromium.org>
Date: Thu Jun 08 21:19:44 2017

Revert of [heap] Use larger marking steps during external allocation pressure (patchset #4 id:60001 of https://codereview.chromium.org/2927553003/ )

Reason for revert:
Blocks the roll. Fails some layout tests:
https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/21757

STDERR: # Fatal error in ../../v8/src/heap/heap.cc, line 957
STDERR: # Check failed: 1.0 <= pressure (1 vs. -0.00503761).

Original issue's description:
> [heap] Use larger marking steps during external allocation pressure
>
> BUG= chromium:626082 , chromium:728228
>
> Review-Url: https://codereview.chromium.org/2927553003
> Cr-Commit-Position: refs/heads/master@{#45784}
> Committed: https://chromium.googlesource.com/v8/v8/+/8d75644fc0ce1cee5d6eca42006f4c4aa89e9b86

TBR=ulan@chromium.org,hpayer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:626082 , chromium:728228

Review-Url: https://codereview.chromium.org/2925333002
Cr-Commit-Position: refs/heads/master@{#45797}

[modify] https://crrev.com/195eab4619ace704d34ebd00b197ff8d7c739df7/src/heap/heap.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b011c781cf639194aa596eb9cbffb42cf63635e5

commit b011c781cf639194aa596eb9cbffb42cf63635e5
Author: hpayer <hpayer@chromium.org>
Date: Mon Jun 12 10:37:49 2017

[heap] Reland use larger marking steps during external allocation pressure

This reverts commit 195eab4619ace704d34ebd00b197ff8d7c739df7.

BUG= chromium:626082 , chromium:728228

Review-Url: https://codereview.chromium.org/2931393002
Cr-Commit-Position: refs/heads/master@{#45843}

[modify] https://crrev.com/b011c781cf639194aa596eb9cbffb42cf63635e5/src/heap/heap.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0cef7f7cf70453599887bbffd25b2e216cd63db3

commit 0cef7f7cf70453599887bbffd25b2e216cd63db3
Author: hpayer <hpayer@chromium.org>
Date: Mon Jun 12 15:58:22 2017

[heap] Register an idle embedder garbage collection when starting incremental marking through reached marking limit.

We need to schedule an idle garbage collection in the embedder to drive progress. The embedder is responsible to schedule the request or ignore it.

BUG=chromium:728228

Review-Url: https://codereview.chromium.org/2937433002
Cr-Commit-Position: refs/heads/master@{#45866}

[modify] https://crrev.com/0cef7f7cf70453599887bbffd25b2e216cd63db3/src/heap/heap.cc
[modify] https://crrev.com/0cef7f7cf70453599887bbffd25b2e216cd63db3/src/heap/spaces.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0aa78b9e5b9f9160f52361705b02eb7e5d522ba4

commit 0aa78b9e5b9f9160f52361705b02eb7e5d522ba4
Author: hpayer <hpayer@chromium.org>
Date: Mon Jun 12 17:05:33 2017

[heap] Schedule idle embedder garbage collection when starting incremental marking from idle task.

BUG=chromium:728228

Review-Url: https://codereview.chromium.org/2930333002
Cr-Commit-Position: refs/heads/master@{#45875}

[modify] https://crrev.com/0aa78b9e5b9f9160f52361705b02eb7e5d522ba4/src/heap/incremental-marking-job.cc

Components: Blink>JavaScript>GC
Labels: -OS-All OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Started (was: Untriaged)

Sign in to add a comment