New issue
Advanced search Search tips

Issue 728227 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 4
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 748505
issue 749514
issue 749515
issue 757169

Blocking:
issue 612328



Sign in to add a comment

Device Service: Serial

Project Member Reported by reillyg@chromium.org, May 31 2017

Issue description

Tasks:

1) Complete the Mojo interface for //device/service (currently only used for constants and structures)
2) Update //extensions/browser/api/serial to depend on //device/serial/public/interfaces
3) Move //device/serial to //services/device/serial

 
Components: -Platform>Apps>API Platform>Apps>API>Serial
//tools/battor_agent also depends on //device/serial, so this will need to be ported to depend on the Mojo interfaces as well.
Note about c#2: on examining //tools/battor, it's not clear whether this should be a consumer of the Device Service or move into the Device Service itself. Further analysis will be needed before starting that part of this project.
Owner: leon....@intel.com
Status: Assigned (was: Available)

Comment 5 by leon....@intel.com, Jul 6 2017

Blocking: 612328

Comment 6 by leon....@intel.com, Jul 25 2017

Blockedon: 748505
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ddd8db7608eea33fea7ef57dff7aa0fa425660c

commit 1ddd8db7608eea33fea7ef57dff7aa0fa425660c
Author: Han Leon <leon.han@intel.com>
Date: Tue Jul 25 16:05:23 2017

[Device Service] Normalize serial.mojom module name

Just like other mojom modules of Device Service,
     device::serial --> device::mojom
This is to prepare for mojofy/servicify //devices/serial/.

BUG= 728227 
TBR=charliea@chromium.org
for mechanical changes in tools/battor_agent/

Change-Id: I627a684ebbd3694a06b8f0df9d68665260a86ae9
Reviewed-on: https://chromium-review.googlesource.com/576127
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489322}
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/buffer.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/buffer.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial.mojom
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_device_enumerator.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_device_enumerator_linux.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_device_enumerator_linux.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_device_enumerator_mac.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_device_enumerator_mac.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_device_enumerator_win.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_device_enumerator_win.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_io_handler.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_io_handler.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_io_handler_posix.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_io_handler_posix.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_io_handler_win.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/serial_io_handler_win.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/test_serial_io_handler.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/device/serial/test_serial_io_handler.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/extensions/browser/api/serial/serial_api.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/extensions/browser/api/serial/serial_api.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/extensions/browser/api/serial/serial_apitest.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/extensions/browser/api/serial/serial_connection.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/extensions/browser/api/serial/serial_connection.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/tools/battor_agent/battor_connection_impl.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/tools/battor_agent/battor_connection_impl.h
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/tools/battor_agent/battor_connection_impl_unittest.cc
[modify] https://crrev.com/1ddd8db7608eea33fea7ef57dff7aa0fa425660c/tools/battor_agent/battor_finder.cc

Comment 8 by leon....@intel.com, Jul 27 2017

Blockedon: 749514

Comment 9 by leon....@intel.com, Jul 27 2017

Blockedon: 749515

Comment 11 by leon....@intel.com, Aug 19 2017

Blockedon: 757169
Status: Started (was: Assigned)
Components: Internals>Services>Device
Owner: reillyg@chromium.org
The final patch for this is out for review:

https://chromium-review.googlesource.com/c/chromium/src/+/1391354
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d2253a51021b585a57fce9044b0490376cf04ae

commit 2d2253a51021b585a57fce9044b0490376cf04ae
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Jan 04 21:30:00 2019

Merge //device/serial into //services/device/serial

All direct consumers of //device/serial have been migrated to the public
Mojo interface provided by //services/device and so //device/serial can
be merged into the Device Service implementation in //services/device.

TBR=hashimoto@chromium.org,tfarina@chromium.org,mmenke@chromium.org

Bug:  728227 
Change-Id: Ifc35502d5b15d854f0d2c03168a15056b9fe4a69
Reviewed-on: https://chromium-review.googlesource.com/c/1391354
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620070}
[modify] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/device/BUILD.gn
[delete] https://crrev.com/095fe82673b4120f91b11d919b02f3153a2a83da/device/serial/BUILD.gn
[delete] https://crrev.com/095fe82673b4120f91b11d919b02f3153a2a83da/device/serial/DEPS
[delete] https://crrev.com/095fe82673b4120f91b11d919b02f3153a2a83da/device/serial/OWNERS
[modify] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/BUILD.gn
[modify] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/BUILD.gn
[modify] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/DEPS
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/buffer.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/buffer.h
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator.h
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator_linux.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator_linux.h
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator_mac.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator_mac.h
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator_unittest.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator_win.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_device_enumerator_win.h
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_io_handler.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_io_handler.h
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_io_handler_posix.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_io_handler_posix.h
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_io_handler_posix_unittest.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_io_handler_win.cc
[rename] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_io_handler_win.h
[modify] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_port_impl.cc
[modify] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_port_impl.h
[modify] https://crrev.com/2d2253a51021b585a57fce9044b0490376cf04ae/services/device/serial/serial_port_manager_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment