Tasks: 1) Define a Mojo interface for //device/hid 2) Update //extensions/browser/api/hid to depend on //device/hid/public/interfaces 3) Move //device/hid to //services/device/hid
//chrome/browser/chromeos and //components also have dependencies on //device/hid. These also need to be examined.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80a586198d12e1a6d02cac715e2ac88bf5d0e565 commit 80a586198d12e1a6d02cac715e2ac88bf5d0e565 Author: Ke He <ke.he@intel.com> Date: Sat Jul 22 01:39:17 2017 Map the HidPlatformDeviceId to HidDeviceId. Before mojofication on Hid, we have to add typemapping for HidDeviceId first. HidDeviceId is defined as uint64_t on MacOS while as string on other platforms. In this CL, we rename the original HidDeviceId to HidPlatformDeviceId, and define the new HidDeviceId type as uint64_t. we map the PlatformHidDeviceId to HidDeviceId. All clients of HidService should hold the new HidDeviceId instead of the PlatformHidDeviceId. BUG= 728223 Change-Id: I3585c9eb0eacb02571258314c14e063adce653fc Reviewed-on: https://chromium-review.googlesource.com/570201 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#488837} [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/chrome/browser/extensions/api/device_permissions_manager_unittest.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_connection_unittest.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_device_info.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_device_info.h [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_device_info_linux.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_device_info_linux.h [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_service.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_service.h [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_service_linux.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_service_linux.h [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_service_mac.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_service_mac.h [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_service_win.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/hid_service_win.h [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/mock_hid_service.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/hid/mock_hid_service.h [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/device/u2f/u2f_hid_device.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/extensions/browser/api/hid/hid_api.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/extensions/browser/api/hid/hid_device_manager.cc [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/extensions/browser/api/hid/hid_device_manager.h [modify] https://crrev.com/80a586198d12e1a6d02cac715e2ac88bf5d0e565/extensions/test/data/api_test/hid/get_user_selected_devices/background.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/522ac9766208c08fd3d13ce084772ae73853a8d0 commit 522ac9766208c08fd3d13ce084772ae73853a8d0 Author: Ke He <ke.he@intel.com> Date: Fri Aug 25 00:52:22 2017 Remove HidService::Observer::OnDeviceRemovedCleanup() DevicePermissionsManager has implicit dependency on HidDeviceManager. Now we make that dependency explict with removing the OnDeviceRemovedCleanup(). The HidService::GetDevices(callback) is changed to run the callback synchronously. BUG= 728223 Change-Id: Iefe114a9cc3eb0dfcfd776caed1f49c548ae2c18 Reviewed-on: https://chromium-review.googlesource.com/615008 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497273} [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/chrome/browser/extensions/api/device_permissions_manager_unittest.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_connection_unittest.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_service.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_service.h [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_service_linux.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_service_linux.h [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_service_mac.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_service_mac.h [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_service_win.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/hid_service_win.h [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/mock_hid_service.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/hid/mock_hid_service.h [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/u2f/u2f_request.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/u2f/u2f_request.h [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/device/u2f/u2f_request_unittest.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/extensions/browser/api/device_permissions_manager.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/extensions/browser/api/device_permissions_manager.h [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/extensions/browser/api/device_permissions_prompt.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/extensions/browser/api/hid/hid_device_manager.cc [modify] https://crrev.com/522ac9766208c08fd3d13ce084772ae73853a8d0/extensions/browser/api/hid/hid_device_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077 commit 8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077 Author: Ke He <ke.he@intel.com> Date: Thu Aug 31 00:16:24 2017 Add hid.mojom, re-define the device::HidDeviceInfo. This is a prepare CL for the mojofication in next step. In this CL we change: 1) Add hid.mojom in which we define the device::mojom::HidDeviceInfo. 2) Re-define the device::HidDeviceInfo which wraps the device::mojom::HidDeviceInfo. The device::HidDeviceInfo will be internal and won't exposed to client(after mojofication). Remove the unnecessary HidDeviceInfoLinux. 3) Let all clients of HidService use device::mojom::HidDeviceInfo. Remove the scoped_refptr<HidDeviceInfo> in client side, client should own the device::mojom::HidDeviceInfo instead of sharing the same one. 4) Remove the HidService::GetDeviceInfo() which is only used by HidDeviceManager. HidDeviceManager should keep the DeviceInfo in its map. 5) Change the tests accordingly, make sure all the tests pass. TODO: 1) move client library files into device/hid/public/cpp 2) define mojo interfaces, then do mojofication. 3) host HidService by DeviceService instead of DeviceClient. 4) make sure all test cases pass after mojofication. BUG= 728223 Change-Id: I83a0d96ae4c1a8c3b4919c2b126399a10515601f Reviewed-on: https://chromium-review.googlesource.com/627738 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#498688} [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/chrome/browser/BUILD.gn [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/chrome/browser/extensions/api/device_permissions_manager_unittest.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/BUILD.gn [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_connection_unittest.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_device_filter.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_device_filter.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_device_filter_unittest.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_device_info.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_device_info.h [delete] https://crrev.com/7d7694216508cb1566116a193238e13a12938d54/device/hid/hid_device_info_linux.cc [delete] https://crrev.com/7d7694216508cb1566116a193238e13a12938d54/device/hid/hid_device_info_linux.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_service.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_service.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_service_linux.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_service_mac.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_service_unittest.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_service_win.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/hid_usage_and_page.h [add] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/public/interfaces/BUILD.gn [add] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/public/interfaces/OWNERS [add] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/public/interfaces/hid.mojom [add] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/public/interfaces/hid.typemap [add] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/public/interfaces/hid_struct_traits.cc [add] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/public/interfaces/hid_struct_traits.h [add] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/hid/public/interfaces/typemaps.gni [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/u2f/u2f_hid_device.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/u2f/u2f_hid_device.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/u2f/u2f_hid_device_unittest.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/u2f/u2f_request.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/u2f/u2f_request.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/device/u2f/u2f_request_unittest.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/device_permissions_manager.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/device_permissions_manager.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/device_permissions_prompt.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/device_permissions_prompt.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/hid/hid_api.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/hid/hid_api.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/hid/hid_device_manager.cc [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/extensions/browser/api/hid/hid_device_manager.h [modify] https://crrev.com/8a11dd33ab40ce9dca23b38a7c9f7ca8011e8077/mojo/public/tools/bindings/chromium_bindings_configuration.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2eea9362404bba232176bd46903690336b31f09 commit d2eea9362404bba232176bd46903690336b31f09 Author: Ke He <ke.he@intel.com> Date: Fri Sep 15 00:41:19 2017 Mojofication on //device/hid. In this CL: 1) Add the HidManager and HidConnection interfaces in hid.mojom, and implements those mojo interfaces in //device/hid. 2) Convert the clients in //extensions to use hid mojo interfaces. 3) Change the type of HidUsageAndPage::usage_page to uint16_t. 4) Rewrite the hid_apitest base on the new added mojo interfaces. TODO: 1) Move client library files into device/hid/public/cpp. 2) Host HidService by DeviceService instead of DeviceClient. 3) Mojofy //device/u2f Or just move it into DeviceService. BUG= 728223 Change-Id: I1de1b5211f7ef37f54d4bc18c7995a3b47cc7da2 Reviewed-on: https://chromium-review.googlesource.com/648949 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#502109} [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/chrome/browser/extensions/api/device_permissions_manager_unittest.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/BUILD.gn [add] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/hid_connection_impl.cc [add] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/hid_connection_impl.h [add] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/hid_manager_impl.cc [add] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/hid_manager_impl.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/hid_service.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/hid_usage_and_page.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/public/interfaces/hid.mojom [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/public/interfaces/hid_struct_traits.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/device/hid/public/interfaces/hid_struct_traits.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/BUILD.gn [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/api/device_permissions_prompt.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/api/hid/hid_api.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/api/hid/hid_api.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/api/hid/hid_connection_resource.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/api/hid/hid_connection_resource.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/api/hid/hid_device_manager.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/browser/api/hid/hid_device_manager.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/shell/browser/shell_device_client.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/extensions/shell/browser/shell_device_client.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/services/device/BUILD.gn [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/services/device/device_service.cc [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/services/device/device_service.h [modify] https://crrev.com/d2eea9362404bba232176bd46903690336b31f09/services/device/manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1beb176014fc291e89081a40233067859a52b5bf commit 1beb176014fc291e89081a40233067859a52b5bf Author: Ke He <ke.he@intel.com> Date: Mon Sep 25 23:42:38 2017 Remove the usage of device::HidDeviceInfo in tests. Use device::mojom::HidDeviceInfo instead, make the device::HidDeviceInfo internal of the //device/hid. So we can move the //device/hid into //services in next step. BUG= 728223 Change-Id: I5d5cbd365f1debc7a963d54b9ccffc41fddda54a Reviewed-on: https://chromium-review.googlesource.com/676946 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#504213} [modify] https://crrev.com/1beb176014fc291e89081a40233067859a52b5bf/chrome/browser/extensions/api/device_permissions_manager_unittest.cc [modify] https://crrev.com/1beb176014fc291e89081a40233067859a52b5bf/extensions/browser/api/hid/hid_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c1e93a3b0adc898f5830ae03a777ceac22d284b commit 5c1e93a3b0adc898f5830ae03a777ceac22d284b Author: Ke He <ke.he@intel.com> Date: Thu Oct 05 04:27:35 2017 Convert the u2f to use the hid mojo interface. To avoid introducing dependency on //content in //device/u2f, the client of //device/u2f is responsible for connecting the device service and passing a service_manager::Connector raw pointer. After this converting, all clients of device::HidService have been converted to use the hid mojo interface. So we move the device::HidService to be owned by HidManager which is owned by service device. Make sure all the u2f unittest pass after this converting. BUG= 728223 Change-Id: I141a88c6480937e344d2ad3a73bb2e92a24c323c Reviewed-on: https://chromium-review.googlesource.com/667801 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506649} [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/BUILD.gn [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/hid/hid_manager_impl.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/hid/hid_manager_impl.h [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/BUILD.gn [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/DEPS [add] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/fake_hid_impl_for_testing.cc [add] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/fake_hid_impl_for_testing.h [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_hid_device.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_hid_device.h [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_hid_device_unittest.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_register.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_register.h [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_register_unittest.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_request.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_request.h [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_request_unittest.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_sign.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_sign.h [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/device/u2f/u2f_sign_unittest.cc [modify] https://crrev.com/5c1e93a3b0adc898f5830ae03a777ceac22d284b/services/device/device_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aee462c73ff292a8c20b89da6c220af6cf5fafa4 commit aee462c73ff292a8c20b89da6c220af6cf5fafa4 Author: Ke He <ke.he@intel.com> Date: Thu Oct 05 04:54:14 2017 Remove the HidService reference outside //device. HidService will be internal of device service, so remove all references that outside of //device. BUG= 728223 Change-Id: I9e89c45db947f59d92c3f4a36f1317222b86b5d7 Reviewed-on: https://chromium-review.googlesource.com/700618 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506654} [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/chrome/browser/chrome_device_client.cc [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/chrome/browser/chrome_device_client.h [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/device/base/device_client.cc [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/device/base/device_client.h [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/device/base/mock_device_client.cc [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/device/base/mock_device_client.h [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/device/hid/hid_connection_unittest.cc [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/device/hid/hid_service_unittest.cc [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/device/test/test_device_client.cc [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/device/test/test_device_client.h [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/extensions/browser/api/device_permissions_manager.cc [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/extensions/browser/api/device_permissions_manager.h [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/extensions/browser/api/hid/hid_device_manager.cc [modify] https://crrev.com/aee462c73ff292a8c20b89da6c220af6cf5fafa4/extensions/shell/browser/shell_device_client.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d130aa149687b0c8df63ae8276f4ef07afca8cd commit 1d130aa149687b0c8df63ae8276f4ef07afca8cd Author: Ke He <ke.he@intel.com> Date: Fri Oct 06 01:18:53 2017 Tidy whitespace, kill useless DCHECK, use auto in one place. BUG= 728223 Change-Id: I4241852401000b5d68b9547dbd23a3d405838020 Reviewed-on: https://chromium-review.googlesource.com/701324 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506936} [modify] https://crrev.com/1d130aa149687b0c8df63ae8276f4ef07afca8cd/device/hid/public/interfaces/hid.mojom [modify] https://crrev.com/1d130aa149687b0c8df63ae8276f4ef07afca8cd/extensions/browser/api/hid/hid_api.cc [modify] https://crrev.com/1d130aa149687b0c8df63ae8276f4ef07afca8cd/extensions/browser/api/hid/hid_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/809ec4564ce9b0210139b11bf1925da4019d332d commit 809ec4564ce9b0210139b11bf1925da4019d332d Author: Ke He <ke.he@intel.com> Date: Tue Oct 10 07:10:34 2017 Add unittest for hid mojo implementations. Add unittest for hid mojo implementations after all clients have been converted to use hid mojo interface. BUG= 728223 Change-Id: I1b7b296e5f47b9bbea7059b60afbd23465661eb5 Reviewed-on: https://chromium-review.googlesource.com/667802 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#507603} [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/BUILD.gn [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/hid_manager_impl.cc [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/hid_manager_impl.h [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/hid_service.cc [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/hid_service.h [add] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/mock_hid_connection.cc [add] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/mock_hid_connection.h [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/mock_hid_service.cc [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/device/hid/mock_hid_service.h [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/services/device/BUILD.gn [add] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/services/device/hid/hid_manager_unittest.cc [modify] https://crrev.com/809ec4564ce9b0210139b11bf1925da4019d332d/services/device/unittest_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91fcb1ca508ff39be46c56ba5db04455ad33109d commit 91fcb1ca508ff39be46c56ba5db04455ad33109d Author: Ke He <ke.he@intel.com> Date: Tue Oct 17 08:29:57 2017 Remove the duplicated Hid structure definitions in C++ The HidCollectionInfo and HidUsageAndPage were defined in mojom, so the duplicated definitions in C++ should be removed. The hid.typemap and struct traits are also removed. BUG= 728223 Change-Id: Id53d19ebb930b9b60910c8b23a145dbf058a7f8a Reviewed-on: https://chromium-review.googlesource.com/708775 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509324} [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/BUILD.gn [delete] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/device/hid/hid_collection_info.cc [delete] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/device/hid/hid_collection_info.h [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_connection.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_device_filter.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_device_filter_unittest.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_device_info.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_device_info.h [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_report_descriptor.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_report_descriptor.h [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_report_descriptor_fuzzer.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_report_descriptor_item.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_report_descriptor_unittest.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_service_win.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/hid_service_win.h [delete] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/device/hid/hid_usage_and_page.cc [delete] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/device/hid/hid_usage_and_page.h [add] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/public/cpp/BUILD.gn [add] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/public/cpp/hid_usage_and_page.cc [add] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/public/cpp/hid_usage_and_page.h [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/hid/public/interfaces/hid.mojom [delete] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/device/hid/public/interfaces/hid.typemap [delete] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/device/hid/public/interfaces/hid_struct_traits.cc [delete] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/device/hid/public/interfaces/hid_struct_traits.h [delete] https://crrev.com/ef60662c9e164a2d1af17562b6e4732a516c1f8b/device/hid/public/interfaces/typemaps.gni [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/u2f/u2f_hid_device_unittest.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/device/u2f/u2f_hid_discovery_unittest.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/extensions/browser/api/device_permissions_prompt.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/extensions/browser/api/hid/hid_device_manager.cc [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/91fcb1ca508ff39be46c56ba5db04455ad33109d/services/device/hid/hid_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8de3cc279876a333a03802f2d7fdc9cf94f2593d commit 8de3cc279876a333a03802f2d7fdc9cf94f2593d Author: Donna Wu <donna.wu@intel.com> Date: Thu Oct 26 08:54:14 2017 Use base::OnceCallback instead of base::Callback in //device/hid. In this CL: 1) Replaced repeating callback to once-callback in HidService. 2) Adjusted the references to the changed callback type. BUG= 728223 Change-Id: I9f61ae4ca8e3b3587a854773b8db4627de04e8ee Reviewed-on: https://chromium-review.googlesource.com/729793 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#511768} [modify] https://crrev.com/8de3cc279876a333a03802f2d7fdc9cf94f2593d/device/hid/hid_connection_unittest.cc [modify] https://crrev.com/8de3cc279876a333a03802f2d7fdc9cf94f2593d/device/hid/hid_manager_impl.cc [modify] https://crrev.com/8de3cc279876a333a03802f2d7fdc9cf94f2593d/device/hid/hid_service.cc [modify] https://crrev.com/8de3cc279876a333a03802f2d7fdc9cf94f2593d/device/hid/hid_service.h [modify] https://crrev.com/8de3cc279876a333a03802f2d7fdc9cf94f2593d/device/hid/hid_service_linux.cc [modify] https://crrev.com/8de3cc279876a333a03802f2d7fdc9cf94f2593d/device/hid/hid_service_mac.cc [modify] https://crrev.com/8de3cc279876a333a03802f2d7fdc9cf94f2593d/device/hid/hid_service_unittest.cc [modify] https://crrev.com/8de3cc279876a333a03802f2d7fdc9cf94f2593d/device/hid/hid_service_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ab6283157101b68bc63606a5d399ebe438d3a09 commit 0ab6283157101b68bc63606a5d399ebe438d3a09 Author: Donna Wu <donna.wu@intel.com> Date: Wed Nov 01 11:34:50 2017 Update U2fPacket::GetSerializedData() to get rid of report_id. The report_id in U2fHidDevice is always 0. This CL removed it from U2fPacket payload and updated related unit tests. BUG= 728223 Change-Id: I460e0a867c111c71e5cf0939ca504b0ffb802bd6 Reviewed-on: https://chromium-review.googlesource.com/741167 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513104} [modify] https://crrev.com/0ab6283157101b68bc63606a5d399ebe438d3a09/device/u2f/u2f_hid_device.cc [modify] https://crrev.com/0ab6283157101b68bc63606a5d399ebe438d3a09/device/u2f/u2f_message_unittest.cc [modify] https://crrev.com/0ab6283157101b68bc63606a5d399ebe438d3a09/device/u2f/u2f_packet.cc [modify] https://crrev.com/0ab6283157101b68bc63606a5d399ebe438d3a09/device/u2f/u2f_packet.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59244db0c6e0535e148d66946f64993cf837907a commit 59244db0c6e0535e148d66946f64993cf837907a Author: Ke He <ke.he@intel.com> Date: Thu Nov 02 00:12:38 2017 Mechanically remove redundant device:: in Hid. BUG= 728223 Change-Id: I82add8f8844e5ac190edf965089728743c459d5f Reviewed-on: https://chromium-review.googlesource.com/748781 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#513329} [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_connection.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_connection_impl.h [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_connection_unittest.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_device_filter.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_device_filter.h [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_device_filter_unittest.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_device_info.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_device_info.h [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_manager_impl.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_manager_impl.h [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_report_descriptor.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_report_descriptor.h [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_report_descriptor_unittest.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_service.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_service.h [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_service_linux.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_service_mac.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_service_unittest.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_service_win.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/hid_service_win.h [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/input_service_linux_unittest.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/public/cpp/hid_usage_and_page.cc [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/device/hid/public/cpp/hid_usage_and_page.h [modify] https://crrev.com/59244db0c6e0535e148d66946f64993cf837907a/services/device/hid/hid_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb9bc78e78fd5b4725f8b5cf0445fcd61c001c50 commit bb9bc78e78fd5b4725f8b5cf0445fcd61c001c50 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Tue Nov 07 22:25:40 2017 Revert "Update U2fPacket::GetSerializedData() to get rid of report_id." This reverts commit 0ab6283157101b68bc63606a5d399ebe438d3a09. Reason for revert: Breaks U2fRegister & U2fSign operations. Original change's description: > Update U2fPacket::GetSerializedData() to get rid of report_id. > > The report_id in U2fHidDevice is always 0. This CL removed it from > U2fPacket payload and updated related unit tests. > > BUG= 728223 > > Change-Id: I460e0a867c111c71e5cf0939ca504b0ffb802bd6 > Reviewed-on: https://chromium-review.googlesource.com/741167 > Commit-Queue: Han Leon <leon.han@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513104} TBR=reillyg@chromium.org,donna.wu@intel.com,leon.han@intel.com,ke.he@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 728223 Change-Id: Ia7e3e2f91fc0c707c6ea97cb921a58337fa50368 Reviewed-on: https://chromium-review.googlesource.com/756936 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#514616} [modify] https://crrev.com/bb9bc78e78fd5b4725f8b5cf0445fcd61c001c50/device/u2f/u2f_hid_device.cc [modify] https://crrev.com/bb9bc78e78fd5b4725f8b5cf0445fcd61c001c50/device/u2f/u2f_message_unittest.cc [modify] https://crrev.com/bb9bc78e78fd5b4725f8b5cf0445fcd61c001c50/device/u2f/u2f_packet.cc [modify] https://crrev.com/bb9bc78e78fd5b4725f8b5cf0445fcd61c001c50/device/u2f/u2f_packet.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/624b52d729b1f1cead14c7c54df22e375199429f commit 624b52d729b1f1cead14c7c54df22e375199429f Author: Ke He <ke.he@intel.com> Date: Thu Nov 09 13:45:09 2017 move //device/hid into //services/device/hid. After the mojofication work done, move the //device/hid to //service. This is the last step of the Hid Servicification. 1) Move hid.mojom and input_service.mojom from //device/hid to //services. 2) Move client library files into //services/device/public/cpp/hid/. 3) Move other files into //service/device/hid as the internal implementation of Device Service, and make them invisible to all clients. 4) Update DEPS of all clients. BUG= 728223 Change-Id: Id4ee8e2325512e4acd9f7cdf3eed621b47b4b00a Reviewed-on: https://chromium-review.googlesource.com/749003 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515160} [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/DEPS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/chromeos/DEPS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/chromeos/login/hid_detection_browsertest.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/chromeos/login/screens/hid_detection_screen.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/extensions/api/DEPS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/chrome/browser/extensions/api/device_permissions_manager_unittest.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/components/pairing/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/components/pairing/DEPS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/components/pairing/bluetooth_host_pairing_controller.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/DEPS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/base/BUILD.gn [delete] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/device/hid/public/cpp/BUILD.gn [delete] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/device/hid/public/interfaces/BUILD.gn [delete] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/device/hid/public/interfaces/OWNERS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/u2f/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/u2f/DEPS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/u2f/fake_hid_impl_for_testing.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/u2f/u2f_hid_device.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/u2f/u2f_hid_device_unittest.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/u2f/u2f_hid_discovery.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/device/u2f/u2f_hid_discovery_unittest.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/DEPS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/device_permissions_manager.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/device_permissions_prompt.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/device_permissions_prompt.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/hid/hid_api.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/hid/hid_api.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/hid/hid_connection_resource.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/hid/hid_connection_resource.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/hid/hid_device_manager.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/browser/api/hid/hid_device_manager.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/shell/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/extensions/shell/browser/DEPS [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/BUILD.gn [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/device_service.cc [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/device_service.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/BUILD.gn [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/DEPS [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/fuzz_corpus/report0 [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/fuzz_corpus/report1 [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/fuzz_corpus/report2 [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/fuzz_corpus/report3 [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/fuzz_corpus/report4 [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_impl.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_impl.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_linux.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_linux.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_mac.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_mac.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_unittest.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_win.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_connection_win.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_device_info.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_device_info.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_manager_impl.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_manager_impl.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_manager_unittest.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_report_descriptor_fuzzer.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service_linux.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service_linux.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service_mac.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service_mac.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service_unittest.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service_win.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/hid_service_win.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/input_service_linux.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/input_service_linux.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/input_service_linux_unittest.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/mock_hid_connection.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/mock_hid_connection.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/mock_hid_service.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/mock_hid_service.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/test_report_descriptors.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/hid/test_report_descriptors.h [add] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/BUILD.gn [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/fake_input_service_linux.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/fake_input_service_linux.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_device_filter.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_device_filter.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_device_filter_unittest.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_report_descriptor.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_report_descriptor.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_report_descriptor_item.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_report_descriptor_item.h [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_report_descriptor_unittest.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_usage_and_page.cc [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/cpp/hid/hid_usage_and_page.h [modify] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/interfaces/BUILD.gn [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/interfaces/hid.mojom [rename] https://crrev.com/624b52d729b1f1cead14c7c54df22e375199429f/services/device/public/interfaces/input_service.mojom
Comment 1 by reillyg@chromium.org
, Jun 7 2017