New issue
Advanced search Search tips

Issue 728207 link

Starred by 1 user
Status: Fixed
Owner:
hinoka@chromium.org
Closed: Jun 2017
Cc:
hinoka@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Milo-bugs-Update3


Sign in to add a comment

"Interesting" in "Interesting only" is non-informative

Project Member Reported by serg...@chromium.org, May 31 2017 
The name does not suggest what we are showing. From discussion it's clear that it shows failed and running steps. Perhaps "Non-green only" is a better name.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/1c9bfc6dd8d53a83332efae04b25611bb560660f

commit 1c9bfc6dd8d53a83332efae04b25611bb560660f
Author: hinoka <hinoka@google.com>
Date: Fri Jun 02 19:28:18 2017

Milo UI tweaks

* Changed "interesting" to "non-green only"
* Added alternating colors for step links
* Constrained properties value cell width to 250px
* Reordered step title so right side would layout first
* Moved some inline styles into default.css

BUG= 726449 , 728207 , 716692 

Review-Url: https://codereview.chromium.org/2921573002

[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-Basic_successful_build.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-pending-logdog.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-pending.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/expectations/swarming.build-build-unicode.html
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/static/buildbot/css/default.css
[modify] https://crrev.com/1c9bfc6dd8d53a83332efae04b25611bb560660f/milo/appengine/frontend/templates/pages/build.html

Comment 2 by hinoka@chromium.org, Jun 6 2017

Owner: hinoka@chromium.org
Status: Fixed (was: Untriaged)
It is now "non-green only"

Comment 3 by no...@chromium.org, Jun 15 2017

Labels: Type-Bug
►

Sign in to add a comment