performance_browser_tests failing on 2 builders |
||
Issue descriptionperformance_browser_tests failing on 2 builders Builders failed on: - Win 7 ATI GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf 1 test timed out: CastV2PerformanceTest.Performance/0 (c:\b\c\b\win_x64_builder\src\chrome\browser\extensions\api\cast_streaming\performance_test.cc:706) (https://chromium-swarm.appspot.com/task?id=3676c84fa4425110&refresh=10&show_raw=1) - Win 7 x64 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf 1 test timed out: CastV2PerformanceTest.Performance/0 (c:\b\c\b\win_x64_builder\src\chrome\browser\extensions\api\cast_streaming\performance_test.cc:706) miu@: should we just disable "CastV2PerformanceTest.Performance/0" on Win config?
,
May 31 2017
In CQ...
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d53269bc5d01bbc8a24a9a3b0f2d1226650b71b6 commit d53269bc5d01bbc8a24a9a3b0f2d1226650b71b6 Author: Yuri Wiitala <miu@chromium.org> Date: Wed May 31 22:49:08 2017 CastV2PerformanceTest: Split into separate promises to RCR flakiness. On Windows perf bots, there seems to be a strange "timeout" issue with CastV2PerformanceTests.Performance/0 (and none of the others). From the logs, it seems one of the async extension API calls may be blocked (or is throwing an exception). This change splits the individual ext API calls into separate Promises, each with a separate timeout handler and error message that will help us narrow-down the root-cause of the flakiness. BUG= 728206 TBR=xjz@chromium.org Change-Id: I7357bd9f8f5dc50b9a60c93d7a100ab64594ed3d Reviewed-on: https://chromium-review.googlesource.com/518662 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#476075} [modify] https://crrev.com/d53269bc5d01bbc8a24a9a3b0f2d1226650b71b6/chrome/test/data/extensions/api_test/cast_streaming/performance.js
,
Jun 2 2017
Welp, in the latest runs, things are green. Will monitor over the next few days...
,
Jun 2 2017
Thanks for the quick fix! You rocks!
,
Jun 3 2017
Strangely, the flake went away completely, and all the bots are green now. Maybe I inadvertently fixed something (or just changed the timing causing the flake)? Welp, if the tests go red again, feel free to re-open. |
||
►
Sign in to add a comment |
||
Comment 1 by m...@chromium.org
, May 31 2017