New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728190 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Search and info icons are not present at first when there are no downloads in downloads home

Project Member Reported by rachelis@chromium.org, May 31 2017

Issue description

... but after downloading some stuff and deleting it, then they're back.

We should keep the behavior consistent across all the list views (Bookmarks, History, Downloads). We'd recommend just keeping the icons there always, rather than removing them when there is no content.
 
Components: UI>Browser>Downloads
Status: Assigned (was: Untriaged)
Labels: Needs-Feedback
Need some feedback.
For no downloads, currently we have a background with a download icon in the middle of the page saying "No download here".

If I suggest the recommendation to keep the info and search icon always, in the event there are no downloads, turning on and off the info switches the background between blank page with info text and "no downloads here" page without info text.

What should be the behavior of the info button and the background when there are no downloads?


no_download_with_info.png
62.3 KB View Download
no_download_with_info_off.png
49.3 KB View Download
I guess the question is should we have the disk space info message in the "no download here" page too?
I think that if we want to show the space display when there are no downloads we should still show the "No downloads here" text and download icon below the space display. This will require some work but it shouldn't be too hard to implement. One option is to modify the XML for the "No downloads here" layout to include a view for the space display.

Hiding the toggle (and never showing the space display) when there aren't any downloads should be trivial to implement.

We should also consider the history screen when making this decision. History has privacy disclaimers and a clear browsing data button that aren't shown when the "No history here" view is showing.
//I think that if we want to show the space display when there are no downloads we should still show the "No downloads here" text and download icon below the space display. 

I agree with Teresa. 
Issue 731622 has been merged into this issue.
Thanks Rachel. 
Since downloads and history share the same code, should we also have History privacy disclaimers/clear browsing data button have the same behavior?
I expect that the History privacy disclaimers/clear browsing data button should have the same behavior, but I'll defer to Chris for those. Chris?
Cc: -kings...@google.com

Sign in to add a comment