New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728188 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Adapt ARC account provisioning flow for AD users

Project Member Reported by ljusten@chromium.org, May 31 2017

Issue description

1. Ensure that the screen with ToS, B&R, and GLS never shows for AD. We also want to force-disable B&R and GLS (though LaForge accounts don't have those scopes, but just to stay on the safe side and future-proof)

2. Add an interstitial as described in the UX review thread. That should live in the user session (where the user is capable of opening a tab vs. the new login screen placement where UI will be blocked). The updated string (still pending UI review) is:

"To enable your account to access the Google Play Store, you will need to authenticate with your Identity Provider. Please click Next to proceed."

First take will show the Play Store at the end of this flow vs. a "Finished" screen.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a5e84e91f798ac466b282d265d8cb0b25f99cf

commit 92a5e84e91f798ac466b282d265d8cb0b25f99cf
Author: Lutz Justen <ljusten@chromium.org>
Date: Fri Jun 02 14:35:37 2017

chromeos_strings: Add ARC+Active Directory related strings

Adds UI strings shown to Active Directory users during ARC account
provisioning to inform them that they have to authenticate with
Active Directory.

BUG= 728188 
TEST=Compiles, used new strings in code to be submitted later

Change-Id: Ib29662b0be6db1b9320565752f0e27697e0fe9a3
Reviewed-on: https://chromium-review.googlesource.com/519406
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476638}
[modify] https://crrev.com/92a5e84e91f798ac466b282d265d8cb0b25f99cf/chrome/app/chromeos_strings.grdp

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 3 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: There is .grd file changes and we are only 58 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
To add some context, until the planned launch in M60 this feature will only affect a few English-speaking testers during the beta phase, so not having translations during beta won't affect anyone. The feature is also gated server-side on a new type of CDM account, which is not publicly available yet, so nobody can accidentally trigger these strings.
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68d1c6cd2ffdf05295389891b4ef3772e72b55c0

commit 68d1c6cd2ffdf05295389891b4ef3772e72b55c0
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Wed Jun 07 16:31:56 2017

chromeos_strings: Add ARC+Active Directory related strings

Adds UI strings shown to Active Directory users during ARC account
provisioning to inform them that they have to authenticate with
Active Directory.

(Cherry-picked by me on behalf of ljusten.)

BUG= 728188 
TEST=Compiles, used new strings in code to be submitted later

Change-Id: Ib29662b0be6db1b9320565752f0e27697e0fe9a3
Reviewed-on: https://chromium-review.googlesource.com/519406
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#476638}
Review-Url: https://codereview.chromium.org/2930693002 .
Cr-Commit-Position: refs/branch-heads/3112@{#223}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/68d1c6cd2ffdf05295389891b4ef3772e72b55c0/chrome/app/chromeos_strings.grdp

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36fb29ec88440b9b85765b2b653a52c56b20e6f

commit b36fb29ec88440b9b85765b2b653a52c56b20e6f
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Jun 20 20:42:34 2017

ARC: Adapt ARC account provisioning flow for AD users

Modifies the ARC account provisioning for Active Directory users.
Does not show a ToS page since for AD users both arc-enabled and
metrics-enabled policies are always managed and the backup-and-
restore and location-services prefs are unused as DM server creates
LaForge accounts for AD users.
Instead, shows a page informing the user that they have to
authenticate with Active Directory. This is necessary to prove the
user's identity to DM server for creating the LaForge account. The
prove of identity works through a SAML flow.
ArcActiveDirectoryEnrollmentTokenFetcher pops up a browser window
connecting to AD Federation Services. Without the shown page, it
would be weird to pop up a browser window that might ask for
credentials.
The backup-and-restore and location-services prefs are left untouched
at their defaults, which is off.

BUG= chromium:728188 
TEST=out/Release/unit_tests --gtest_filter=Arc*

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f6a63038705e71d29a92557a2b62325eae23d0b
Reviewed-on: https://chromium-review.googlesource.com/521502
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480942}
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/arc_support_host.h
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/arc_util.h
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/extensions/fake_arc_support.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/extensions/fake_arc_support.h
[add] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/optin/arc_active_directory_auth_negotiator.cc
[add] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/optin/arc_active_directory_auth_negotiator.h
[add] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/arc/optin/arc_active_directory_auth_negotiator_unittest.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/b36fb29ec88440b9b85765b2b653a52c56b20e6f/chrome/browser/resources/chromeos/arc_support/main.html

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment