New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728184 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 727870
issue 728914



Sign in to add a comment

M60: Release builders not revving latest chrome revved by PFQ

Project Member Reported by josa...@chromium.org, May 31 2017

Issue description

M60 builders are not building with latest chrome rev by PFQ

See: PFQ successfully up revving Chrome here:
https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-chrome-pre-flight-branch%20release-R60-9592.B/builds/1

snippet:
17:27:31: INFO: Stable candidate found /home/chrome-bot/trunk/src/third_party/chromiumos-overlay/chromeos-base/chromeos-chrome/chromeos-chrome-60.0.3112.0-r1.ebuild

STEP_LINK: Chromium revisions; http://omahaproxy.appspot.com/changelog?old_version=60.0.3112.0&new_version=60.0.3112.9
17:27:31: INFO: Committing changes with commit message: Marking stable_release for chromeos-chrome ebuild with version 60.0.3112.9 as stable.
17:27:31: INFO: Cleaning up stale packages [u'chromeos-base/chromeos-chrome-60.0.3112.9_rc-r1'].


However, builder keep building 60.0.3112.0
https://uberchromegw.corp.google.com/i/chromeos_release/builders/auron_paine-release%20release-R60-9592.B/builds/1/steps/SyncChrome/logs/stdio




 
I see PFQ is properly revving chrome but somehow the Master and other slaves keep building .0 

jdufault@ any ideas what may be wrong here?
Cc: bhthompson@chromium.org
Owner: nya@chromium.org
I see missing publish artifact phase in the PFQ 

+nya@ to see if this may be related to other refactoring work for android PFQ 

Comment 3 by estaab@chromium.org, May 31 2017

Components: -Infra Infra>Client>ChromeOS

Comment 4 by nya@chromium.org, Jun 1 2017

Status: Started (was: Untriaged)
I guess it's due to failures in AFDO stages? I'll take a look.

Comment 5 by nya@chromium.org, Jun 1 2017

Blockedon: 727870
AFDO is broken due to  Issue 727870 .

Comment 6 by josa...@google.com, Jun 1 2017

Labels: -ReleaseBlock-Dev

Comment 7 by nya@chromium.org, Jun 2 2017

Blockedon: 728914

Comment 8 by nya@chromium.org, Jun 2 2017

 Issue 727870  fixed, but there's one more:  Issue 728914  making BuildPackage yellow.
ok, seems like both of the above issues are fixed and we just need to merge CL on  issue 728914  to M60. I have approved that so please go ahead and merge to validate on next pfq

Comment 10 by nya@chromium.org, Jun 3 2017

Ugh, no, I just realized this is a bug I introduced in 
https://chromium-review.googlesource.com/c/505955/4/cbuildbot/chromeos_config.py
that push_overlays was accidentally removed. I'll send a fix.

Comment 12 by nya@chromium.org, Jun 3 2017

Labels: Merge-Request-60
Requesting M60 merge of CL:523343 in advance...

Project Member

Comment 13 by sheriffbot@chromium.org, Jun 4 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b27251359cda957f2464d5c83f4a0436fe2ac602

commit b27251359cda957f2464d5c83f4a0436fe2ac602
Author: Shuhei Takahashi <nya@chromium.org>
Date: Mon Jun 05 23:39:52 2017

chromeos_config: Set push_overlays to pre_flight_branch.

push_overlays was accidentally removed in CL:505955.

BUG= chromium:728184 
TEST=cbuiltbot/run_tests

Change-Id: Ia44a7e0981b889f91fa7d31f44f321185b6c08bb
Reviewed-on: https://chromium-review.googlesource.com/523343
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/b27251359cda957f2464d5c83f4a0436fe2ac602/cbuildbot/config_dump.json
[modify] https://crrev.com/b27251359cda957f2464d5c83f4a0436fe2ac602/cbuildbot/chromeos_config.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b27251359cda957f2464d5c83f4a0436fe2ac602

commit b27251359cda957f2464d5c83f4a0436fe2ac602
Author: Shuhei Takahashi <nya@chromium.org>
Date: Mon Jun 05 23:39:52 2017

chromeos_config: Set push_overlays to pre_flight_branch.

push_overlays was accidentally removed in CL:505955.

BUG= chromium:728184 
TEST=cbuiltbot/run_tests

Change-Id: Ia44a7e0981b889f91fa7d31f44f321185b6c08bb
Reviewed-on: https://chromium-review.googlesource.com/523343
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/b27251359cda957f2464d5c83f4a0436fe2ac602/cbuildbot/config_dump.json
[modify] https://crrev.com/b27251359cda957f2464d5c83f4a0436fe2ac602/cbuildbot/chromeos_config.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 6 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7bee4b84485587d54ad9191abb3ea8a6ec1208d

commit b7bee4b84485587d54ad9191abb3ea8a6ec1208d
Author: Shuhei Takahashi <nya@chromium.org>
Date: Tue Jun 06 00:18:15 2017

chromeos_config: Set push_overlays to pre_flight_branch.

push_overlays was accidentally removed in CL:505955.

BUG= chromium:728184 
TEST=cbuiltbot/run_tests

Change-Id: Ia44a7e0981b889f91fa7d31f44f321185b6c08bb
Reviewed-on: https://chromium-review.googlesource.com/523343
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
(cherry picked from commit b27251359cda957f2464d5c83f4a0436fe2ac602)
Reviewed-on: https://chromium-review.googlesource.com/524893
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Commit-Queue: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/b7bee4b84485587d54ad9191abb3ea8a6ec1208d/cbuildbot/config_dump.json
[modify] https://crrev.com/b7bee4b84485587d54ad9191abb3ea8a6ec1208d/cbuildbot/chromeos_config.py

Comment 17 by nya@chromium.org, Jun 6 2017

Finally PublishUprevChanges stage is running:
https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-chrome-pre-flight-branch%20release-R60-9592.B/builds/33

I'm waiting for next android-pre-flight-branch build to start.

Comment 18 by nya@chromium.org, Jun 7 2017

Status: Fixed (was: Started)
Android uprev not working, but this bug is about Chrome so I'm closing this now. Android uprev is tracked in  Issue 730313 .

Comment 19 by nya@chromium.org, Jun 7 2017

Labels: -Merge-Approved-60

Comment 20 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment