New issue
Advanced search Search tips

Issue 728177 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: 2017-06-10
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove generate_telemetry_harness.sh script

Project Member Reported by nedngu...@google.com, May 31 2017

Issue description

This script is used for generating a zip that contains all Telemetry dependencies. No one uses this feature, so we should just remove it to reduce code complexity in tools/perf.
 
The NextAction date has arrived: 2017-06-10
Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/683a4557dae870a6a387bc739b6cdc89280e99d6

commit 683a4557dae870a6a387bc739b6cdc89280e99d6
Author: nednguyen <nednguyen@google.com>
Date: Mon Jun 12 17:59:19 2017

Revert of Remove find_dependencies script (patchset #1 id:1 of https://codereview.chromium.org/2932213002/ )

Reason for revert:
find_dependencies is still used.

Original issue's description:
> Remove find_dependencies script
>
> BUG= chromium:728177 
>
> Review-Url: https://codereview.chromium.org/2932213002
> Cr-Commit-Position: refs/heads/master@{#478658}
> Committed: https://chromium.googlesource.com/chromium/src/+/e5ee4f9d1a7815c320dadb315675449a710c19aa

TBR=charliea@chromium.org,stevenjb@chromium.org,achuith@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:728177 

Review-Url: https://codereview.chromium.org/2933163002
Cr-Commit-Position: refs/heads/master@{#478675}

[add] https://crrev.com/683a4557dae870a6a387bc739b6cdc89280e99d6/tools/perf/core/bootstrap.py
[add] https://crrev.com/683a4557dae870a6a387bc739b6cdc89280e99d6/tools/perf/core/find_dependencies.py
[add] https://crrev.com/683a4557dae870a6a387bc739b6cdc89280e99d6/tools/perf/core/find_dependencies_unittest.py
[add] https://crrev.com/683a4557dae870a6a387bc739b6cdc89280e99d6/tools/perf/find_dependencies
[add] https://crrev.com/683a4557dae870a6a387bc739b6cdc89280e99d6/tools/perf/third_party/__init__.py
[add] https://crrev.com/683a4557dae870a6a387bc739b6cdc89280e99d6/tools/perf/third_party/davclient/README.chromium
[add] https://crrev.com/683a4557dae870a6a387bc739b6cdc89280e99d6/tools/perf/third_party/davclient/__init__.py
[add] https://crrev.com/683a4557dae870a6a387bc739b6cdc89280e99d6/tools/perf/third_party/davclient/davclient.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb515a5ed7789d3369ea51e20d164f99f6704135

commit fb515a5ed7789d3369ea51e20d164f99f6704135
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Mon Jun 12 18:26:01 2017

Roll src/third_party/catapult/ a5ece949f..7ba431f75 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a5ece949fa04..7ba431f75da5

$ git log a5ece949f..7ba431f75 --date=short --no-merges --format='%ad %ae %s'
2017-06-12 nednguyen Remove generate_telemetry_harness script

Created with:
  roll-dep src/third_party/catapult
BUG= 728177 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ibf94dfa26bace6a6e9f8fd3fae0237cc08e74ebe
Reviewed-on: https://chromium-review.googlesource.com/531445
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478688}
[modify] https://crrev.com/fb515a5ed7789d3369ea51e20d164f99f6704135/DEPS

Sign in to add a comment