Increase SubresourceFcpOrder test timeout |
||||||
Issue descriptionSubresourceFcpOrder currently uses a 1.5s timeout to work around buffering of FCP. As part of addressing bug 726387 we'll add additional buffering which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step we should increase the timeout in the SubresourceFcpOrder test so we can address bug 726387 .
,
May 31 2017
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f326c6ec562cdbe58f9a958ca02758c620688d2 commit 1f326c6ec562cdbe58f9a958ca02758c620688d2 Author: bmcquade <bmcquade@chromium.org> Date: Wed May 31 16:12:26 2017 Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387 . BUG= 728176 TBR=lizeb Review-Url: https://codereview.chromium.org/2918563002 Cr-Commit-Position: refs/heads/master@{#475933} [modify] https://crrev.com/1f326c6ec562cdbe58f9a958ca02758c620688d2/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc
,
May 31 2017
,
Jun 2 2017
,
Jun 2 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2928419b78852575abb974d5426e356e75733efb commit 2928419b78852575abb974d5426e356e75733efb Author: bmcquade <bmcquade@chromium.org> Date: Fri Jun 02 20:55:48 2017 Increase SubresourceFcpOrder resource delay. The SubresourceFcpOrder test currently uses a 1.5s timeout to work around buffering of FCP in page load metrics. As part of addressing bug 726387 we'll add an additional 1s of buffering, which will cause this test to fail. We should break the prefetch predictor being affected by buffering altogether (bug 728156), but as a first step this change increases the timeout in the SubresourceFcpOrder test so we can address bug 726387 . BUG= 728176 NOTRY=true NOPRESUBMIT=true TBR=mattcary Review-Url: https://codereview.chromium.org/2918563002 Cr-Original-Commit-Position: refs/heads/master@{#475933} Review-Url: https://codereview.chromium.org/2921793003 Cr-Commit-Position: refs/branch-heads/3112@{#125} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/2928419b78852575abb974d5426e356e75733efb/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bmcquade@chromium.org
, May 31 2017Status: Assigned (was: Untriaged)