VR URL bar lock icon should not have a hole in it |
||||||
Issue descriptionThe lock icon used by the URL bar isn't ui::kLockIcon. ui::kLockIcon has a key hole in the lock, where the URL bar must not. Make sure that the lock, info and warning icons are all correct.
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fabef214e234775f39979def43eaaa3d92ce6494 commit fabef214e234775f39979def43eaaa3d92ce6494 Author: Christopher Grant <cjgrant@google.com> Date: Mon Jun 05 23:41:16 2017 Use desktop toolbar icons in VR. Previously, VR was using similar-looking icons to the desktop location bar. This CL switches to use the same icons. As a result, the VR lock icon no longer has a key-hole in it. BUG= 728175 Change-Id: I3c7af24303db28d5de5157ed6cf37c362d70cc88 Reviewed-on: https://chromium-review.googlesource.com/521322 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#477120} [modify] https://crrev.com/fabef214e234775f39979def43eaaa3d92ce6494/chrome/browser/android/vr_shell/BUILD.gn [modify] https://crrev.com/fabef214e234775f39979def43eaaa3d92ce6494/chrome/browser/android/vr_shell/textures/url_bar_texture.cc [modify] https://crrev.com/fabef214e234775f39979def43eaaa3d92ce6494/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/fabef214e234775f39979def43eaaa3d92ce6494/components/toolbar/BUILD.gn
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fabef214e234775f39979def43eaaa3d92ce6494 commit fabef214e234775f39979def43eaaa3d92ce6494 Author: Christopher Grant <cjgrant@google.com> Date: Mon Jun 05 23:41:16 2017 Use desktop toolbar icons in VR. Previously, VR was using similar-looking icons to the desktop location bar. This CL switches to use the same icons. As a result, the VR lock icon no longer has a key-hole in it. BUG= 728175 Change-Id: I3c7af24303db28d5de5157ed6cf37c362d70cc88 Reviewed-on: https://chromium-review.googlesource.com/521322 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#477120} [modify] https://crrev.com/fabef214e234775f39979def43eaaa3d92ce6494/chrome/browser/android/vr_shell/BUILD.gn [modify] https://crrev.com/fabef214e234775f39979def43eaaa3d92ce6494/chrome/browser/android/vr_shell/textures/url_bar_texture.cc [modify] https://crrev.com/fabef214e234775f39979def43eaaa3d92ce6494/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/fabef214e234775f39979def43eaaa3d92ce6494/components/toolbar/BUILD.gn
,
Jun 6 2017
,
Jun 6 2017
Please tag with appropriate OSs.
,
Jun 6 2017
,
Jun 6 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49e1d0dfe45f9c748178eac73e41266534c10c90 commit 49e1d0dfe45f9c748178eac73e41266534c10c90 Author: Christopher Grant <cjgrant@google.com> Date: Tue Jun 06 18:12:50 2017 Use desktop toolbar icons in VR. Previously, VR was using similar-looking icons to the desktop location bar. This CL switches to use the same icons. As a result, the VR lock icon no longer has a key-hole in it. BUG= 728175 Change-Id: I3c7af24303db28d5de5157ed6cf37c362d70cc88 Reviewed-on: https://chromium-review.googlesource.com/521322 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#477120} Review-Url: https://codereview.chromium.org/2923843002 . Cr-Commit-Position: refs/branch-heads/3112@{#192} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/49e1d0dfe45f9c748178eac73e41266534c10c90/chrome/browser/android/vr_shell/BUILD.gn [modify] https://crrev.com/49e1d0dfe45f9c748178eac73e41266534c10c90/chrome/browser/android/vr_shell/textures/url_bar_texture.cc [modify] https://crrev.com/49e1d0dfe45f9c748178eac73e41266534c10c90/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/49e1d0dfe45f9c748178eac73e41266534c10c90/components/toolbar/BUILD.gn
,
Jun 6 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by cjgrant@chromium.org
, Jun 5 2017