Don't show shipping option section if there're no shipping options to display |
|||||
Issue descriptionURLs (if applicable) : https://emerald-eon.appspot.com/ What steps will reproduce the problem? 1. Click "Demo" on https://emerald-eon.appspot.com/. What is the expected result? Shipping option section should be absent, because there're no shipping options. What happens instead of that? Shipping option section is displayed without any shipping options.
,
May 31 2017
wuandy@, could you take a look if this is required since you worked on those codes recently,
,
Jun 13 2017
Talked to Zach. We agree the shipping option should not be shown if it's empty. Ganggui: can you look into this? (You reviewed Andy's change to the shipping option section.)
,
Jun 16 2017
Okay, so this is only the case on the bottom sheet, right?
,
Jun 16 2017
Bottom sheet is highest priority. If you can get it removed from fullscreen sheet as well, that would be great.
,
Jun 16 2017
So the shipping options may change (add or remove) dynamically based on users operation (like select different shipping addresses) on expanded sheet, then the shipping option section has to show and hide dynamically. Is this what we preferred?
,
Jun 16 2017
Here we can be guided by what's the simplest to implement. I would prefer to hide the shipping option only initially, but always show it after the first set of shipping options comes from the website. If shipping options are later removed, gray out the "SELECT" button for the shipping options section. If the amount of effort to implement this is disproportionate, we can be less fancy.
,
Jun 16 2017
,
Jun 16 2017
Amazing! Ship it.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e10aedf65eacdd8b5f31355318a29cdf40e886a6 commit e10aedf65eacdd8b5f31355318a29cdf40e886a6 Author: gogerald <gogerald@chromium.org> Date: Fri Jun 16 20:14:33 2017 Only show shipping option section once there are shipping options BUG= 728173 Review-Url: https://codereview.chromium.org/2940353002 Cr-Commit-Position: refs/heads/master@{#480146} [modify] https://crrev.com/e10aedf65eacdd8b5f31355318a29cdf40e886a6/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
,
Jun 16 2017
,
Jun 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by gogerald@chromium.org
, May 31 2017