[MacViews] Wire up ExtensionInstalledBubble |
||||||||||||||||
Issue descriptionThis is the bubble that shows when an extension is sideloaded; it is created in ExtensionInstalledBubble::BuildBubbleUi().
,
Jun 8 2017
Mock is in Issue 654125 . Issue 729513 is effectively a dupe. I'll drag it in here and take this.
,
Jun 8 2017
Issue 729513 has been merged into this issue.
,
Jul 13 2017
,
Jul 19 2017
,
Jul 25 2017
Screenshots of the dialog with --secondary-ui-md in all its guises. Something like $ echo InstalledByDefault NoAction PageAction BrowserAction Omnibox SignedIn | xargs -n1 -IX ./browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive --gtest_filter=ExtensionInstalledBubbleBrowserTest.InvokeDialog_X will show them all (once #c5 lands)
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f834624c64fddccd1257f3c06deb50d76af3ed9e commit f834624c64fddccd1257f3c06deb50d76af3ed9e Author: Trent Apted <tapted@chromium.org> Date: Thu Jul 27 15:19:42 2017 MacViews: Show toolkit-views ExtensionInstalledBubbles with --secondary-ui-md And adds dialog tests to easily show these bubbles in 6 different guises. These can be shown, e.g., with $ browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive \ --gtest_filter=ExtensionInstalledBubbleBrowserTest.InvokeDialog_Omnibox Bug: 728169 Change-Id: I806f54295d7735d776b2ca47e94568a1b8f1c287 Reviewed-on: https://chromium-review.googlesource.com/572511 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#489929} [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/extensions/extension_action_test_util.cc [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/extensions/extension_action_test_util.h [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/ui/cocoa/browser_dialogs_views_mac.h [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/ui/extensions/extension_installed_bubble.h [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc [modify] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc [add] https://crrev.com/f834624c64fddccd1257f3c06deb50d76af3ed9e/chrome/browser/ui/views/extensions/extension_installed_bubble_view.h
,
Oct 9 2017
This looks from #7 like it was fixed. |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by tapted@chromium.org
, Jun 8 2017Labels: Phase3 Proj-MacViews